[PATCH] btrfs-progs: convert-tests: Add test for backup superblock migration

[PATCH] btrfs-progs: convert-tests: Add test for backup superblock migration

[Qu Wenruo]

New convert framework uses new and simpler chunk layout, while the cost
is the more complex superblock range migration logical, compared to old
convert.

Enhance the convert test script to create file which will takes up 2nd
backup superblock space, to ensure the superblock migration is working
as expected.

Suggested-by: David Sterba <dsterba@suse.cz>
Signed-off-by: Qu Wenruo <quwenruo@cn.fujitsu.com>
---
 tests/convert-tests.sh | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/tests/convert-tests.sh b/tests/convert-tests.sh
index 06d8419..d4e13d6 100755
--- a/tests/convert-tests.sh
+++ b/tests/convert-tests.sh
@@ -124,6 +124,12 @@ convert_test() {
 	# create a file to check btrfs-convert can convert regular file
 	# correct
 	run_check_mount_test_dev
+
+	# create a file inside the fs before convert, to make sure there is
+	# data covering btrfs backup superblock range (64M)
+	run_check $SUDO_HELPER dd if=/dev/zero bs=1M count=64 \
+		of=$TEST_MNT/convert_space_holder
+
 	populate_fs
 	run_check $SUDO_HELPER dd if=/dev/zero of=$TEST_MNT/test bs=$nodesize \
 		count=1 >/dev/null 2>&1
-- 
2.8.3

Re: [PATCH] btrfs-progs: convert-tests: Add test for backup superblock migration

[David Sterba]

On Wed, Jun 01, 2016 at 09:51:21AM +0800, Qu Wenruo wrote:
> New convert framework uses new and simpler chunk layout, while the cost
> is the more complex superblock range migration logical, compared to old
> convert.
> 
> Enhance the convert test script to create file which will takes up 2nd
> backup superblock space, to ensure the superblock migration is working
> as expected.
> 
> Suggested-by: David Sterba <dsterba@suse.cz>
> Signed-off-by: Qu Wenruo <quwenruo@cn.fujitsu.com>

Applied, thanks.