From: Michal Hocko <mhocko@kernel.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Mel Gorman <mgorman@techsingularity.net>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
David Rientjes <rientjes@google.com>,
Rik van Riel <riel@redhat.com>
Subject: Re: [PATCH v2 18/18] mm, vmscan: use proper classzone_idx in should_continue_reclaim()
Date: Wed, 1 Jun 2016 17:45:46 +0200 [thread overview]
Message-ID: <20160601154546.GZ26601@dhcp22.suse.cz> (raw)
In-Reply-To: <574EFCFE.1000903@suse.cz>
On Wed 01-06-16 17:19:26, Vlastimil Babka wrote:
> On 06/01/2016 04:21 PM, Michal Hocko wrote:
> > On Tue 31-05-16 15:08:18, Vlastimil Babka wrote:
> > [...]
> >> @@ -2364,11 +2350,12 @@ static inline bool should_continue_reclaim(struct zone *zone,
> >> }
> >>
> >> static bool shrink_zone(struct zone *zone, struct scan_control *sc,
> >> - bool is_classzone)
> >> + int classzone_idx)
> >> {
> >> struct reclaim_state *reclaim_state = current->reclaim_state;
> >> unsigned long nr_reclaimed, nr_scanned;
> >> bool reclaimable = false;
> >> + bool is_classzone = (classzone_idx == zone_idx(zone));
> >>
> >> do {
> >> struct mem_cgroup *root = sc->target_mem_cgroup;
> >> @@ -2450,7 +2437,7 @@ static bool shrink_zone(struct zone *zone, struct scan_control *sc,
> >> reclaimable = true;
> >>
> >> } while (should_continue_reclaim(zone, sc->nr_reclaimed - nr_reclaimed,
> >> - sc->nr_scanned - nr_scanned, sc));
> >> + sc->nr_scanned - nr_scanned, sc, classzone_idx));
> >>
> >> return reclaimable;
> >> }
> >> @@ -2580,7 +2567,7 @@ static void shrink_zones(struct zonelist *zonelist, struct scan_control *sc)
> >> /* need some check for avoid more shrink_zone() */
> >> }
> >>
> >> - shrink_zone(zone, sc, zone_idx(zone) == classzone_idx);
> >> + shrink_zone(zone, sc, classzone_idx);
> >
> > this should be is_classzone, right?
>
> No, this is shrink_zones() context, not shrink_zone().
Ohh, right. They read to similar. I didn't spot anything else.
Acked-by: Michal Hocko <mhocko@suse.com>
--
Michal Hocko
SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Mel Gorman <mgorman@techsingularity.net>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
David Rientjes <rientjes@google.com>,
Rik van Riel <riel@redhat.com>
Subject: Re: [PATCH v2 18/18] mm, vmscan: use proper classzone_idx in should_continue_reclaim()
Date: Wed, 1 Jun 2016 17:45:46 +0200 [thread overview]
Message-ID: <20160601154546.GZ26601@dhcp22.suse.cz> (raw)
In-Reply-To: <574EFCFE.1000903@suse.cz>
On Wed 01-06-16 17:19:26, Vlastimil Babka wrote:
> On 06/01/2016 04:21 PM, Michal Hocko wrote:
> > On Tue 31-05-16 15:08:18, Vlastimil Babka wrote:
> > [...]
> >> @@ -2364,11 +2350,12 @@ static inline bool should_continue_reclaim(struct zone *zone,
> >> }
> >>
> >> static bool shrink_zone(struct zone *zone, struct scan_control *sc,
> >> - bool is_classzone)
> >> + int classzone_idx)
> >> {
> >> struct reclaim_state *reclaim_state = current->reclaim_state;
> >> unsigned long nr_reclaimed, nr_scanned;
> >> bool reclaimable = false;
> >> + bool is_classzone = (classzone_idx == zone_idx(zone));
> >>
> >> do {
> >> struct mem_cgroup *root = sc->target_mem_cgroup;
> >> @@ -2450,7 +2437,7 @@ static bool shrink_zone(struct zone *zone, struct scan_control *sc,
> >> reclaimable = true;
> >>
> >> } while (should_continue_reclaim(zone, sc->nr_reclaimed - nr_reclaimed,
> >> - sc->nr_scanned - nr_scanned, sc));
> >> + sc->nr_scanned - nr_scanned, sc, classzone_idx));
> >>
> >> return reclaimable;
> >> }
> >> @@ -2580,7 +2567,7 @@ static void shrink_zones(struct zonelist *zonelist, struct scan_control *sc)
> >> /* need some check for avoid more shrink_zone() */
> >> }
> >>
> >> - shrink_zone(zone, sc, zone_idx(zone) == classzone_idx);
> >> + shrink_zone(zone, sc, classzone_idx);
> >
> > this should be is_classzone, right?
>
> No, this is shrink_zones() context, not shrink_zone().
Ohh, right. They read to similar. I didn't spot anything else.
Acked-by: Michal Hocko <mhocko@suse.com>
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-06-01 15:45 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 13:08 [PATCH v2 00/18] make direct compaction more deterministic Vlastimil Babka
2016-05-31 13:08 ` Vlastimil Babka
2016-05-31 13:08 ` [PATCH v2 01/18] mm, compaction: don't isolate PageWriteback pages in MIGRATE_SYNC_LIGHT mode Vlastimil Babka
2016-05-31 13:08 ` Vlastimil Babka
2016-05-31 13:08 ` [PATCH v2 02/18] mm, page_alloc: set alloc_flags only once in slowpath Vlastimil Babka
2016-05-31 13:08 ` Vlastimil Babka
2016-05-31 13:08 ` [PATCH v2 03/18] mm, page_alloc: don't retry initial attempt " Vlastimil Babka
2016-05-31 13:08 ` Vlastimil Babka
2016-06-01 13:26 ` Michal Hocko
2016-06-01 13:26 ` Michal Hocko
2016-06-01 14:58 ` Vlastimil Babka
2016-06-01 14:58 ` Vlastimil Babka
2016-05-31 13:08 ` [PATCH v2 04/18] mm, page_alloc: restructure direct compaction handling " Vlastimil Babka
2016-05-31 13:08 ` Vlastimil Babka
2016-05-31 13:08 ` [PATCH v2 05/18] mm, page_alloc: make THP-specific decisions more generic Vlastimil Babka
2016-05-31 13:08 ` Vlastimil Babka
2016-05-31 13:08 ` [PATCH v2 06/18] mm, thp: remove __GFP_NORETRY from khugepaged and madvised allocations Vlastimil Babka
2016-05-31 13:08 ` Vlastimil Babka
2016-06-01 13:33 ` Michal Hocko
2016-06-01 13:33 ` Michal Hocko
2016-05-31 13:08 ` [PATCH v2 07/18] mm, compaction: introduce direct compaction priority Vlastimil Babka
2016-05-31 13:08 ` Vlastimil Babka
2016-05-31 13:08 ` [PATCH v2 08/18] mm, compaction: simplify contended compaction handling Vlastimil Babka
2016-05-31 13:08 ` Vlastimil Babka
2016-05-31 13:08 ` [PATCH v2 09/18] mm, compaction: make whole_zone flag ignore cached scanner positions Vlastimil Babka
2016-05-31 13:08 ` Vlastimil Babka
2016-05-31 13:08 ` [PATCH v2 10/18] mm, compaction: cleanup unused functions Vlastimil Babka
2016-05-31 13:08 ` Vlastimil Babka
2016-06-01 13:45 ` Michal Hocko
2016-06-01 13:45 ` Michal Hocko
2016-05-31 13:08 ` [PATCH v2 11/18] mm, compaction: add the ultimate direct compaction priority Vlastimil Babka
2016-05-31 13:08 ` Vlastimil Babka
2016-05-31 13:08 ` [PATCH v2 12/18] mm, compaction: more reliably increase " Vlastimil Babka
2016-05-31 13:08 ` Vlastimil Babka
2016-06-01 13:51 ` Michal Hocko
2016-06-01 13:51 ` Michal Hocko
2016-06-23 14:41 ` Vlastimil Babka
2016-06-23 14:41 ` Vlastimil Babka
2016-05-31 13:08 ` [PATCH v2 13/18] mm, compaction: use correct watermark when checking allocation success Vlastimil Babka
2016-05-31 13:08 ` Vlastimil Babka
2016-06-01 13:59 ` Michal Hocko
2016-06-01 13:59 ` Michal Hocko
2016-05-31 13:08 ` [PATCH v2 14/18] mm, compaction: create compact_gap wrapper Vlastimil Babka
2016-05-31 13:08 ` Vlastimil Babka
2016-06-01 14:02 ` Michal Hocko
2016-06-01 14:02 ` Michal Hocko
2016-05-31 13:08 ` [PATCH v2 15/18] mm, compaction: use proper alloc_flags in __compaction_suitable() Vlastimil Babka
2016-05-31 13:08 ` Vlastimil Babka
2016-05-31 13:08 ` [PATCH v2 16/18] mm, compaction: require only min watermarks for non-costly orders Vlastimil Babka
2016-05-31 13:08 ` Vlastimil Babka
2016-06-01 14:08 ` Michal Hocko
2016-06-01 14:08 ` Michal Hocko
2016-05-31 13:08 ` [PATCH v2 17/18] mm, vmscan: make compaction_ready() more accurate and readable Vlastimil Babka
2016-05-31 13:08 ` Vlastimil Babka
2016-06-01 14:14 ` Michal Hocko
2016-06-01 14:14 ` Michal Hocko
2016-05-31 13:08 ` [PATCH v2 18/18] mm, vmscan: use proper classzone_idx in should_continue_reclaim() Vlastimil Babka
2016-05-31 13:08 ` Vlastimil Babka
2016-06-01 14:21 ` Michal Hocko
2016-06-01 14:21 ` Michal Hocko
2016-06-01 15:19 ` Vlastimil Babka
2016-06-01 15:19 ` Vlastimil Babka
2016-06-01 15:45 ` Michal Hocko [this message]
2016-06-01 15:45 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160601154546.GZ26601@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.