From: Guenter Roeck <linux@roeck-us.net>
To: fu.wei@linaro.org
Cc: wim@iguana.be, panand@redhat.com, linux-kernel@vger.kernel.org,
linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linaro-acpi@lists.linaro.org, timur@codeaurora.org,
dyoung@redhat.com, graeme.gregory@linaro.org,
al.stone@linaro.org, jcm@redhat.com,
Suravee.Suthikulpanit@amd.com
Subject: Re: [PATCH 3/3] sbsa_gwdt: Set WDOG_HW_RUNNING, when watchdog is already running.
Date: Wed, 1 Jun 2016 14:43:30 -0700 [thread overview]
Message-ID: <20160601214330.GC2841@roeck-us.net> (raw)
In-Reply-To: <1464674890-10512-4-git-send-email-fu.wei@linaro.org>
On Tue, May 31, 2016 at 02:08:10PM +0800, fu.wei@linaro.org wrote:
> From: Pratyush Anand <panand@redhat.com>
>
> This patch uses the new flag WDOG_HW_RUNNING in driver.
> According to the definition of this flag, it should be set,
> if watchdog is running after booting, before it's opened.
>
> Signed-off-by: Pratyush Anand <panand@redhat.com>
> Signed-off-by: Fu Wei <fu.wei@linaro.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/sbsa_gwdt.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/watchdog/sbsa_gwdt.c b/drivers/watchdog/sbsa_gwdt.c
> index 6af71e0..cc885f1 100644
> --- a/drivers/watchdog/sbsa_gwdt.c
> +++ b/drivers/watchdog/sbsa_gwdt.c
> @@ -283,6 +283,8 @@ static int sbsa_gwdt_probe(struct platform_device *pdev)
> dev_warn(dev, "System reset by WDT.\n");
> wdd->bootstatus |= WDIOF_CARDRESET;
> }
> + if (status & SBSA_GWDT_WCS_EN)
> + set_bit(WDOG_HW_RUNNING, &wdd->status);
>
> if (action) {
> irq = platform_get_irq(pdev, 0);
> --
> 2.5.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: linux@roeck-us.net (Guenter Roeck)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] sbsa_gwdt: Set WDOG_HW_RUNNING, when watchdog is already running.
Date: Wed, 1 Jun 2016 14:43:30 -0700 [thread overview]
Message-ID: <20160601214330.GC2841@roeck-us.net> (raw)
In-Reply-To: <1464674890-10512-4-git-send-email-fu.wei@linaro.org>
On Tue, May 31, 2016 at 02:08:10PM +0800, fu.wei at linaro.org wrote:
> From: Pratyush Anand <panand@redhat.com>
>
> This patch uses the new flag WDOG_HW_RUNNING in driver.
> According to the definition of this flag, it should be set,
> if watchdog is running after booting, before it's opened.
>
> Signed-off-by: Pratyush Anand <panand@redhat.com>
> Signed-off-by: Fu Wei <fu.wei@linaro.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/sbsa_gwdt.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/watchdog/sbsa_gwdt.c b/drivers/watchdog/sbsa_gwdt.c
> index 6af71e0..cc885f1 100644
> --- a/drivers/watchdog/sbsa_gwdt.c
> +++ b/drivers/watchdog/sbsa_gwdt.c
> @@ -283,6 +283,8 @@ static int sbsa_gwdt_probe(struct platform_device *pdev)
> dev_warn(dev, "System reset by WDT.\n");
> wdd->bootstatus |= WDIOF_CARDRESET;
> }
> + if (status & SBSA_GWDT_WCS_EN)
> + set_bit(WDOG_HW_RUNNING, &wdd->status);
>
> if (action) {
> irq = platform_get_irq(pdev, 0);
> --
> 2.5.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-06-01 21:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 6:08 [PATCH 0/3] watchdog, sbsa_gwdt: Update SBSA watchdog with the new infrastructure of watchdog fu.wei
2016-05-31 6:08 ` fu.wei at linaro.org
2016-05-31 6:08 ` [PATCH 1/3] watchdog: skip min and max timeout validity check when max_hw_heartbeat_ms is defined fu.wei
2016-05-31 6:08 ` fu.wei at linaro.org
2016-06-01 21:40 ` Guenter Roeck
2016-06-01 21:40 ` Guenter Roeck
2016-05-31 6:08 ` [PATCH 2/3] sbsa_gwdt: Use max_hw_heartbeat_ms instead of max_timeout fu.wei
2016-05-31 6:08 ` fu.wei at linaro.org
2016-06-01 21:43 ` Guenter Roeck
2016-06-01 21:43 ` Guenter Roeck
2016-05-31 6:08 ` [PATCH 3/3] sbsa_gwdt: Set WDOG_HW_RUNNING, when watchdog is already running fu.wei
2016-05-31 6:08 ` fu.wei at linaro.org
2016-06-01 21:43 ` Guenter Roeck [this message]
2016-06-01 21:43 ` Guenter Roeck
2016-07-17 19:51 ` [PATCH 0/3] watchdog, sbsa_gwdt: Update SBSA watchdog with the new infrastructure of watchdog Wim Van Sebroeck
2016-07-18 15:21 ` Fu Wei
2016-07-18 15:21 ` Fu Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160601214330.GC2841@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Suravee.Suthikulpanit@amd.com \
--cc=al.stone@linaro.org \
--cc=dyoung@redhat.com \
--cc=fu.wei@linaro.org \
--cc=graeme.gregory@linaro.org \
--cc=jcm@redhat.com \
--cc=linaro-acpi@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=panand@redhat.com \
--cc=timur@codeaurora.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.