[PATCH] sunrpc: remove 'inuse' flag from struct cache_detail.

[PATCH] sunrpc: remove 'inuse' flag from struct cache_detail.

[NeilBrown]

[-- Attachment #1: Type: text/plain, Size: 1217 bytes --]


This field is not currently in use.

Signed-off-by: NeilBrown <neilb@suse.com>
---

I recently noticed this and wondered what it was for. "Nothing" seems to
be the answer..

NeilBrown


 include/linux/sunrpc/cache.h | 2 --
 net/sunrpc/cache.c           | 2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/include/linux/sunrpc/cache.h b/include/linux/sunrpc/cache.h
index ed03c9f7f908..62a60eeacb0a 100644
--- a/include/linux/sunrpc/cache.h
+++ b/include/linux/sunrpc/cache.h
@@ -78,8 +78,6 @@ struct cache_detail {
 	struct hlist_head *	hash_table;
 	rwlock_t		hash_lock;
 
-	atomic_t		inuse; /* active user-space update or lookup */
-
 	char			*name;
 	void			(*cache_put)(struct kref *);
 
diff --git a/net/sunrpc/cache.c b/net/sunrpc/cache.c
index 553bf95f7003..4d8e11f94a35 100644
--- a/net/sunrpc/cache.c
+++ b/net/sunrpc/cache.c
@@ -362,7 +362,7 @@ void sunrpc_destroy_cache_detail(struct cache_detail *cd)
 	cache_purge(cd);
 	spin_lock(&cache_list_lock);
 	write_lock(&cd->hash_lock);
-	if (cd->entries || atomic_read(&cd->inuse)) {
+	if (cd->entries) {
 		write_unlock(&cd->hash_lock);
 		spin_unlock(&cache_list_lock);
 		goto out;
-- 
2.8.3


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

Re: [PATCH] sunrpc: remove 'inuse' flag from struct cache_detail.

[J. Bruce Fields]

On Thu, Jun 02, 2016 at 04:31:03PM +1000, NeilBrown wrote:
> 
> This field is not currently in use.

Hah.  OK, thanks.--b.

> 
> Signed-off-by: NeilBrown <neilb@suse.com>
> ---
> 
> I recently noticed this and wondered what it was for. "Nothing" seems to
> be the answer..
> 
> NeilBrown
> 
> 
>  include/linux/sunrpc/cache.h | 2 --
>  net/sunrpc/cache.c           | 2 +-
>  2 files changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/include/linux/sunrpc/cache.h b/include/linux/sunrpc/cache.h
> index ed03c9f7f908..62a60eeacb0a 100644
> --- a/include/linux/sunrpc/cache.h
> +++ b/include/linux/sunrpc/cache.h
> @@ -78,8 +78,6 @@ struct cache_detail {
>  	struct hlist_head *	hash_table;
>  	rwlock_t		hash_lock;
>  
> -	atomic_t		inuse; /* active user-space update or lookup */
> -
>  	char			*name;
>  	void			(*cache_put)(struct kref *);
>  
> diff --git a/net/sunrpc/cache.c b/net/sunrpc/cache.c
> index 553bf95f7003..4d8e11f94a35 100644
> --- a/net/sunrpc/cache.c
> +++ b/net/sunrpc/cache.c
> @@ -362,7 +362,7 @@ void sunrpc_destroy_cache_detail(struct cache_detail *cd)
>  	cache_purge(cd);
>  	spin_lock(&cache_list_lock);
>  	write_lock(&cd->hash_lock);
> -	if (cd->entries || atomic_read(&cd->inuse)) {
> +	if (cd->entries) {
>  		write_unlock(&cd->hash_lock);
>  		spin_unlock(&cache_list_lock);
>  		goto out;
> -- 
> 2.8.3
>