From: Peter Griffin <peter.griffin@linaro.org> To: Arnaud Pouliquen <arnaud.pouliquen@st.com> Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, srinivas.kandagatla@gmail.com, maxime.coquelin@st.com, patrice.chotard@st.com, vinod.koul@intel.com, ohad@wizery.com, bjorn.andersson@linaro.org, arnd@arndb.de, lee.jones@linaro.org, devicetree@vger.kernel.org, dmaengine@vger.kernel.org, linux-remoteproc@vger.kernel.org Subject: Re: [PATCH v4 16/18] ARM: STi: DT: STiH407: Add uniperif player dt nodes Date: Fri, 3 Jun 2016 13:56:42 +0100 [thread overview] Message-ID: <20160603125642.GD9912@griffinp-ThinkPad-X1-Carbon-2nd> (raw) In-Reply-To: <574D5608.3080800@st.com> Hi Arnaud, Thanks for reviewing. On Tue, 31 May 2016, Arnaud Pouliquen wrote: > > > On 05/25/2016 06:06 PM, Peter Griffin wrote: > > This patch adds the DT nodes for the uniperif player > > IP blocks found on STiH407 family silicon. > > > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > > --- > > arch/arm/boot/dts/stih407-family.dtsi | 76 +++++++++++++++++++++++++++++++++++ > > 1 file changed, 76 insertions(+) > > > > diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi > > index 60f95b6..7ca149b 100644 > > --- a/arch/arm/boot/dts/stih407-family.dtsi > > +++ b/arch/arm/boot/dts/stih407-family.dtsi > > @@ -755,5 +755,81 @@ > > pinctrl-names = "default"; > > pinctrl-0 = <&pinctrl_spdif_out >; > > }; > > + > > + sti_uni_player0: sti-uni-player@0 { > > + compatible = "st,sti-uni-player"; > > + status = "disabled"; > > + #sound-dai-cells = <0>; > > + st,syscfg = <&syscfg_core>; > > + clocks = <&clk_s_d0_flexgen CLK_PCM_0>; > > + assigned-clocks = <&clk_s_d0_flexgen CLK_PCM_0>; > > + assigned-clock-parents = <&clk_s_d0_quadfs 0>; > This does not work properly. You need to declare parent like this: > assigned-clocks = <&clk_s_d0_quadfs 0>, <&clk_s_d0_flexgen CLK_PCM_0>; > assigned-clock-parents = <0>, <&clk_s_d0_quadfs 0>; Will fix in v5 > > > + assigned-clock-rates = <50000000>; > > + reg = <0x8D80000 0x158>; > > + interrupts = <GIC_SPI 84 IRQ_TYPE_NONE>; > > + dmas = <&fdma0 2 0 1>; > > + dai-name = "Uni Player #0 (HDMI)"; > > + dma-names = "tx"; > > + st,uniperiph-id = <0>; > > + st,version = <5>; > > + st,mode = "HDMI"; > > + }; > > + > > + sti_uni_player1: sti-uni-player@1 { > > + compatible = "st,sti-uni-player"; > > + status = "disabled"; > > + #sound-dai-cells = <0>; > > + st,syscfg = <&syscfg_core>; > > + clocks = <&clk_s_d0_flexgen CLK_PCM_1>; > > + assigned-clocks = <&clk_s_d0_flexgen CLK_PCM_1>; > > + assigned-clock-parents = <&clk_s_d0_quadfs 1>; > assigned-clocks = <&clk_s_d0_quadfs 1>, <&clk_s_d0_flexgen CLK_PCM_1>; > assigned-clock-parents = <0>, <&clk_s_d0_quadfs 1>; Will fix in v5 > > > + assigned-clock-rates = <50000000>; > > + reg = <0x8D81000 0x158>; > > + interrupts = <GIC_SPI 85 IRQ_TYPE_NONE>; > > + dmas = <&fdma0 3 0 1>; > > + dai-name = "Uni Player #1 (PIO)"; > > + dma-names = "tx"; > > + st,uniperiph-id = <1>; > > + st,version = <5>; > > + st,mode = "PCM"; > > + }; > > + > > + sti_uni_player2: sti-uni-player@2 { > > + compatible = "st,sti-uni-player"; > > + status = "disabled"; > > + #sound-dai-cells = <0>; > > + st,syscfg = <&syscfg_core>; > > + clocks = <&clk_s_d0_flexgen CLK_PCM_2>; > > + assigned-clocks = <&clk_s_d0_flexgen CLK_PCM_2>; > > + assigned-clock-parents = <&clk_s_d0_quadfs 2>; > assigned-clocks = <&clk_s_d0_quadfs 2>, <&clk_s_d0_flexgen CLK_PCM_2>; > assigned-clock-parents = <0>, <&clk_s_d0_quadfs 2>; Will fix in v5 > > + assigned-clock-rates = <50000000>; > > + reg = <0x8D82000 0x158>; > > + interrupts = <GIC_SPI 86 IRQ_TYPE_NONE>; > > + dmas = <&fdma0 4 0 1>; > > + dai-name = "Uni Player #1 (DAC)"; > > + dma-names = "tx"; > > + st,uniperiph-id = <2>; > > + st,version = <5>; > > + st,mode = "PCM"; > > + }; > > + > > + sti_uni_player3: sti-uni-player@3 { > > + compatible = "st,sti-uni-player"; > > + status = "disabled"; > > + #sound-dai-cells = <0>; > > + st,syscfg = <&syscfg_core>; > > + clocks = <&clk_s_d0_flexgen CLK_SPDIFF>; > > + assigned-clocks = <&clk_s_d0_flexgen CLK_SPDIFF>; > > + assigned-clock-parents = <&clk_s_d0_quadfs 3>; > > + assigned-clock-rates = <50000000>; > assigned-clocks = <&clk_s_d0_quadfs 3>, <&clk_s_d0_flexgen CLK_SPDIFF>; > assigned-clock-parents = <0>, <&clk_s_d0_quadfs 3>; Will fix in v5 Regards, Peter.
WARNING: multiple messages have this Message-ID (diff)
From: peter.griffin@linaro.org (Peter Griffin) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 16/18] ARM: STi: DT: STiH407: Add uniperif player dt nodes Date: Fri, 3 Jun 2016 13:56:42 +0100 [thread overview] Message-ID: <20160603125642.GD9912@griffinp-ThinkPad-X1-Carbon-2nd> (raw) In-Reply-To: <574D5608.3080800@st.com> Hi Arnaud, Thanks for reviewing. On Tue, 31 May 2016, Arnaud Pouliquen wrote: > > > On 05/25/2016 06:06 PM, Peter Griffin wrote: > > This patch adds the DT nodes for the uniperif player > > IP blocks found on STiH407 family silicon. > > > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > > --- > > arch/arm/boot/dts/stih407-family.dtsi | 76 +++++++++++++++++++++++++++++++++++ > > 1 file changed, 76 insertions(+) > > > > diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi > > index 60f95b6..7ca149b 100644 > > --- a/arch/arm/boot/dts/stih407-family.dtsi > > +++ b/arch/arm/boot/dts/stih407-family.dtsi > > @@ -755,5 +755,81 @@ > > pinctrl-names = "default"; > > pinctrl-0 = <&pinctrl_spdif_out >; > > }; > > + > > + sti_uni_player0: sti-uni-player at 0 { > > + compatible = "st,sti-uni-player"; > > + status = "disabled"; > > + #sound-dai-cells = <0>; > > + st,syscfg = <&syscfg_core>; > > + clocks = <&clk_s_d0_flexgen CLK_PCM_0>; > > + assigned-clocks = <&clk_s_d0_flexgen CLK_PCM_0>; > > + assigned-clock-parents = <&clk_s_d0_quadfs 0>; > This does not work properly. You need to declare parent like this: > assigned-clocks = <&clk_s_d0_quadfs 0>, <&clk_s_d0_flexgen CLK_PCM_0>; > assigned-clock-parents = <0>, <&clk_s_d0_quadfs 0>; Will fix in v5 > > > + assigned-clock-rates = <50000000>; > > + reg = <0x8D80000 0x158>; > > + interrupts = <GIC_SPI 84 IRQ_TYPE_NONE>; > > + dmas = <&fdma0 2 0 1>; > > + dai-name = "Uni Player #0 (HDMI)"; > > + dma-names = "tx"; > > + st,uniperiph-id = <0>; > > + st,version = <5>; > > + st,mode = "HDMI"; > > + }; > > + > > + sti_uni_player1: sti-uni-player at 1 { > > + compatible = "st,sti-uni-player"; > > + status = "disabled"; > > + #sound-dai-cells = <0>; > > + st,syscfg = <&syscfg_core>; > > + clocks = <&clk_s_d0_flexgen CLK_PCM_1>; > > + assigned-clocks = <&clk_s_d0_flexgen CLK_PCM_1>; > > + assigned-clock-parents = <&clk_s_d0_quadfs 1>; > assigned-clocks = <&clk_s_d0_quadfs 1>, <&clk_s_d0_flexgen CLK_PCM_1>; > assigned-clock-parents = <0>, <&clk_s_d0_quadfs 1>; Will fix in v5 > > > + assigned-clock-rates = <50000000>; > > + reg = <0x8D81000 0x158>; > > + interrupts = <GIC_SPI 85 IRQ_TYPE_NONE>; > > + dmas = <&fdma0 3 0 1>; > > + dai-name = "Uni Player #1 (PIO)"; > > + dma-names = "tx"; > > + st,uniperiph-id = <1>; > > + st,version = <5>; > > + st,mode = "PCM"; > > + }; > > + > > + sti_uni_player2: sti-uni-player at 2 { > > + compatible = "st,sti-uni-player"; > > + status = "disabled"; > > + #sound-dai-cells = <0>; > > + st,syscfg = <&syscfg_core>; > > + clocks = <&clk_s_d0_flexgen CLK_PCM_2>; > > + assigned-clocks = <&clk_s_d0_flexgen CLK_PCM_2>; > > + assigned-clock-parents = <&clk_s_d0_quadfs 2>; > assigned-clocks = <&clk_s_d0_quadfs 2>, <&clk_s_d0_flexgen CLK_PCM_2>; > assigned-clock-parents = <0>, <&clk_s_d0_quadfs 2>; Will fix in v5 > > + assigned-clock-rates = <50000000>; > > + reg = <0x8D82000 0x158>; > > + interrupts = <GIC_SPI 86 IRQ_TYPE_NONE>; > > + dmas = <&fdma0 4 0 1>; > > + dai-name = "Uni Player #1 (DAC)"; > > + dma-names = "tx"; > > + st,uniperiph-id = <2>; > > + st,version = <5>; > > + st,mode = "PCM"; > > + }; > > + > > + sti_uni_player3: sti-uni-player at 3 { > > + compatible = "st,sti-uni-player"; > > + status = "disabled"; > > + #sound-dai-cells = <0>; > > + st,syscfg = <&syscfg_core>; > > + clocks = <&clk_s_d0_flexgen CLK_SPDIFF>; > > + assigned-clocks = <&clk_s_d0_flexgen CLK_SPDIFF>; > > + assigned-clock-parents = <&clk_s_d0_quadfs 3>; > > + assigned-clock-rates = <50000000>; > assigned-clocks = <&clk_s_d0_quadfs 3>, <&clk_s_d0_flexgen CLK_SPDIFF>; > assigned-clock-parents = <0>, <&clk_s_d0_quadfs 3>; Will fix in v5 Regards, Peter.
next prev parent reply other threads:[~2016-06-03 12:56 UTC|newest] Thread overview: 113+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-05-25 16:06 [PATCH 00/18] Add support for FDMA DMA controller and xp70 rproc found on STi chipsets Peter Griffin 2016-05-25 16:06 ` Peter Griffin 2016-05-25 16:06 ` [PATCH v4 " Peter Griffin 2016-05-25 16:06 ` Peter Griffin 2016-05-25 16:06 ` [PATCH v4 01/18] remoteproc: st_xp70_rproc: add a xp70 slimcore rproc driver Peter Griffin 2016-05-25 16:06 ` Peter Griffin 2016-05-25 16:06 ` Peter Griffin 2016-05-25 17:10 ` Bjorn Andersson 2016-05-25 17:10 ` Bjorn Andersson 2016-06-06 7:22 ` Peter Griffin 2016-06-06 7:22 ` Peter Griffin 2016-05-27 13:15 ` Patrice Chotard 2016-05-27 13:15 ` Patrice Chotard 2016-05-27 13:15 ` Patrice Chotard 2016-05-27 16:13 ` Peter Griffin 2016-05-27 16:13 ` Peter Griffin 2016-05-27 16:13 ` Peter Griffin 2016-05-25 16:06 ` [PATCH v4 02/18] ARM: multi_v7_defconfig: enable st xp70 " Peter Griffin 2016-05-25 16:06 ` Peter Griffin 2016-05-25 16:06 ` Peter Griffin 2016-05-25 16:06 ` [PATCH v4 03/18] MAINTAINERS: Add st xp70 rproc driver to STi section Peter Griffin 2016-05-25 16:06 ` Peter Griffin 2016-05-25 16:06 ` [PATCH v4 04/18] dmaengine: st_fdma: Add STMicroelectronics FDMA DT binding documentation Peter Griffin 2016-05-25 16:06 ` Peter Griffin 2016-05-25 16:06 ` Peter Griffin 2016-05-27 15:44 ` Rob Herring 2016-05-27 15:44 ` Rob Herring 2016-05-27 15:44 ` Rob Herring 2016-05-25 16:06 ` [PATCH v4 05/18] dmaengine: st_fdma: Add STMicroelectronics FDMA driver header file Peter Griffin 2016-05-25 16:06 ` Peter Griffin 2016-05-25 16:06 ` Peter Griffin 2016-06-06 4:36 ` Vinod Koul 2016-06-06 4:36 ` Vinod Koul 2016-06-06 17:40 ` Peter Griffin 2016-06-06 17:40 ` Peter Griffin 2016-05-25 16:06 ` [PATCH v4 06/18] dmaengine: st_fdma: Add STMicroelectronics FDMA engine driver support Peter Griffin 2016-05-25 16:06 ` Peter Griffin 2016-05-25 16:06 ` Peter Griffin 2016-05-25 17:27 ` Bjorn Andersson 2016-05-25 17:27 ` Bjorn Andersson 2016-06-06 4:54 ` Vinod Koul 2016-06-06 4:54 ` Vinod Koul 2016-06-06 4:54 ` Vinod Koul 2016-06-06 17:38 ` Peter Griffin 2016-06-06 17:38 ` Peter Griffin 2016-05-25 16:06 ` [PATCH v4 07/18] ARM: STi: DT: STiH407: Add FDMA driver dt nodes Peter Griffin 2016-05-25 16:06 ` Peter Griffin 2016-05-25 16:06 ` [PATCH v4 08/18] MAINTAINERS: Add FDMA driver files to STi section Peter Griffin 2016-05-25 16:06 ` Peter Griffin 2016-05-25 16:06 ` Peter Griffin 2016-05-25 16:06 ` [PATCH v4 09/18] ARM: multi_v7_defconfig: Enable STi FDMA driver Peter Griffin 2016-05-25 16:06 ` Peter Griffin 2016-05-25 16:06 ` Peter Griffin 2016-05-25 16:06 ` [PATCH v4 10/18] ASoC: sti: Update DT example to match the driver code Peter Griffin 2016-05-25 16:06 ` Peter Griffin 2016-05-25 16:06 ` Peter Griffin 2016-05-27 15:47 ` Rob Herring 2016-05-27 15:47 ` Rob Herring 2016-05-27 15:47 ` Rob Herring 2016-05-27 17:14 ` Mark Brown 2016-05-27 17:14 ` Mark Brown 2016-06-03 13:05 ` Peter Griffin 2016-06-03 13:05 ` Peter Griffin 2016-05-25 16:06 ` [PATCH v4 11/18] ARM: multi_v7_defconfig: Enable STi and simple-card drivers Peter Griffin 2016-05-25 16:06 ` Peter Griffin 2016-05-31 8:55 ` Arnaud Pouliquen 2016-05-31 8:55 ` Arnaud Pouliquen 2016-05-31 8:55 ` Arnaud Pouliquen 2016-06-03 12:39 ` Peter Griffin 2016-06-03 12:39 ` Peter Griffin 2016-06-03 12:39 ` Peter Griffin 2016-05-25 16:06 ` [PATCH v4 12/18] ARM: DT: STiH407: Add i2s_out pinctrl configuration Peter Griffin 2016-05-25 16:06 ` Peter Griffin 2016-05-25 16:06 ` [PATCH v4 13/18] ARM: DT: STiH407: Add i2s_in " Peter Griffin 2016-05-25 16:06 ` Peter Griffin 2016-05-25 16:06 ` [PATCH v4 14/18] ARM: DT: STiH407: Add spdif_out pinctrl config Peter Griffin 2016-05-25 16:06 ` Peter Griffin 2016-05-25 16:06 ` [PATCH v4 15/18] ARM: STi: DT: STiH407: Add sti-sasg-codec dt node Peter Griffin 2016-05-25 16:06 ` Peter Griffin 2016-05-31 9:05 ` Arnaud Pouliquen 2016-05-31 9:05 ` Arnaud Pouliquen 2016-05-31 9:05 ` Arnaud Pouliquen 2016-06-03 13:00 ` Peter Griffin 2016-06-03 13:00 ` Peter Griffin 2016-05-25 16:06 ` [PATCH v4 16/18] ARM: STi: DT: STiH407: Add uniperif player dt nodes Peter Griffin 2016-05-25 16:06 ` Peter Griffin 2016-05-25 16:06 ` Peter Griffin 2016-05-31 9:14 ` Arnaud Pouliquen 2016-05-31 9:14 ` Arnaud Pouliquen 2016-05-31 9:14 ` Arnaud Pouliquen 2016-05-31 9:14 ` Arnaud Pouliquen 2016-06-03 12:56 ` Peter Griffin [this message] 2016-06-03 12:56 ` Peter Griffin 2016-05-25 16:06 ` [PATCH v4 17/18] ARM: STi: DT: STiH407: Add uniperif reader " Peter Griffin 2016-05-25 16:06 ` Peter Griffin 2016-05-31 9:18 ` Arnaud Pouliquen 2016-05-31 9:18 ` Arnaud Pouliquen 2016-05-31 9:18 ` Arnaud Pouliquen 2016-06-03 12:50 ` Peter Griffin 2016-06-03 12:50 ` Peter Griffin 2016-06-03 12:50 ` Peter Griffin 2016-05-25 16:06 ` [PATCH v4 18/18] ARM: DT: STi: stihxxx-b2120: Add DT nodes for STi audio card Peter Griffin 2016-05-25 16:06 ` Peter Griffin 2016-05-31 10:16 ` Arnaud Pouliquen 2016-05-31 10:16 ` Arnaud Pouliquen 2016-05-31 10:16 ` Arnaud Pouliquen 2016-06-03 12:47 ` Peter Griffin 2016-06-03 12:47 ` Peter Griffin 2016-06-06 5:01 ` [PATCH 00/18] Add support for FDMA DMA controller and xp70 rproc found on STi chipsets Vinod Koul 2016-06-06 5:01 ` Vinod Koul 2016-06-06 5:01 ` Vinod Koul 2016-06-06 15:09 ` Peter Griffin 2016-06-06 15:09 ` Peter Griffin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160603125642.GD9912@griffinp-ThinkPad-X1-Carbon-2nd \ --to=peter.griffin@linaro.org \ --cc=arnaud.pouliquen@st.com \ --cc=arnd@arndb.de \ --cc=bjorn.andersson@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=dmaengine@vger.kernel.org \ --cc=lee.jones@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-remoteproc@vger.kernel.org \ --cc=maxime.coquelin@st.com \ --cc=ohad@wizery.com \ --cc=patrice.chotard@st.com \ --cc=srinivas.kandagatla@gmail.com \ --cc=vinod.koul@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.