All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Horak <thement@ibawizard.net>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] Bug in ppc/BookE wait instruction
Date: Fri, 3 Jun 2016 17:45:49 +0200	[thread overview]
Message-ID: <20160603154549.GA31406@ibawizard> (raw)

Hello,
I think there's a bug in "wait" instruction code generator for PowerPC
architecture. It doesn't make sense to store a non-initialized register.

Best regards,
Jakub Horak


diff --git a/target-ppc/translate.c b/target-ppc/translate.c
index f5ceae5..6af567b 100644
--- a/target-ppc/translate.c
+++ b/target-ppc/translate.c
@@ -3439,7 +3439,7 @@ static void gen_sync(DisasContext *ctx)
 /* wait */
 static void gen_wait(DisasContext *ctx)
 {
-    TCGv_i32 t0 = tcg_temp_new_i32();
+    TCGv_i32 t0 = tcg_const_i32(1);
     tcg_gen_st_i32(t0, cpu_env,
                    -offsetof(PowerPCCPU, env) + offsetof(CPUState, halted));
     tcg_temp_free_i32(t0);

             reply	other threads:[~2016-06-03 15:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-03 15:45 Jakub Horak [this message]
2016-06-03 17:11 ` [Qemu-devel] Bug in ppc/BookE wait instruction Mark Cave-Ayland
2016-06-06  1:34 ` David Gibson
2016-06-06  8:47   ` Jakub Horak
2016-06-15  4:06     ` [Qemu-devel] [Qemu-ppc] " David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160603154549.GA31406@ibawizard \
    --to=thement@ibawizard.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.