All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Mario Limonciello <mario_limonciello@dell.com>
Cc: hayeswang@realtek.com, LKML <linux-kernel@vger.kernel.org>,
	Netdev <netdev@vger.kernel.org>,
	Linux USB <linux-usb@vger.kernel.org>,
	pali.rohar@gmail.com, anthony.wong@canonical.com,
	Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD
Date: Mon, 6 Jun 2016 16:40:36 +0200	[thread overview]
Message-ID: <20160606144036.GA30948@lunn.ch> (raw)
In-Reply-To: <1465222521-7217-2-git-send-email-mario_limonciello@dell.com>

> +	/* returns _AUXMAC_#AABBCCDDEEFF# */
> +	status = acpi_evaluate_object(NULL, "\\_SB.AMAC", NULL, &buffer);
> +	obj = (union acpi_object *)buffer.pointer;
> +	if (ACPI_SUCCESS(status)) {
> +		if (obj->type != ACPI_TYPE_BUFFER ||
> +		    obj->string.length != 0x17) {
> +			pr_warn("r8152: get_passthru_addr: Invalid buffer");

Please don't use pr_warn() when you can use the better alternatives
like dev_warn().

     Andrew

  parent reply	other threads:[~2016-06-06 14:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-06 14:15 [PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD Mario Limonciello
2016-06-06 14:15 ` Mario Limonciello
2016-06-06 14:39   ` Greg KH
2016-06-06 14:56     ` Mario_Limonciello
2016-06-06 16:12       ` Greg KH
2016-06-06 17:24         ` Mario_Limonciello
2016-06-06 17:38           ` Greg KH
2016-06-06 14:40   ` Andrew Lunn [this message]
2016-06-06 14:57     ` Mario_Limonciello
2016-06-06 14:40 ` Greg KH
2016-06-06 14:43   ` Mario_Limonciello
2016-06-06 14:50     ` Greg KH
2016-06-06 14:51       ` Mario_Limonciello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160606144036.GA30948@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=anthony.wong@canonical.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hayeswang@realtek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mario_limonciello@dell.com \
    --cc=netdev@vger.kernel.org \
    --cc=pali.rohar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.