All of lore.kernel.org
 help / color / mirror / Atom feed
From: <Mario_Limonciello@Dell.com>
To: <gregkh@linuxfoundation.org>
Cc: <hayeswang@realtek.com>, <linux-kernel@vger.kernel.org>,
	<netdev@vger.kernel.org>, <linux-usb@vger.kernel.org>,
	<pali.rohar@gmail.com>, <anthony.wong@canonical.com>
Subject: RE: [PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD
Date: Mon, 6 Jun 2016 17:24:57 +0000	[thread overview]
Message-ID: <e1fd0ce1589743acbd1342ec38ff8071@ausx13mpc124.AMER.DELL.COM> (raw)
In-Reply-To: <20160606161222.GA12114@kroah.com>

> > Realtek has this in their Windows driver that all OEM's will be taking.
> > Another OEM would just need to burn the right information into the SPI at
> > manufacturing and expose it to the DSDT.
> 
> Where it the match up for the Realtek bit to corrispond with this
> specific ACPI field?  If it's not in the ACPI spec, then vendors _WILL_
> do this in different ways.
> 
> Again, document it, in the code, what is going on here, that's all I'm
> asking.  I'm not asking you to change the logic at all!

I've added additional comments for v4.  I strongly believe that even if
another vendor does do this differently for their implementation of
\\_SB.AMAC this code will be safe to run.

All of the output from the field are tested for exactly what the field
should look like.

That said, I would be highly surprised if Realtek decided to implement
with another OEM differently.  It would increase their code complexity
on Windows as well since this is part of the generic driver.

  reply	other threads:[~2016-06-06 17:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-06 14:15 [PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD Mario Limonciello
2016-06-06 14:15 ` Mario Limonciello
2016-06-06 14:39   ` Greg KH
2016-06-06 14:56     ` Mario_Limonciello
2016-06-06 16:12       ` Greg KH
2016-06-06 17:24         ` Mario_Limonciello [this message]
2016-06-06 17:38           ` Greg KH
2016-06-06 14:40   ` Andrew Lunn
2016-06-06 14:57     ` Mario_Limonciello
2016-06-06 14:40 ` Greg KH
2016-06-06 14:43   ` Mario_Limonciello
2016-06-06 14:50     ` Greg KH
2016-06-06 14:51       ` Mario_Limonciello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e1fd0ce1589743acbd1342ec38ff8071@ausx13mpc124.AMER.DELL.COM \
    --to=mario_limonciello@dell.com \
    --cc=anthony.wong@canonical.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hayeswang@realtek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pali.rohar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.