All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 7/7] fs/squashfs: remove useless chmod
Date: Mon, 6 Jun 2016 23:06:15 +0200	[thread overview]
Message-ID: <20160606230615.2772541c@free-electrons.com> (raw)
In-Reply-To: <d4b5c7f0315f28e792a014983c78b1fe4958eb9f.1465245732.git.yann.morin.1998@free.fr>

Hello,

On Mon,  6 Jun 2016 22:43:44 +0200, Yann E. MORIN wrote:
> When that was added (in 975e30b, fs/squashfs: fix image file

There is no such commit as 975e30b:

~/projets/buildroot (master)$ git show 975e30b
fatal: ambiguous argument '975e30b': unknown revision or path not in
the working tree. Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

> permissions), the reasons were not quite explicit.

I very well remember that mksquashfs had the very annoying default
behavior of making its output file 0444. Like because it was a
read-only filesystem, the images should also be read-only, which is
obviously a bit silly.

Maybe mksquashfs has changed its default behavior since then, but
clearly that's the reason why we were doing this.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2016-06-06 21:06 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-06 20:43 [Buildroot] [PATCH 0/7] fs: cleanups (branch yem/fs-fixes) Yann E. MORIN
2016-06-06 20:43 ` [Buildroot] [PATCH 1/7] core/pkg-utils: add macro to escape-and-printf Yann E. MORIN
2016-06-06 21:07   ` Thomas Petazzoni
2016-06-06 21:25     ` Yann E. MORIN
2016-06-06 22:54       ` Arnout Vandecappelle
2016-06-06 20:43 ` [Buildroot] [PATCH 2/7] fs: properly escape commands when generating fakeroot script Yann E. MORIN
2016-06-06 20:43 ` [Buildroot] [PATCH 3/7] fs/cloop: split long line Yann E. MORIN
2016-06-06 21:19   ` Thomas Petazzoni
2016-06-06 20:43 ` [Buildroot] [PATCH 4/7] fs/jffs2: split commands Yann E. MORIN
2016-06-06 20:43 ` [Buildroot] [PATCH 5/7] fs/squashfs: " Yann E. MORIN
2016-06-06 20:43 ` [Buildroot] [PATCH 6/7] fs/ubifs: fix the UBI commands Yann E. MORIN
2016-06-06 20:43 ` [Buildroot] [PATCH 7/7] fs/squashfs: remove useless chmod Yann E. MORIN
2016-06-06 21:01   ` Peter Korsgaard
2016-06-06 21:28     ` Yann E. MORIN
2016-06-06 21:06   ` Thomas Petazzoni [this message]
2016-06-06 21:16     ` Yann E. MORIN
2016-06-07 12:51       ` Peter Korsgaard
2016-06-07 19:12         ` Yann E. MORIN
2016-06-07 20:27 ` [Buildroot] [PATCH 0/7] fs: cleanups (branch yem/fs-fixes) Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160606230615.2772541c@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.