From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/7] core/pkg-utils: add macro to escape-and-printf
Date: Tue, 7 Jun 2016 00:54:05 +0200 [thread overview]
Message-ID: <c08ceca8-cbbb-8103-442c-6ddf57a6d9cc@mind.be> (raw)
In-Reply-To: <20160606212555.GB3706@free.fr>
On 06-06-16 23:25, Yann E. MORIN wrote:
> Thomas, All,
>
> On 2016-06-06 23:07 +0200, Thomas Petazzoni spake thusly:
>> On Mon, 6 Jun 2016 22:43:38 +0200, Yann E. MORIN wrote:
>>
>>> +define PRINTF
>>> + printf '$(subst $(sep),\n,\
>>> + $(subst $(PERCENT),$(PERCENT)$(PERCENT),\
>>> + $(subst $(QUOTE),$(QUOTE)\$(QUOTE)$(QUOTE),\
>>> + $(subst \,\\,$(1)))))\n'
>>> +endef
>>
>> Do we expect this to be used outside of fs/common.mk? Since it's not
>> the case today, I would suggest to move it there.
>
> Indeed I don;t plan on using it outside of the fs infra for now (I have
> another series that will rely on it, but still in the fs infra).
>
> However, this is generic enough that it is not specific to the fs infra.
> Thus I believe it belong to pkg-utils.
>
> If you still prefer I move it to fs/common.mk, that's also OK for me.
I think pkg-utils is the proper place. I imagine that there can be many other
places where this can be useful. And even if it is only used in the fs infra, I
would go and look for a function like that in pkg-utils.mk.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
next prev parent reply other threads:[~2016-06-06 22:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 20:43 [Buildroot] [PATCH 0/7] fs: cleanups (branch yem/fs-fixes) Yann E. MORIN
2016-06-06 20:43 ` [Buildroot] [PATCH 1/7] core/pkg-utils: add macro to escape-and-printf Yann E. MORIN
2016-06-06 21:07 ` Thomas Petazzoni
2016-06-06 21:25 ` Yann E. MORIN
2016-06-06 22:54 ` Arnout Vandecappelle [this message]
2016-06-06 20:43 ` [Buildroot] [PATCH 2/7] fs: properly escape commands when generating fakeroot script Yann E. MORIN
2016-06-06 20:43 ` [Buildroot] [PATCH 3/7] fs/cloop: split long line Yann E. MORIN
2016-06-06 21:19 ` Thomas Petazzoni
2016-06-06 20:43 ` [Buildroot] [PATCH 4/7] fs/jffs2: split commands Yann E. MORIN
2016-06-06 20:43 ` [Buildroot] [PATCH 5/7] fs/squashfs: " Yann E. MORIN
2016-06-06 20:43 ` [Buildroot] [PATCH 6/7] fs/ubifs: fix the UBI commands Yann E. MORIN
2016-06-06 20:43 ` [Buildroot] [PATCH 7/7] fs/squashfs: remove useless chmod Yann E. MORIN
2016-06-06 21:01 ` Peter Korsgaard
2016-06-06 21:28 ` Yann E. MORIN
2016-06-06 21:06 ` Thomas Petazzoni
2016-06-06 21:16 ` Yann E. MORIN
2016-06-07 12:51 ` Peter Korsgaard
2016-06-07 19:12 ` Yann E. MORIN
2016-06-07 20:27 ` [Buildroot] [PATCH 0/7] fs: cleanups (branch yem/fs-fixes) Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c08ceca8-cbbb-8103-442c-6ddf57a6d9cc@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.