All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] Make FIT support really optional
Date: Tue, 7 Jun 2016 22:37:46 +0200	[thread overview]
Message-ID: <20160607223746.09c998f6@free-electrons.com> (raw)
In-Reply-To: <345857401.1244821.1465061962032.JavaMail.zimbra@datacom.ind.br>

Carlos, Tom,

On Sat, 4 Jun 2016 14:39:22 -0300 (BRT), Carlos Santos wrote:

> > So, why?  I don't like the idea of making FIT support in mkimage
> > conditional.  
> 
> If FIT is not to be conditional then what's the purpose of the
> CONFIG_FIT_SIGNATURE configuration option? Looks like it exists
> exactly to make FIT support conditional, which seems to be a
> reasonable approach, since it helps to reduce the size of the boot
> loader.

CONFIG_FIT_SIGNATURE is I guess optional because it requires OpenSSL at
*build* time and the U-Boot developers don't want to force everyone to
have OpenSSL available to build U-Boot.

However, FIT support does not require any special build dependency, so
probably there's little interest from the U-Boot folks to make it
optional.

> > This makes the life of distribution people harder, not
> > easier.  The functions in common/bootm.c should be being discarded
> > in U-Boot itself when we don't have CONFIG_FIT_SIGNATURE.  Thanks!  
> 
> The patch exists because of "distribution people". I sent a patch to
> Buildroot[1] which was refused because it added dependencies on DTC
> and evolved to several follow-ups [2,3,4].

Right, *but* it is not because we make FIT support optional in
Buildroot that we have to make it optional in U-Boot.

We can perfectly have an option in Buildroot to enable/disable FIT
support which does *not* enable/disable FIT support in the U-Boot, but
only ensures that the relevant runtime dependencies (i.e DTC) are
enabled.

Of course, if the U-Boot developers want to make FIT support in the
bootloader itself an optional feature, why not, but it's clearly not a
requirement from our side.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2016-06-07 20:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-08 15:06 [U-Boot] [PATCH 4/4] Make FIT support really optional Carlos Santos
2016-06-03 19:16 ` [U-Boot] [PATCH v2] " Carlos Santos
2016-06-04 12:09   ` Otavio Salvador
2016-06-04 13:06   ` Tom Rini
2016-06-04 17:39     ` Carlos Santos
2016-06-06 11:42       ` Carlos Santos
2016-06-07 20:37       ` Thomas Petazzoni [this message]
2016-06-08  0:18         ` Carlos Santos
2016-06-08  5:47           ` Thomas Petazzoni
2016-06-08 12:17             ` Tom Rini
2016-06-10  1:09               ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160607223746.09c998f6@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.