All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] Make FIT support really optional
Date: Wed, 8 Jun 2016 08:17:44 -0400	[thread overview]
Message-ID: <20160608121744.GS11619@bill-the-cat> (raw)
In-Reply-To: <20160608074712.0ecdb027@free-electrons.com>

On Wed, Jun 08, 2016 at 07:47:12AM +0200, Thomas Petazzoni wrote:
> Hello,
> 
> On Tue, 7 Jun 2016 21:18:17 -0300 (BRT), Carlos Santos wrote:
> 
> > There is already a configuration that makes FIT optional (CONFIG_FIT)
> > but it is partially broken because it does not really remove
> > FIT-related functionality from mkimage. That's the reason why it was
> > not possible to disable FIT in the Buildroot package. My patch aims
> > to fix that defect.
> 
> Ah, indeed, I forgot that the CONFIG_FIT option already existed. In
> this case, I agree that it should either exist and work, or not exist.

Here is the problem with host tools living along side configurable
binaries and sharing code.  With respect to mkimage, FIT support is
non-optional.  The only reason that FIT signature stuff is optional is
that it introduces too high of a set of dependencies for everyone else
to have installed to even compile mkimage which is in turn required by
the vast majority of targets.  If the failing message that we couldn't
run dtc is not clear enoguh, I am happy to take a patch to make the
problem and solution clearer.

I would go so far as to say that requiring bison and m4 (along with dtc)
to already be compiled in buildroot is not a step too far, but I'm an
OpenEmbedded guy so it's possible I'm just dependency-happy :)  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160608/3d0d0167/attachment.sig>

  reply	other threads:[~2016-06-08 12:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-08 15:06 [U-Boot] [PATCH 4/4] Make FIT support really optional Carlos Santos
2016-06-03 19:16 ` [U-Boot] [PATCH v2] " Carlos Santos
2016-06-04 12:09   ` Otavio Salvador
2016-06-04 13:06   ` Tom Rini
2016-06-04 17:39     ` Carlos Santos
2016-06-06 11:42       ` Carlos Santos
2016-06-07 20:37       ` Thomas Petazzoni
2016-06-08  0:18         ` Carlos Santos
2016-06-08  5:47           ` Thomas Petazzoni
2016-06-08 12:17             ` Tom Rini [this message]
2016-06-10  1:09               ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160608121744.GS11619@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.