Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly outputs

From: Ingo Molnar <mingo@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "H. Peter Anvin" <hpa@linux.intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Andy Lutomirski <luto@amacapital.net>,
	Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly outputs
Date: Wed, 8 Jun 2016 10:28:36 +0200	[thread overview]
Message-ID: <20160608082835.GB9645@gmail.com> (raw)
In-Reply-To: <20160608074956.GO30154@twins.programming.kicks-ass.net>

* Peter Zijlstra <peterz@infradead.org> wrote:

> On Tue, Jun 07, 2016 at 04:31:01PM -0700, H. Peter Anvin wrote:
> > From: "H. Peter Anvin" <hpa@zytor.com>
> > 
> > The gcc people have confirmed that using "bool" when combined with
> > inline assembly always is treated as a byte-sized operand that can be
> > assumed to be 0 or 1, which is exactly what the SET instruction
> > emits.  Change the output types and intermediate variables of as many
> > operations as practical to "bool".
> > 
> > Signed-off-by: H. Peter Anvin <hpa@zytor.com>
> > ---
> >  arch/x86/boot/bitops.h             |  8 +++++---
> >  arch/x86/boot/boot.h               |  8 ++++----
> >  arch/x86/boot/string.c             |  2 +-
> >  arch/x86/include/asm/apm.h         |  6 +++---
> >  arch/x86/include/asm/archrandom.h  | 16 ++++++++--------
> >  arch/x86/include/asm/atomic.h      |  8 ++++----
> >  arch/x86/include/asm/atomic64_64.h | 10 +++++-----
> >  arch/x86/include/asm/bitops.h      | 28 ++++++++++++++--------------
> >  arch/x86/include/asm/local.h       |  8 ++++----
> >  arch/x86/include/asm/percpu.h      |  8 ++++----
> >  arch/x86/include/asm/rmwcc.h       |  4 ++--
> >  arch/x86/include/asm/rwsem.h       | 17 +++++++++--------
> >  include/linux/random.h             | 12 ++++++------
> >  13 files changed, 69 insertions(+), 66 deletions(-)
> 
> So the only concern I have with this is that the x86 function signatures
> are now different from the other architectures.
> 
> Not sure how much if anything that matters..

It does matter:

 In file included from arch/x86/kernel/cpu/common.c:21:0:
 ./arch/x86/include/asm/archrandom.h:95:20: error: redefinition of ‘arch_get_random_long’
 static inline bool arch_get_random_long(unsigned long *v)
 In file included from ./arch/x86/include/asm/stackprotector.h:43:0,
 include/linux/random.h:98:20: note: previous definition of ‘arch_get_random_long’ was here

Thanks,

	Ingo