All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
	"H. Peter Anvin" <hpa@linux.intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Andy Lutomirski <luto@amacapital.net>,
	Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH 02/10] x86, asm: use bool for bitops and other assembly outputs
Date: Wed, 8 Jun 2016 02:12:05 -0700	[thread overview]
Message-ID: <88387994-fbf1-83dd-d58d-343498776a11@zytor.com> (raw)
In-Reply-To: <20160608090111.GA11390@gmail.com>

On 06/08/16 02:01, Ingo Molnar wrote:
> 
> That's a divergence with an underlying reason - but not harmonizing the return 
> code is an unforced error AFAICS and can be fixed.
>

Perhaps.  It is also no real question that "bool" is the right return
type for a single bit.  Changing that in all architectures at one time
is a major undertaking, however, and it seems to me that it would be
better to leave that to the respective architecture maintainers.

Perhaps I'm wrong, but I'd really like to avoid the upcasting to "int"
which isn't needed, because in my testing I find that it definitely
encourages gcc to generate poor code.

	-hpa

  reply	other threads:[~2016-06-08  9:13 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-07 23:30 [PATCH 00/10] x86: use gcc 6+ asm flag output feature H. Peter Anvin
2016-06-07 23:31 ` [PATCH 01/10] x86, bitops: remove use of "sbb" to return CF H. Peter Anvin
2016-06-07 23:39   ` [tip:x86/asm] " tip-bot for H. Peter Anvin
2016-06-07 23:31 ` [PATCH 02/10] x86, asm: use bool for bitops and other assembly outputs H. Peter Anvin
2016-06-07 23:40   ` [tip:x86/asm] " tip-bot for H. Peter Anvin
2016-06-08  7:49   ` [PATCH 02/10] " Peter Zijlstra
2016-06-08  8:28     ` Ingo Molnar
2016-06-08  8:33       ` Ingo Molnar
2016-06-08  8:55         ` H. Peter Anvin
2016-06-08  9:01           ` Ingo Molnar
2016-06-08  9:12             ` H. Peter Anvin [this message]
2016-06-08  9:20               ` Ingo Molnar
2016-06-08  9:31                 ` H. Peter Anvin
2016-06-08  9:39                   ` Peter Zijlstra
2016-06-08  9:43                     ` H. Peter Anvin
2016-06-08  9:40                 ` H. Peter Anvin
2016-06-08  8:58       ` H. Peter Anvin
2016-06-08  9:06         ` Ingo Molnar
2016-06-07 23:31 ` [PATCH 03/10] x86, asm: change the GEN_*_RMWcc() macros to not quote the condition H. Peter Anvin
2016-06-07 23:40   ` [tip:x86/asm] " tip-bot for H. Peter Anvin
2016-06-07 23:31 ` [PATCH 04/10] x86, asm: define CC_SET() and CC_OUT() macros H. Peter Anvin
2016-06-07 23:40   ` [tip:x86/asm] " tip-bot for H. Peter Anvin
2016-06-08  5:09   ` [PATCH 04/10] " Andy Lutomirski
2016-06-08 19:29     ` H. Peter Anvin
2016-06-08 19:34       ` H. Peter Anvin
2016-06-08 19:35         ` Borislav Petkov
2016-06-07 23:31 ` [PATCH 05/10] x86, asm: change GEN_*_RMWcc() to use CC_SET()/CC_OUT() H. Peter Anvin
2016-06-07 23:41   ` [tip:x86/asm] " tip-bot for H. Peter Anvin
2016-06-07 23:31 ` [PATCH 06/10] x86, asm: Use CC_SET()/CC_OUT() in <asm/bitops.h> H. Peter Anvin
2016-06-07 23:41   ` [tip:x86/asm] " tip-bot for H. Peter Anvin
2016-06-07 23:31 ` [PATCH 07/10] x86, asm: Use CC_SET()/CC_OUT() in <asm/percpu.h> H. Peter Anvin
2016-06-07 23:42   ` [tip:x86/asm] " tip-bot for H. Peter Anvin
2016-06-07 23:31 ` [PATCH 08/10] x86, asm: Use CC_SET()/CC_OUT() in <asm/rwsem.h> H. Peter Anvin
2016-06-07 23:42   ` [tip:x86/asm] " tip-bot for H. Peter Anvin
2016-06-07 23:31 ` [PATCH 09/10] x86, asm: Use CC_SET()/CC_OUT() and static_cpu_has() in archrandom.h H. Peter Anvin
2016-06-07 23:42   ` [tip:x86/asm] " tip-bot for H. Peter Anvin
2016-06-08  5:12   ` [PATCH 09/10] " Andy Lutomirski
2016-06-07 23:31 ` [PATCH 10/10] x86, asm, boot: Use CC_SET()/CC_OUT() in arch/x86/boot/boot.h H. Peter Anvin
2016-06-07 23:43   ` [tip:x86/asm] " tip-bot for H. Peter Anvin
2016-06-08  8:00 ` [PATCH 00/10] x86: use gcc 6+ asm flag output feature Peter Zijlstra
2016-06-08  8:56   ` H. Peter Anvin
2016-06-08  8:26 ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=88387994-fbf1-83dd-d58d-343498776a11@zytor.com \
    --to=hpa@zytor.com \
    --cc=bp@alien8.de \
    --cc=hpa@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.