From: Rob Herring <robh@kernel.org>
To: Pramod Kumar <pramod.kumar@broadcom.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
"David S. Miller" <davem@davemloft.net>,
devicetree@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 3/7] binding: mdio-mux: Add DT binding doc for Broadcom MDIO bus multiplexer
Date: Wed, 8 Jun 2016 14:40:43 -0500 [thread overview]
Message-ID: <20160608194043.GA32093@rob-hp-laptop> (raw)
In-Reply-To: <f6cd5df22ef8ea070d7b35e628b6d25a@mail.gmail.com>
On Tue, Jun 07, 2016 at 05:27:29PM +0530, Pramod Kumar wrote:
> Hi Florian,
>
> > -----Original Message-----
> > From: Florian Fainelli [mailto:f.fainelli@gmail.com]
> > Sent: 07 June 2016 00:06
> > To: Pramod Kumar; Rob Herring; Pawel Moll; Mark Rutland; Ian Campbell;
> > Kumar Gala; Catalin Marinas; Will Deacon; Kishon Vijay Abraham I; David S.
> > Miller
> > Cc: devicetree@vger.kernel.org; netdev@vger.kernel.org; linux-
> > kernel@vger.kernel.org; bcm-kernel-feedback-list@broadcom.com; linux-arm-
> > kernel@lists.infradead.org
> > Subject: Re: [PATCH v4 3/7] binding: mdio-mux: Add DT binding doc for
> > Broadcom MDIO bus multiplexer
> >
> > On 06/06/2016 05:41 AM, Pramod Kumar wrote:
> > > Add DT binding doc for Broadcom MDIO bus multiplexer driver.
> > >
> > > Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> > > Signed-off-by: Pramod Kumar <pramod.kumar@broadcom.com>
> >
> > Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> >
> >
> > > +for example:
> > > + mdio_mux_iproc: mdio-mux@6602023c {
> >
> > I think Rob wanted you to drop the underscores here in favor of dashes,
> > there
> > are more below, not critical imho.
> >
>
> I'd changed node name in favor of dashes. I don't think Label could be
> written with hyphens,"-". "-" in label provides DT parsing error.
Right. Labels don't matter as they aren't part of the binding.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: robh@kernel.org (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 3/7] binding: mdio-mux: Add DT binding doc for Broadcom MDIO bus multiplexer
Date: Wed, 8 Jun 2016 14:40:43 -0500 [thread overview]
Message-ID: <20160608194043.GA32093@rob-hp-laptop> (raw)
In-Reply-To: <f6cd5df22ef8ea070d7b35e628b6d25a@mail.gmail.com>
On Tue, Jun 07, 2016 at 05:27:29PM +0530, Pramod Kumar wrote:
> Hi Florian,
>
> > -----Original Message-----
> > From: Florian Fainelli [mailto:f.fainelli at gmail.com]
> > Sent: 07 June 2016 00:06
> > To: Pramod Kumar; Rob Herring; Pawel Moll; Mark Rutland; Ian Campbell;
> > Kumar Gala; Catalin Marinas; Will Deacon; Kishon Vijay Abraham I; David S.
> > Miller
> > Cc: devicetree at vger.kernel.org; netdev at vger.kernel.org; linux-
> > kernel at vger.kernel.org; bcm-kernel-feedback-list at broadcom.com; linux-arm-
> > kernel at lists.infradead.org
> > Subject: Re: [PATCH v4 3/7] binding: mdio-mux: Add DT binding doc for
> > Broadcom MDIO bus multiplexer
> >
> > On 06/06/2016 05:41 AM, Pramod Kumar wrote:
> > > Add DT binding doc for Broadcom MDIO bus multiplexer driver.
> > >
> > > Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> > > Signed-off-by: Pramod Kumar <pramod.kumar@broadcom.com>
> >
> > Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> >
> >
> > > +for example:
> > > + mdio_mux_iproc: mdio-mux at 6602023c {
> >
> > I think Rob wanted you to drop the underscores here in favor of dashes,
> > there
> > are more below, not critical imho.
> >
>
> I'd changed node name in favor of dashes. I don't think Label could be
> written with hyphens,"-". "-" in label provides DT parsing error.
Right. Labels don't matter as they aren't part of the binding.
Rob
next prev parent reply other threads:[~2016-06-08 19:40 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 12:41 [PATCH v4 0/7] Add MDIO bus multiplexer support for iProc SoCs Pramod Kumar
2016-06-06 12:41 ` Pramod Kumar
2016-06-06 12:41 ` [PATCH v4 1/7] mdio: mux: Enhanced MDIO mux framework for integrated multiplexers Pramod Kumar
2016-06-06 12:41 ` Pramod Kumar
2016-06-06 14:17 ` Andrew Lunn
2016-06-06 14:17 ` Andrew Lunn
2016-06-06 18:33 ` Florian Fainelli
2016-06-06 18:33 ` Florian Fainelli
2016-06-06 12:41 ` [PATCH v4 2/7] binding: Make "mdio-parent-bus" property from mandatory to optional Pramod Kumar
2016-06-06 12:41 ` Pramod Kumar
2016-06-06 14:17 ` Andrew Lunn
2016-06-06 14:17 ` Andrew Lunn
2016-06-08 19:39 ` Rob Herring
2016-06-08 19:39 ` Rob Herring
2016-06-06 12:41 ` [PATCH v4 3/7] binding: mdio-mux: Add DT binding doc for Broadcom MDIO bus multiplexer Pramod Kumar
2016-06-06 12:41 ` Pramod Kumar
2016-06-06 18:36 ` Florian Fainelli
2016-06-06 18:36 ` Florian Fainelli
2016-06-07 11:57 ` Pramod Kumar
2016-06-07 11:57 ` Pramod Kumar
2016-06-07 11:57 ` Pramod Kumar
2016-06-08 19:40 ` Rob Herring [this message]
2016-06-08 19:40 ` Rob Herring
2016-06-08 19:43 ` Rob Herring
2016-06-08 19:43 ` Rob Herring
2016-06-08 19:43 ` Rob Herring
2016-06-06 12:41 ` [PATCH v4 4/7] dt: mdio-mux: Add mdio multiplexer driver node Pramod Kumar
2016-06-06 12:41 ` Pramod Kumar
2016-06-06 12:41 ` Pramod Kumar
2016-06-06 18:37 ` Florian Fainelli
2016-06-06 18:37 ` Florian Fainelli
2016-06-10 4:24 ` Pramod Kumar
2016-06-10 4:24 ` Pramod Kumar
2016-06-06 12:41 ` [PATCH v4 5/7] net: mdio-mux: Add MDIO mux driver for iProc SoCs Pramod Kumar
2016-06-06 12:41 ` Pramod Kumar
2016-06-06 14:15 ` Andrew Lunn
2016-06-06 14:15 ` Andrew Lunn
2016-06-06 14:15 ` Andrew Lunn
2016-06-06 18:42 ` Florian Fainelli
2016-06-06 18:42 ` Florian Fainelli
2016-06-06 12:41 ` [PATCH v4 6/7] binding: PHY: Binding doc for NS2 PCIe PHYs Pramod Kumar
2016-06-06 12:41 ` Pramod Kumar
2016-06-06 12:41 ` [PATCH v4 7/7] phy: Add Northstar2 PCI Phy support Pramod Kumar
2016-06-06 12:41 ` Pramod Kumar
2016-06-06 18:42 ` Florian Fainelli
2016-06-06 18:42 ` Florian Fainelli
2016-06-06 18:42 ` Florian Fainelli
2016-06-07 12:25 ` Pramod Kumar
2016-06-07 12:25 ` Pramod Kumar
2016-06-30 12:16 ` Kishon Vijay Abraham I
2016-06-30 12:16 ` Kishon Vijay Abraham I
2016-06-30 12:16 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160608194043.GA32093@rob-hp-laptop \
--to=robh@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=pramod.kumar@broadcom.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.