* [PATCH] i915/fbc: Disable on HSW by default for now
@ 2016-06-09 15:58 ` Lyude
0 siblings, 0 replies; 8+ messages in thread
From: Lyude @ 2016-06-09 15:58 UTC (permalink / raw)
To: intel-gfx, Paulo Zanoni, Rob Clark
Cc: Lyude, stable, Daniel Vetter, Jani Nikula, David Airlie,
open list:INTEL DRM DRIVERS (excluding Poulsbo, Moorestow...),
linux-kernel@vger.kernel.org (open list)
>From https://bugs.freedesktop.org/show_bug.cgi?id=96461 :
This was kind of a difficult bug to track down. If you're using a
Haswell system running GNOME and you have fbc completely enabled and
working, playing videos can result in video artifacts. Steps to
reproduce:
- Run GNOME
- Ensure FBC is enabled and active
- Download a movie, I used the ogg version of Big Buck Bunny for this
- Run `gst-launch-1.0 filesrc location='some_movie.ogg' ! decodebin !
glimagesink` in a terminal
- Watch for about over a minute, you'll see small horizontal lines go
down the screen.
For the time being, disable FBC for Haswell by default.
Signed-off-by: Lyude <cpaul@redhat.com>
Cc: stable@vger.kernel.org
---
drivers/gpu/drm/i915/intel_fbc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c
index 0f0492f..28f4407 100644
--- a/drivers/gpu/drm/i915/intel_fbc.c
+++ b/drivers/gpu/drm/i915/intel_fbc.c
@@ -823,8 +823,7 @@ static bool intel_fbc_can_choose(struct intel_crtc *crtc)
{
struct drm_i915_private *dev_priv = crtc->base.dev->dev_private;
struct intel_fbc *fbc = &dev_priv->fbc;
- bool enable_by_default = IS_HASWELL(dev_priv) ||
- IS_BROADWELL(dev_priv);
+ bool enable_by_default = IS_BROADWELL(dev_priv);
if (intel_vgpu_active(dev_priv->dev)) {
fbc->no_fbc_reason = "VGPU is active";
--
2.5.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] i915/fbc: Disable on HSW by default for now
@ 2016-06-09 15:58 ` Lyude
0 siblings, 0 replies; 8+ messages in thread
From: Lyude @ 2016-06-09 15:58 UTC (permalink / raw)
To: intel-gfx, Paulo Zanoni, Rob Clark
Cc: stable, open list:INTEL DRM DRIVERS excluding Poulsbo,
Moorestow...,
linux-kernel@vger.kernel.org open list, Daniel Vetter, Lyude
From https://bugs.freedesktop.org/show_bug.cgi?id=96461 :
This was kind of a difficult bug to track down. If you're using a
Haswell system running GNOME and you have fbc completely enabled and
working, playing videos can result in video artifacts. Steps to
reproduce:
- Run GNOME
- Ensure FBC is enabled and active
- Download a movie, I used the ogg version of Big Buck Bunny for this
- Run `gst-launch-1.0 filesrc location='some_movie.ogg' ! decodebin !
glimagesink` in a terminal
- Watch for about over a minute, you'll see small horizontal lines go
down the screen.
For the time being, disable FBC for Haswell by default.
Signed-off-by: Lyude <cpaul@redhat.com>
Cc: stable@vger.kernel.org
---
drivers/gpu/drm/i915/intel_fbc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c
index 0f0492f..28f4407 100644
--- a/drivers/gpu/drm/i915/intel_fbc.c
+++ b/drivers/gpu/drm/i915/intel_fbc.c
@@ -823,8 +823,7 @@ static bool intel_fbc_can_choose(struct intel_crtc *crtc)
{
struct drm_i915_private *dev_priv = crtc->base.dev->dev_private;
struct intel_fbc *fbc = &dev_priv->fbc;
- bool enable_by_default = IS_HASWELL(dev_priv) ||
- IS_BROADWELL(dev_priv);
+ bool enable_by_default = IS_BROADWELL(dev_priv);
if (intel_vgpu_active(dev_priv->dev)) {
fbc->no_fbc_reason = "VGPU is active";
--
2.5.5
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* ✗ Ro.CI.BAT: warning for i915/fbc: Disable on HSW by default for now
2016-06-09 15:58 ` Lyude
(?)
@ 2016-06-09 16:28 ` Patchwork
-1 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2016-06-09 16:28 UTC (permalink / raw)
To: cpaul; +Cc: intel-gfx
== Series Details ==
Series: i915/fbc: Disable on HSW by default for now
URL : https://patchwork.freedesktop.org/series/8503/
State : warning
== Summary ==
Series 8503v1 i915/fbc: Disable on HSW by default for now
http://patchwork.freedesktop.org/api/1.0/series/8503/revisions/1/mbox
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-a:
dmesg-warn -> SKIP (ro-bdw-i7-5557U)
dmesg-warn -> SKIP (ro-bdw-i5-5250u)
Subgroup suspend-read-crc-pipe-c:
skip -> DMESG-WARN (ro-bdw-i5-5250u)
fi-bdw-i7-5557u total:213 pass:201 dwarn:0 dfail:0 fail:0 skip:12
fi-skl-i5-6260u total:213 pass:202 dwarn:0 dfail:0 fail:0 skip:11
fi-skl-i7-6700k total:213 pass:188 dwarn:0 dfail:0 fail:0 skip:25
fi-snb-i7-2600 total:213 pass:174 dwarn:0 dfail:0 fail:0 skip:39
ro-bdw-i5-5250u total:213 pass:197 dwarn:3 dfail:0 fail:0 skip:13
ro-bdw-i7-5557U total:213 pass:197 dwarn:2 dfail:0 fail:0 skip:14
ro-bdw-i7-5600u total:213 pass:185 dwarn:0 dfail:0 fail:0 skip:28
ro-bsw-n3050 total:213 pass:172 dwarn:0 dfail:0 fail:2 skip:39
ro-byt-n2820 total:213 pass:173 dwarn:0 dfail:0 fail:3 skip:37
ro-hsw-i3-4010u total:213 pass:190 dwarn:0 dfail:0 fail:0 skip:23
ro-hsw-i7-4770r total:213 pass:190 dwarn:0 dfail:0 fail:0 skip:23
ro-ilk1-i5-650 total:208 pass:150 dwarn:0 dfail:0 fail:1 skip:57
ro-ivb-i7-3770 total:213 pass:181 dwarn:0 dfail:0 fail:0 skip:32
ro-ivb2-i7-3770 total:213 pass:185 dwarn:0 dfail:0 fail:0 skip:28
ro-snb-i7-2620M total:213 pass:174 dwarn:0 dfail:0 fail:1 skip:38
fi-hsw-i7-4770k failed to connect after reboot
Results at /archive/results/CI_IGT_test/RO_Patchwork_1150/
487a126 drm-intel-nightly: 2016y-06m-09d-10h-05m-55s UTC integration manifest
432cf03 i915/fbc: Disable on HSW by default for now
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] i915/fbc: Disable on HSW by default for now
2016-06-09 15:58 ` Lyude
(?)
(?)
@ 2016-06-09 19:04 ` Zanoni, Paulo R
2016-06-10 6:44 ` Stefan Richter
-1 siblings, 1 reply; 8+ messages in thread
From: Zanoni, Paulo R @ 2016-06-09 19:04 UTC (permalink / raw)
To: cpaul, intel-gfx, stefanr, stevenhoneyman, rclark
Cc: dri-devel, jani.nikula, stable, Vetter, Daniel, airlied
Em Qui, 2016-06-09 às 11:58 -0400, Lyude escreveu:
> From https://bugs.freedesktop.org/show_bug.cgi?id=96461 :
>
> This was kind of a difficult bug to track down. If you're using a
> Haswell system running GNOME and you have fbc completely enabled and
> working, playing videos can result in video artifacts. Steps to
> reproduce:
>
> - Run GNOME
> - Ensure FBC is enabled and active
> - Download a movie, I used the ogg version of Big Buck Bunny for this
> - Run `gst-launch-1.0 filesrc location='some_movie.ogg' ! decodebin !
> glimagesink` in a terminal
> - Watch for about over a minute, you'll see small horizontal lines go
> down the screen.
If you "dmesg | grep -i underrun", do you see anything (even if it
doesn't happen during the moments of corruption)?
Does the problem still happen if you apply these patches?
- https://patchwork.freedesktop.org/patch/79567/
- https://patchwork.freedesktop.org/patch/80857/
- https://patchwork.freedesktop.org/patch/92634/
>
> For the time being, disable FBC for Haswell by default.
In case we want to improve the commit message:
We also got reports from Steven Honeyman on openbox+roxterm, and from
Stefan Richter.
Anyway, there's a regression that needs to be fixed, so:
Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
We can always try again later.
>
> Signed-off-by: Lyude <cpaul@redhat.com>
> Cc: stable@vger.kernel.org
> ---
> drivers/gpu/drm/i915/intel_fbc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_fbc.c
> b/drivers/gpu/drm/i915/intel_fbc.c
> index 0f0492f..28f4407 100644
> --- a/drivers/gpu/drm/i915/intel_fbc.c
> +++ b/drivers/gpu/drm/i915/intel_fbc.c
> @@ -823,8 +823,7 @@ static bool intel_fbc_can_choose(struct
> intel_crtc *crtc)
> {
> struct drm_i915_private *dev_priv = crtc->base.dev-
> >dev_private;
> struct intel_fbc *fbc = &dev_priv->fbc;
> - bool enable_by_default = IS_HASWELL(dev_priv) ||
> - IS_BROADWELL(dev_priv);
> + bool enable_by_default = IS_BROADWELL(dev_priv);
>
> if (intel_vgpu_active(dev_priv->dev)) {
> fbc->no_fbc_reason = "VGPU is active";
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] i915/fbc: Disable on HSW by default for now
2016-06-09 19:04 ` [PATCH] " Zanoni, Paulo R
@ 2016-06-10 6:44 ` Stefan Richter
0 siblings, 0 replies; 8+ messages in thread
From: Stefan Richter @ 2016-06-10 6:44 UTC (permalink / raw)
To: Zanoni, Paulo R
Cc: cpaul, intel-gfx, stevenhoneyman, rclark, dri-devel, jani.nikula,
stable, Vetter, Daniel, airlied
On Jun 09 Zanoni, Paulo R wrote:
> Em Qui, 2016-06-09 às 11:58 -0400, Lyude escreveu:
> > From https://bugs.freedesktop.org/show_bug.cgi?id=96461 :
> >
> > This was kind of a difficult bug to track down. If you're using a
> > Haswell system running GNOME and you have fbc completely enabled and
> > working, playing videos can result in video artifacts.
[...]
> > For the time being, disable FBC for Haswell by default.
>
> In case we want to improve the commit message:
>
> We also got reports from Steven Honeyman on openbox+roxterm, and from
> Stefan Richter.
Perhaps also worth mentioning in the changelog:
Stefan Richter reported kernel freezes (no video artifacts) when fbc is on.
(E3-1245 v3 with HD P4600; openbox and some KDE and LXDE applications,
thread begins at https://lkml.org/lkml/2016/4/26/813)
--
Stefan Richter
-======----- -==- -=-=-
http://arcgraph.de/sr/
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] i915/fbc: Disable on HSW by default for now
@ 2016-06-10 6:44 ` Stefan Richter
0 siblings, 0 replies; 8+ messages in thread
From: Stefan Richter @ 2016-06-10 6:44 UTC (permalink / raw)
To: Zanoni, Paulo R
Cc: rclark, airlied, intel-gfx, dri-devel, Vetter, Daniel, stable,
stevenhoneyman
On Jun 09 Zanoni, Paulo R wrote:
> Em Qui, 2016-06-09 às 11:58 -0400, Lyude escreveu:
> > From https://bugs.freedesktop.org/show_bug.cgi?id=96461 :
> >
> > This was kind of a difficult bug to track down. If you're using a
> > Haswell system running GNOME and you have fbc completely enabled and
> > working, playing videos can result in video artifacts.
[...]
> > For the time being, disable FBC for Haswell by default.
>
> In case we want to improve the commit message:
>
> We also got reports from Steven Honeyman on openbox+roxterm, and from
> Stefan Richter.
Perhaps also worth mentioning in the changelog:
Stefan Richter reported kernel freezes (no video artifacts) when fbc is on.
(E3-1245 v3 with HD P4600; openbox and some KDE and LXDE applications,
thread begins at https://lkml.org/lkml/2016/4/26/813)
--
Stefan Richter
-======----- -==- -=-=-
http://arcgraph.de/sr/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] i915/fbc: Disable on HSW by default for now
2016-06-10 6:44 ` Stefan Richter
@ 2016-06-20 21:11 ` Zanoni, Paulo R
-1 siblings, 0 replies; 8+ messages in thread
From: Zanoni, Paulo R @ 2016-06-20 21:11 UTC (permalink / raw)
To: stefanr
Cc: intel-gfx, cpaul, stable, Vetter, Daniel, stevenhoneyman, rclark,
dri-devel, airlied, jani.nikula
Em Sex, 2016-06-10 às 08:44 +0200, Stefan Richter escreveu:
> On Jun 09 Zanoni, Paulo R wrote:
> >
> > Em Qui, 2016-06-09 às 11:58 -0400, Lyude escreveu:
> > >
> > > From https://bugs.freedesktop.org/show_bug.cgi?id=96461 :
> > >
> > > This was kind of a difficult bug to track down. If you're using a
> > > Haswell system running GNOME and you have fbc completely enabled
> > > and
> > > working, playing videos can result in video artifacts.
> [...]
> >
> > >
> > > For the time being, disable FBC for Haswell by default.
> > In case we want to improve the commit message:
> >
> > We also got reports from Steven Honeyman on openbox+roxterm, and
> > from
> > Stefan Richter.
> Perhaps also worth mentioning in the changelog:
> Stefan Richter reported kernel freezes (no video artifacts) when fbc
> is on.
> (E3-1245 v3 with HD P4600; openbox and some KDE and LXDE
> applications,
> thread begins at https://lkml.org/lkml/2016/4/26/813)
Patch merged with small additions to the commit message.
Thanks everybody involved,
Paulo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] i915/fbc: Disable on HSW by default for now
@ 2016-06-20 21:11 ` Zanoni, Paulo R
0 siblings, 0 replies; 8+ messages in thread
From: Zanoni, Paulo R @ 2016-06-20 21:11 UTC (permalink / raw)
To: stefanr
Cc: rclark, airlied, intel-gfx, stable, dri-devel, Vetter, Daniel,
stevenhoneyman
Em Sex, 2016-06-10 às 08:44 +0200, Stefan Richter escreveu:
> On Jun 09 Zanoni, Paulo R wrote:
> >
> > Em Qui, 2016-06-09 às 11:58 -0400, Lyude escreveu:
> > >
> > > From https://bugs.freedesktop.org/show_bug.cgi?id=96461 :
> > >
> > > This was kind of a difficult bug to track down. If you're using a
> > > Haswell system running GNOME and you have fbc completely enabled
> > > and
> > > working, playing videos can result in video artifacts.
> [...]
> >
> > >
> > > For the time being, disable FBC for Haswell by default.
> > In case we want to improve the commit message:
> >
> > We also got reports from Steven Honeyman on openbox+roxterm, and
> > from
> > Stefan Richter.
> Perhaps also worth mentioning in the changelog:
> Stefan Richter reported kernel freezes (no video artifacts) when fbc
> is on.
> (E3-1245 v3 with HD P4600; openbox and some KDE and LXDE
> applications,
> thread begins at https://lkml.org/lkml/2016/4/26/813)
Patch merged with small additions to the commit message.
Thanks everybody involved,
Paulo
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-06-20 21:14 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-09 15:58 [PATCH] i915/fbc: Disable on HSW by default for now Lyude
2016-06-09 15:58 ` Lyude
2016-06-09 16:28 ` ✗ Ro.CI.BAT: warning for " Patchwork
2016-06-09 19:04 ` [PATCH] " Zanoni, Paulo R
2016-06-10 6:44 ` Stefan Richter
2016-06-10 6:44 ` Stefan Richter
2016-06-20 21:11 ` Zanoni, Paulo R
2016-06-20 21:11 ` Zanoni, Paulo R
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.