[Buildroot] [PATCH v2 1/1] package/vlc: configure.ac does not support --en/--disable-freerdp

[Buildroot] [PATCH v2 1/1] package/vlc: configure.ac does not support --en/--disable-freerdp

[Bernd Kuhls]

Vlc configure does not allow disabling the optional dependency to
freerdp:
http://git.videolan.org/?p=vlc/vlc-2.2.git;a=blob;f=configure.ac;h=e021546e284d7daefdb4d94f430eb0bc57722210;hb=HEAD#l1890

Vlc configure prints a warning that the option --disable-libfreerdp
is not used:

configure: WARNING: unrecognized options: --disable-gtk-doc,
 --disable-gtk-doc-html, --disable-doc, --disable-docs,
 --disable-documentation, --with-xmlto, --with-fop, --enable-ipv6,
 --disable-libfreerdp

This can be seen for example in autobuilder logs:
http://autobuild.buildroot.net/results/1a7/1a7893c13f6144e0ecd9f37f2f047c596ccedd35/build-end.log

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
v2: added new line before SoB (Thomas)
    clarified patch comment (Thomas):
    - freerdp is an optional dependency
    - this patch does not fix a build error, the reference to the
      autobuilder log is only present to show the problem

 package/vlc/vlc.mk | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/package/vlc/vlc.mk b/package/vlc/vlc.mk
index 30887bd..4dc8dfe 100644
--- a/package/vlc/vlc.mk
+++ b/package/vlc/vlc.mk
@@ -137,10 +137,7 @@ VLC_CONF_OPTS += --disable-flac
 endif
 
 ifeq ($(BR2_PACKAGE_FREERDP),y)
-VLC_CONF_OPTS += --enable-freerdp
 VLC_DEPENDENCIES += freerdp
-else
-VLC_CONF_OPTS += --disable-libfreerdp
 endif
 
 ifeq ($(BR2_PACKAGE_HAS_LIBGL),y)
-- 
2.8.1

[Buildroot] [PATCH v2 1/1] package/vlc: configure.ac does not support --en/--disable-freerdp

[Thomas Petazzoni]

Hello,

On Tue, 17 May 2016 22:48:44 +0200, Bernd Kuhls wrote:
> Vlc configure does not allow disabling the optional dependency to
> freerdp:
> http://git.videolan.org/?p=vlc/vlc-2.2.git;a=blob;f=configure.ac;h=e021546e284d7daefdb4d94f430eb0bc57722210;hb=HEAD#l1890
> 
> Vlc configure prints a warning that the option --disable-libfreerdp
> is not used:
> 
> configure: WARNING: unrecognized options: --disable-gtk-doc,
>  --disable-gtk-doc-html, --disable-doc, --disable-docs,
>  --disable-documentation, --with-xmlto, --with-fop, --enable-ipv6,
>  --disable-libfreerdp
> 
> This can be seen for example in autobuilder logs:
> http://autobuild.buildroot.net/results/1a7/1a7893c13f6144e0ecd9f37f2f047c596ccedd35/build-end.log
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> v2: added new line before SoB (Thomas)
>     clarified patch comment (Thomas):
>     - freerdp is an optional dependency
>     - this patch does not fix a build error, the reference to the
>       autobuilder log is only present to show the problem

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com