Re: [kvm-unit-tests PATCH v4 04/12] pci: Rework pci_bar_addr()

[Alexander Gordeev <agordeev@redhat.com>]

On Mon, Jun 06, 2016 at 04:12:03PM +0200, Andrew Jones wrote:
> > diff --git a/lib/x86/asm/pci.h b/lib/x86/asm/pci.h
> > index 821a2c1e180a..813dc28b9232 100644
> > --- a/lib/x86/asm/pci.h
> > +++ b/lib/x86/asm/pci.h
> > @@ -35,4 +35,10 @@ static inline void pci_config_writel(pcidevaddr_t dev, uint8_t reg, uint32_t val
> >      outl(val, 0xCFC);
> >  }
> >  
> > +static inline
> > +phys_addr_t pci_translate_addr(pcidevaddr_t __unused dev, uint64_t addr)
> 
> I put the __unused after the argument name.
> 
> > +{
> > +    return addr;
> 
> Need tab here.

It will differ then from the coding style of the other functions
in this header (and elsewhere in x86).

> > +}
> > +
> >  #endif
> > -- 
> > 1.8.3.1
> >
> 
> Thanks,
> drew