From: Peter Chen <hzpeterchen@gmail.com> To: Roger Quadros <rogerq@ti.com> Cc: peter.chen@freescale.com, balbi@kernel.org, tony@atomide.com, gregkh@linuxfoundation.org, dan.j.williams@intel.com, mathias.nyman@linux.intel.com, Joao.Pinto@synopsys.com, sergei.shtylyov@cogentembedded.com, jun.li@freescale.com, grygorii.strashko@ti.com, yoshihiro.shimoda.uh@renesas.com, robh@kernel.org, nsekhar@ti.com, b-liu@ti.com, joe@perches.com, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v10 08/14] usb: otg: add OTG/dual-role core Date: Sun, 12 Jun 2016 19:21:05 +0800 [thread overview] Message-ID: <20160612112105.GB32615@shlinux2> (raw) In-Reply-To: <1465564043-27163-9-git-send-email-rogerq@ti.com> On Fri, Jun 10, 2016 at 04:07:17PM +0300, Roger Quadros wrote: > index dca7856..03f7204 100644 > --- a/drivers/usb/Makefile > +++ b/drivers/usb/Makefile > @@ -59,5 +59,6 @@ obj-$(CONFIG_USB_RENESAS_USBHS) += renesas_usbhs/ > obj-$(CONFIG_USB_GADGET) += gadget/ > > obj-$(CONFIG_USB_COMMON) += common/ > +obj-$(CONFIG_USB_OTG_CORE) += common/ I don't think you need to make above change, why you do it? > + > +/** > + * usb_otg_get_data() - get usb_otg data structa %s/structa/structure > + > +/** > + * usb_otg_kick_fsm() - Kick the OTG state machine > + * @otg_dev: OTG controller device > + * > + * Used by USB host/gadget stack to sync OTG related > + * events to the OTG state machine. > + * e.g. change in host_bus->b_hnp_enable, gadget->b_hnp_enable > + * > + * Return: 0 on success, error value otherwise. > + */ > +int usb_otg_kick_fsm(struct device *otg_dev) > +{ > + struct usb_otg *otg; > + > + mutex_lock(&otg_list_mutex); > + otg = usb_otg_get_data(otg_dev); > + mutex_unlock(&otg_list_mutex); > + if (!otg) { > + dev_dbg(otg_dev, "otg: %s: invalid otg device\n", > + __func__); > + return -ENODEV; > + } > + > + usb_otg_sync_inputs(otg); > + > + return 0; > +} > +EXPORT_SYMBOL_GPL(usb_otg_kick_fsm); Do you have any users for this API? If no, please delete it in this version. > + > +/** > + * usb_otg_register_hcd() - Register the host controller to OTG core > + * @hcd: host controller > + * @irqnum: interrupt number > + * @irqflags: interrupt flags > + * @ops: HCD ops to interface with the HCD > + * > + * This is used by the USB Host stack to register the host controller > + * to the OTG core. Host controller must not be started by the > + * caller as it is left upto the OTG state machine to do so. %s/upto/up to > + > +/** > + * usb_otg_register_gadget() - Register the gadget controller to OTG core > + * @gadget: gadget controller instance > + * @ops: gadget interface ops > + * > + * This is used by the USB gadget stack to register the gadget controller > + * to the OTG core. Gadget controller must not be started by the > + * caller as it is left upto the OTG state machine to do so. > + * %s/upto/up to -- Best Regards, Peter Chen
WARNING: multiple messages have this Message-ID (diff)
From: Peter Chen <hzpeterchen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> To: Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org> Cc: peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org, balbi-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, mathias.nyman-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, Joao.Pinto-HKixBCOQz3hWk0Htik3J/w@public.gmane.org, sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org, jun.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org, grygorii.strashko-l0cyMroinI0@public.gmane.org, yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org, robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, nsekhar-l0cyMroinI0@public.gmane.org, b-liu-l0cyMroinI0@public.gmane.org, joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [PATCH v10 08/14] usb: otg: add OTG/dual-role core Date: Sun, 12 Jun 2016 19:21:05 +0800 [thread overview] Message-ID: <20160612112105.GB32615@shlinux2> (raw) In-Reply-To: <1465564043-27163-9-git-send-email-rogerq-l0cyMroinI0@public.gmane.org> On Fri, Jun 10, 2016 at 04:07:17PM +0300, Roger Quadros wrote: > index dca7856..03f7204 100644 > --- a/drivers/usb/Makefile > +++ b/drivers/usb/Makefile > @@ -59,5 +59,6 @@ obj-$(CONFIG_USB_RENESAS_USBHS) += renesas_usbhs/ > obj-$(CONFIG_USB_GADGET) += gadget/ > > obj-$(CONFIG_USB_COMMON) += common/ > +obj-$(CONFIG_USB_OTG_CORE) += common/ I don't think you need to make above change, why you do it? > + > +/** > + * usb_otg_get_data() - get usb_otg data structa %s/structa/structure > + > +/** > + * usb_otg_kick_fsm() - Kick the OTG state machine > + * @otg_dev: OTG controller device > + * > + * Used by USB host/gadget stack to sync OTG related > + * events to the OTG state machine. > + * e.g. change in host_bus->b_hnp_enable, gadget->b_hnp_enable > + * > + * Return: 0 on success, error value otherwise. > + */ > +int usb_otg_kick_fsm(struct device *otg_dev) > +{ > + struct usb_otg *otg; > + > + mutex_lock(&otg_list_mutex); > + otg = usb_otg_get_data(otg_dev); > + mutex_unlock(&otg_list_mutex); > + if (!otg) { > + dev_dbg(otg_dev, "otg: %s: invalid otg device\n", > + __func__); > + return -ENODEV; > + } > + > + usb_otg_sync_inputs(otg); > + > + return 0; > +} > +EXPORT_SYMBOL_GPL(usb_otg_kick_fsm); Do you have any users for this API? If no, please delete it in this version. > + > +/** > + * usb_otg_register_hcd() - Register the host controller to OTG core > + * @hcd: host controller > + * @irqnum: interrupt number > + * @irqflags: interrupt flags > + * @ops: HCD ops to interface with the HCD > + * > + * This is used by the USB Host stack to register the host controller > + * to the OTG core. Host controller must not be started by the > + * caller as it is left upto the OTG state machine to do so. %s/upto/up to > + > +/** > + * usb_otg_register_gadget() - Register the gadget controller to OTG core > + * @gadget: gadget controller instance > + * @ops: gadget interface ops > + * > + * This is used by the USB gadget stack to register the gadget controller > + * to the OTG core. Gadget controller must not be started by the > + * caller as it is left upto the OTG state machine to do so. > + * %s/upto/up to -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-06-12 11:27 UTC|newest] Thread overview: 172+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-06-10 13:07 [PATCH v10 00/14] USB OTG/dual-role framework Roger Quadros 2016-06-10 13:07 ` Roger Quadros 2016-06-10 13:07 ` [PATCH v10 01/14] usb: hcd: Initialize hcd->flags to 0 Roger Quadros 2016-06-10 13:07 ` Roger Quadros 2016-06-14 8:16 ` Roger Quadros 2016-06-14 8:16 ` Roger Quadros 2016-06-10 13:07 ` [PATCH v10 02/14] usb: otg-fsm: Prevent build warning "VDBG" redefined Roger Quadros 2016-06-10 13:07 ` Roger Quadros 2016-06-10 13:07 ` [PATCH v10 03/14] usb: hcd.h: Add OTG to HCD interface Roger Quadros 2016-06-10 13:07 ` Roger Quadros 2016-06-14 8:17 ` Roger Quadros 2016-06-14 8:17 ` Roger Quadros 2016-06-14 14:21 ` Alan Stern 2016-06-14 14:21 ` Alan Stern 2016-06-15 7:14 ` Roger Quadros 2016-06-15 7:14 ` Roger Quadros 2016-06-10 13:07 ` [PATCH v10 04/14] usb: otg-fsm: use usb_otg wherever possible Roger Quadros 2016-06-10 13:07 ` Roger Quadros 2016-06-10 13:07 ` [PATCH v10 05/14] usb: otg-fsm: move host controller operations into usb_otg->hcd_ops Roger Quadros 2016-06-10 13:07 ` Roger Quadros 2016-06-10 13:07 ` [PATCH v10 06/14] usb: gadget.h: Add OTG to gadget interface Roger Quadros 2016-06-10 13:07 ` Roger Quadros 2016-06-12 9:13 ` Peter Chen 2016-06-20 7:21 ` Felipe Balbi 2016-06-20 7:21 ` Felipe Balbi 2016-06-20 7:28 ` Roger Quadros 2016-06-20 7:28 ` Roger Quadros 2016-06-20 8:13 ` Felipe Balbi 2016-06-20 8:13 ` Felipe Balbi 2016-06-20 8:25 ` Roger Quadros 2016-06-20 8:25 ` Roger Quadros 2016-06-20 9:24 ` Felipe Balbi 2016-06-20 9:24 ` Felipe Balbi 2016-06-20 9:43 ` Roger Quadros 2016-06-20 9:43 ` Roger Quadros 2016-06-10 13:07 ` [PATCH v10 07/14] usb: otg: get rid of CONFIG_USB_OTG_FSM in favour of CONFIG_USB_OTG Roger Quadros 2016-06-10 13:07 ` Roger Quadros 2016-06-10 13:07 ` [PATCH v10 08/14] usb: otg: add OTG/dual-role core Roger Quadros 2016-06-10 13:07 ` Roger Quadros 2016-06-12 11:21 ` Peter Chen [this message] 2016-06-12 11:21 ` Peter Chen 2016-06-13 7:42 ` Roger Quadros 2016-06-13 7:42 ` Roger Quadros 2016-06-13 7:56 ` [PATCH v11 " Roger Quadros 2016-06-13 7:56 ` Roger Quadros 2016-06-13 7:58 ` Peter Chen 2016-06-20 7:45 ` Felipe Balbi 2016-06-20 7:45 ` Felipe Balbi 2016-06-20 10:13 ` Roger Quadros 2016-06-20 10:13 ` Roger Quadros 2016-06-20 12:03 ` Felipe Balbi 2016-06-20 12:26 ` Roger Quadros 2016-06-20 12:26 ` Roger Quadros 2016-06-20 12:46 ` Felipe Balbi 2016-06-21 6:39 ` Peter Chen 2016-06-21 7:19 ` Felipe Balbi 2016-06-21 7:19 ` Felipe Balbi 2016-06-21 8:02 ` Peter Chen 2016-06-21 8:18 ` Felipe Balbi 2016-06-21 8:18 ` Felipe Balbi 2016-06-21 9:14 ` Peter Chen 2016-06-21 9:14 ` Peter Chen 2016-06-21 12:35 ` Felipe Balbi 2016-06-21 12:35 ` Felipe Balbi 2016-06-21 13:12 ` Peter Chen 2016-06-21 14:47 ` Felipe Balbi 2016-06-22 3:33 ` Peter Chen 2016-06-22 3:33 ` Peter Chen 2016-06-22 6:51 ` Felipe Balbi 2016-06-22 6:51 ` Felipe Balbi 2016-06-22 7:30 ` Peter Chen 2016-06-22 7:30 ` Peter Chen 2016-06-22 8:00 ` Felipe Balbi 2016-06-22 8:00 ` Felipe Balbi 2016-06-23 7:41 ` Yoshihiro Shimoda 2016-06-23 7:41 ` Yoshihiro Shimoda 2016-06-21 2:30 ` Yoshihiro Shimoda 2016-06-21 2:30 ` Yoshihiro Shimoda 2016-06-21 7:21 ` Felipe Balbi 2016-06-21 7:21 ` Felipe Balbi 2016-06-20 11:49 ` Peter Chen 2016-06-20 11:49 ` Peter Chen 2016-06-20 12:08 ` Felipe Balbi 2016-06-20 12:08 ` Felipe Balbi 2016-06-21 6:05 ` Peter Chen 2016-06-21 7:26 ` Felipe Balbi 2016-06-21 7:26 ` Felipe Balbi 2016-06-21 9:07 ` Peter Chen 2016-06-21 9:07 ` Peter Chen 2016-06-21 10:02 ` Felipe Balbi 2016-06-21 10:43 ` Tony Lindgren 2016-06-21 10:43 ` Tony Lindgren 2016-06-21 10:56 ` Felipe Balbi 2016-06-21 13:05 ` Peter Chen 2016-06-21 13:05 ` Peter Chen 2016-06-22 6:56 ` Felipe Balbi 2016-06-22 6:56 ` Felipe Balbi 2016-06-22 7:33 ` Peter Chen 2016-06-22 8:03 ` Felipe Balbi 2016-06-22 7:49 ` Roger Quadros 2016-06-22 7:49 ` Roger Quadros 2016-06-22 8:14 ` Felipe Balbi 2016-06-22 8:30 ` Roger Quadros 2016-06-22 8:30 ` Roger Quadros 2017-01-19 11:56 ` Vivek Gautam 2017-01-19 12:15 ` Roger Quadros 2017-01-19 12:15 ` Roger Quadros 2017-01-19 15:15 ` vivek.gautam 2017-01-20 8:30 ` Roger Quadros 2017-01-20 8:30 ` Roger Quadros 2017-01-20 11:39 ` Vivek Gautam 2016-06-23 7:42 ` Yoshihiro Shimoda 2016-06-23 7:42 ` Yoshihiro Shimoda 2016-06-10 13:07 ` [PATCH v10 09/14] usb: of: add an API to get OTG device from USB controller node Roger Quadros 2016-06-10 13:07 ` Roger Quadros 2016-06-13 8:13 ` Jun Li 2016-06-13 8:13 ` Jun Li 2016-06-13 8:16 ` Roger Quadros 2016-06-13 8:16 ` Roger Quadros 2016-06-13 8:23 ` [PATCH v11 " Roger Quadros 2016-06-13 8:23 ` Roger Quadros 2016-06-10 13:07 ` [PATCH v10 10/14] usb: otg: add hcd companion support Roger Quadros 2016-06-10 13:07 ` Roger Quadros 2016-06-10 13:07 ` [PATCH v10 11/14] usb: otg: use dev_vdbg() instead of VDBG() Roger Quadros 2016-06-10 13:07 ` Roger Quadros 2016-06-10 13:07 ` [PATCH v10 12/14] usb: hcd: Adapt to OTG core Roger Quadros 2016-06-10 13:07 ` Roger Quadros 2016-06-14 8:17 ` Roger Quadros 2016-06-14 8:17 ` Roger Quadros 2016-06-10 13:07 ` [PATCH v10 13/14] usb: gadget: udc: adapt " Roger Quadros 2016-06-10 13:07 ` Roger Quadros 2016-06-12 11:36 ` Peter Chen 2016-06-12 11:36 ` Peter Chen 2016-06-13 7:14 ` Roger Quadros 2016-06-13 7:14 ` Roger Quadros 2016-06-13 7:20 ` Peter Chen 2016-06-13 7:20 ` Peter Chen 2016-06-13 7:37 ` Roger Quadros 2016-06-13 7:37 ` Roger Quadros 2016-06-13 7:40 ` Peter Chen 2016-06-13 7:40 ` Peter Chen 2016-06-13 7:55 ` [PATCH v11 " Roger Quadros 2016-06-13 7:55 ` Roger Quadros 2016-06-13 7:56 ` Peter Chen 2016-06-13 8:06 ` Roger Quadros 2016-06-13 8:06 ` Roger Quadros 2016-06-10 13:07 ` [PATCH v10 14/14] usb: host: xhci-plat: Add otg device to platform data Roger Quadros 2016-06-10 13:07 ` Roger Quadros 2016-06-14 8:18 ` Roger Quadros 2016-06-14 8:18 ` Roger Quadros 2016-06-14 2:17 ` [PATCH v10 00/14] USB OTG/dual-role framework Peter Chen 2016-06-14 8:12 ` Roger Quadros 2016-06-14 8:12 ` Roger Quadros 2016-06-16 11:07 ` Roger Quadros 2016-06-16 11:07 ` Roger Quadros 2016-06-17 7:17 ` Felipe Balbi 2016-06-17 7:17 ` Felipe Balbi 2016-06-17 7:31 ` Roger Quadros 2016-06-17 7:31 ` Roger Quadros -- strict thread matches above, loose matches on Subject: below -- 2016-06-08 9:03 [PATCH v9 " Roger Quadros 2016-06-08 9:03 ` [PATCH v9 08/14] usb: otg: add OTG/dual-role core Roger Quadros 2016-06-09 7:53 ` [PATCH v10 " Roger Quadros 2016-06-09 7:53 ` Roger Quadros 2016-06-09 12:34 ` Sergei Shtylyov 2016-06-10 7:04 ` Roger Quadros 2016-06-10 7:04 ` Roger Quadros 2016-06-10 10:19 ` Roger Quadros 2016-06-10 10:19 ` Roger Quadros 2016-06-10 10:44 ` Sergei Shtylyov 2016-06-10 10:44 ` Sergei Shtylyov 2016-06-10 10:54 ` Roger Quadros 2016-06-10 10:54 ` Roger Quadros 2016-06-10 11:02 ` Felipe Balbi 2016-06-10 11:02 ` Felipe Balbi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160612112105.GB32615@shlinux2 \ --to=hzpeterchen@gmail.com \ --cc=Joao.Pinto@synopsys.com \ --cc=b-liu@ti.com \ --cc=balbi@kernel.org \ --cc=dan.j.williams@intel.com \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=grygorii.strashko@ti.com \ --cc=joe@perches.com \ --cc=jun.li@freescale.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=mathias.nyman@linux.intel.com \ --cc=nsekhar@ti.com \ --cc=peter.chen@freescale.com \ --cc=robh@kernel.org \ --cc=rogerq@ti.com \ --cc=sergei.shtylyov@cogentembedded.com \ --cc=tony@atomide.com \ --cc=yoshihiro.shimoda.uh@renesas.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.