From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Michal Suchanek <hramrach@gmail.com>
Cc: linux-sunxi@googlegroups.com, stable@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>, Chen-Yu Tsai <wens@csie.org>,
Russell King <linux@armlinux.org.uk>,
Mark Brown <broonie@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Olof Johansson <olof@lixom.net>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Javier Martinez Canillas <javier@osg.samsung.com>,
Simon Horman <horms+renesas@verge.net.au>,
Sjoerd Simons <sjoerd.simons@collabora.co.uk>,
Thierry Reding <treding@nvidia.com>,
Alison Wang <b18965@freescale.com>,
Timo Sigurdsson <public_timo.s@silentcreek.de>,
Jonathan Liu <net147@gmail.com>,
Gerhard Bertelsmann <info@gerhard-bertelsmann.de>,
Priit Laes <plaes@plaes.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH v3 03/13] spi: sun4i: fix FIFO limit
Date: Mon, 13 Jun 2016 21:56:01 +0200 [thread overview]
Message-ID: <20160613195601.GC2600@lukather> (raw)
In-Reply-To: <6495575d7c7e14da06f86d88a6a15042b4c6b96a.1465490774.git.hramrach@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 475 bytes --]
On Mon, Jun 13, 2016 at 05:46:49PM -0000, Michal Suchanek wrote:
> When testing SPI without DMA I noticed that filling the FIFO on the
> spi controller causes timeout.
>
> Always leave room for one byte in the FIFO.
>
> Signed-off-by: Michal Suchanek <hramrach@gmail.com>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Michal Suchanek <hramrach-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
Russell King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>,
Krzysztof Kozlowski
<k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Javier Martinez Canillas
<javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>,
Simon Horman
<horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>,
Sjoerd Simons
<sjoerd.simons-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>,
Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Alison Wang <b18965-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
Timo Sigurdsson
<public_timo.s-fWgRPtSzPNU3WX+qO2AYSQ@public.gmane.org>,
Jonathan Liu <net147-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Gerhard Bertelsmann
<info-La43T0Mi4bH5xCKuJOYmCvaTkwRoYoCU@public.gmane.org>,
Priit Laes <plaes-q/aMd4JkU83YtjvyW6yDsg@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel@lists.
Subject: Re: [PATCH v3 03/13] spi: sun4i: fix FIFO limit
Date: Mon, 13 Jun 2016 21:56:01 +0200 [thread overview]
Message-ID: <20160613195601.GC2600@lukather> (raw)
In-Reply-To: <6495575d7c7e14da06f86d88a6a15042b4c6b96a.1465490774.git.hramrach-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 518 bytes --]
On Mon, Jun 13, 2016 at 05:46:49PM -0000, Michal Suchanek wrote:
> When testing SPI without DMA I noticed that filling the FIFO on the
> spi controller causes timeout.
>
> Always leave room for one byte in the FIFO.
>
> Signed-off-by: Michal Suchanek <hramrach-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Acked-by: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 03/13] spi: sun4i: fix FIFO limit
Date: Mon, 13 Jun 2016 21:56:01 +0200 [thread overview]
Message-ID: <20160613195601.GC2600@lukather> (raw)
In-Reply-To: <6495575d7c7e14da06f86d88a6a15042b4c6b96a.1465490774.git.hramrach@gmail.com>
On Mon, Jun 13, 2016 at 05:46:49PM -0000, Michal Suchanek wrote:
> When testing SPI without DMA I noticed that filling the FIFO on the
> spi controller causes timeout.
>
> Always leave room for one byte in the FIFO.
>
> Signed-off-by: Michal Suchanek <hramrach@gmail.com>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160613/6b657bdc/attachment.sig>
next prev parent reply other threads:[~2016-06-13 19:56 UTC|newest]
Thread overview: 121+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 17:46 [PATCH v3 00/13] sunxi spi fixes Michal Suchanek
2016-06-13 17:46 ` Michal Suchanek
2016-06-13 17:46 ` [PATCH v3 01/13] spi: sunxi: set maximum and minimum speed of SPI master Michal Suchanek
2016-06-13 17:46 ` Michal Suchanek
2016-06-13 19:55 ` Maxime Ripard
2016-06-13 19:55 ` Maxime Ripard
2016-06-13 19:55 ` Maxime Ripard
2016-06-13 17:46 ` [PATCH v3 04/13] spi: sunxi: expose maximum transfer size limit Michal Suchanek
2016-06-13 17:46 ` Michal Suchanek
2016-06-13 19:56 ` Maxime Ripard
2016-06-13 19:56 ` Maxime Ripard
2016-06-13 19:56 ` Maxime Ripard
[not found] ` <cover.1465490774.git.hramrach-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-06-13 17:46 ` [PATCH v3 03/13] spi: sun4i: fix FIFO limit Michal Suchanek
2016-06-13 17:46 ` Michal Suchanek
2016-06-13 19:56 ` Maxime Ripard [this message]
2016-06-13 19:56 ` Maxime Ripard
2016-06-13 19:56 ` Maxime Ripard
2016-06-13 17:46 ` [PATCH v3 02/13] spi: sunxi: fix transfer timeout Michal Suchanek
2016-06-13 17:46 ` Michal Suchanek
2016-06-13 19:55 ` Maxime Ripard
2016-06-13 19:55 ` Maxime Ripard
2016-06-13 19:55 ` Maxime Ripard
2016-06-13 17:46 ` [PATCH v3 06/13] spi: sunxi: rename sun4i,sun6i -> sunxi Michal Suchanek
2016-06-13 17:46 ` Michal Suchanek
2016-06-13 17:46 ` [PATCH v3 05/13] spi: sun6i: update CS handling from spi-sun4i Michal Suchanek
2016-06-13 17:46 ` Michal Suchanek
2016-06-13 17:46 ` [PATCH v3 08/13] spi: sunxi: synchronize whitespace, comments, struct Michal Suchanek
2016-06-13 17:46 ` Michal Suchanek
2016-06-13 17:46 ` [PATCH v3 09/13] spi: sunxi: use register map Michal Suchanek
2016-06-13 17:46 ` Michal Suchanek
2016-06-13 17:46 ` [PATCH v3 07/13] spi: sunxi: rename constants to match between sun4i and sun6i Michal Suchanek
2016-06-13 17:46 ` Michal Suchanek
2016-06-13 23:31 ` [linux-sunxi] " Julian Calaby
2016-06-13 23:31 ` Julian Calaby
2016-06-13 23:31 ` Julian Calaby
2016-06-13 23:31 ` Julian Calaby
2016-06-14 4:43 ` [linux-sunxi] " Michal Suchanek
2016-06-14 4:43 ` Michal Suchanek
2016-06-14 4:43 ` Michal Suchanek
2016-06-14 4:43 ` Michal Suchanek
2016-06-13 17:46 ` [PATCH v3 11/13] dt: spi: sun4i: merge sun4i and sun6i binding doc Michal Suchanek
2016-06-13 17:46 ` Michal Suchanek
2016-06-13 23:45 ` [linux-sunxi] " Julian Calaby
2016-06-13 23:45 ` Julian Calaby
2016-06-13 23:45 ` Julian Calaby
2016-06-13 23:45 ` Julian Calaby
2016-06-14 4:40 ` [linux-sunxi] " Michal Suchanek
2016-06-14 4:40 ` Michal Suchanek
2016-06-14 4:40 ` Michal Suchanek
2016-06-14 4:40 ` Michal Suchanek
2016-06-14 4:48 ` [linux-sunxi] " Julian Calaby
2016-06-14 4:48 ` Julian Calaby
2016-06-14 4:48 ` Julian Calaby
2016-06-14 4:48 ` Julian Calaby
2016-06-13 17:46 ` [PATCH v3 10/13] spi: sunxi: merge sun4i and sun6i SPI driver Michal Suchanek
2016-06-13 17:46 ` Michal Suchanek
2016-06-13 23:43 ` [linux-sunxi] " Julian Calaby
2016-06-13 23:43 ` Julian Calaby
2016-06-13 23:43 ` Julian Calaby
2016-06-13 23:43 ` Julian Calaby
2016-06-14 4:34 ` [linux-sunxi] " Michal Suchanek
2016-06-14 4:34 ` Michal Suchanek
2016-06-14 4:34 ` Michal Suchanek
2016-06-14 4:34 ` Michal Suchanek
2016-06-14 4:47 ` [linux-sunxi] " Julian Calaby
2016-06-14 4:47 ` Julian Calaby
2016-06-14 4:47 ` Julian Calaby
2016-06-14 4:47 ` Julian Calaby
2016-06-14 5:28 ` [linux-sunxi] " Michal Suchanek
2016-06-14 5:28 ` Michal Suchanek
2016-06-14 5:28 ` Michal Suchanek
2016-06-14 5:28 ` Michal Suchanek
2016-06-14 5:45 ` [linux-sunxi] " Julian Calaby
2016-06-14 5:45 ` Julian Calaby
2016-06-14 5:45 ` Julian Calaby
2016-06-14 5:45 ` Julian Calaby
2016-06-14 6:35 ` Michal Suchanek
2016-06-14 6:35 ` Michal Suchanek
2016-06-14 6:35 ` Michal Suchanek
2016-06-14 6:35 ` Michal Suchanek
2016-06-14 11:20 ` [linux-sunxi] " Julian Calaby
2016-06-14 11:20 ` Julian Calaby
2016-06-14 11:20 ` Julian Calaby
2016-06-14 11:20 ` Julian Calaby
2016-06-13 17:46 ` [PATCH v3 13/13] spi: sun4i: add DMA support Michal
2016-06-13 17:46 ` Michal
2016-06-13 17:46 ` [PATCH v3 12/13] spi: sunxi: remove CONFIG_SPI_SUN6I Michal Suchanek
2016-06-13 17:46 ` Michal Suchanek
2016-06-13 19:57 ` [PATCH v3 00/13] sunxi spi fixes Maxime Ripard
2016-06-13 19:57 ` Maxime Ripard
2016-06-13 19:57 ` Maxime Ripard
2016-06-14 4:50 ` Michal Suchanek
2016-06-14 4:50 ` Michal Suchanek
2016-06-14 4:50 ` Michal Suchanek
2016-06-14 4:50 ` Michal Suchanek
2016-06-14 4:50 ` Michal Suchanek
2016-06-17 10:34 ` Michal Suchanek
2016-06-17 10:34 ` Michal Suchanek
2016-06-17 10:34 ` Michal Suchanek
2016-06-17 10:34 ` Michal Suchanek
2016-06-17 10:34 ` Michal Suchanek
2016-07-25 7:32 ` Maxime Ripard
2016-07-25 7:32 ` Maxime Ripard
2016-07-25 7:32 ` Maxime Ripard
2016-07-25 7:32 ` Maxime Ripard
2016-07-25 7:32 ` Maxime Ripard
2016-07-25 8:03 ` Michal Suchanek
2016-07-25 8:03 ` Michal Suchanek
2016-07-25 8:03 ` Michal Suchanek
2016-07-25 8:03 ` Michal Suchanek
2016-07-25 8:03 ` Michal Suchanek
2016-07-29 20:22 ` Maxime Ripard
2016-07-29 20:22 ` Maxime Ripard
2016-07-29 20:22 ` Maxime Ripard
2016-07-29 20:22 ` Maxime Ripard
2016-07-29 20:22 ` Maxime Ripard
2016-07-30 17:32 ` Michal Suchanek
2016-07-30 17:32 ` Michal Suchanek
2016-07-30 17:32 ` Michal Suchanek
2016-07-30 17:32 ` Michal Suchanek
2016-07-30 17:32 ` Michal Suchanek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160613195601.GC2600@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=arnd@arndb.de \
--cc=b18965@freescale.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=horms+renesas@verge.net.au \
--cc=hramrach@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=info@gerhard-bertelsmann.de \
--cc=javier@osg.samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=net147@gmail.com \
--cc=olof@lixom.net \
--cc=pawel.moll@arm.com \
--cc=plaes@plaes.org \
--cc=public_timo.s@silentcreek.de \
--cc=robh+dt@kernel.org \
--cc=sjoerd.simons@collabora.co.uk \
--cc=stable@vger.kernel.org \
--cc=treding@nvidia.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.