All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] nvme-rdma: don't use IB-CM status code in reject path
@ 2016-06-13  6:53 ` Steve Wise
  0 siblings, 0 replies; 4+ messages in thread
From: Steve Wise @ 2016-06-13  6:53 UTC (permalink / raw)
  To: Christoph Hellwig
  Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA,
	linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Sagi Grimberg

Instead, check the private data length to determine if there
is private data in the reject.

Signed-off-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
---
 drivers/nvme/host/rdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
index 7506431..e1205c0 100644
--- a/drivers/nvme/host/rdma.c
+++ b/drivers/nvme/host/rdma.c
@@ -1208,7 +1208,7 @@ out_destroy_queue_ib:
 static int nvme_rdma_conn_rejected(struct nvme_rdma_queue *queue,
 		struct rdma_cm_event *ev)
 {
-	if (ev->status == IB_CM_REJ_CONSUMER_DEFINED) {
+	if (ev->param.conn.private_data_len) {
 		struct nvme_rdma_cm_rej *rej =
 			(struct nvme_rdma_cm_rej *)ev->param.conn.private_data;
 
-- 
2.7.0

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] nvme-rdma: don't use IB-CM status code in reject path
@ 2016-06-13  6:53 ` Steve Wise
  0 siblings, 0 replies; 4+ messages in thread
From: Steve Wise @ 2016-06-13  6:53 UTC (permalink / raw)


Instead, check the private data length to determine if there
is private data in the reject.

Signed-off-by: Steve Wise <swise at opengridcomputing.com>
---
 drivers/nvme/host/rdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
index 7506431..e1205c0 100644
--- a/drivers/nvme/host/rdma.c
+++ b/drivers/nvme/host/rdma.c
@@ -1208,7 +1208,7 @@ out_destroy_queue_ib:
 static int nvme_rdma_conn_rejected(struct nvme_rdma_queue *queue,
 		struct rdma_cm_event *ev)
 {
-	if (ev->status == IB_CM_REJ_CONSUMER_DEFINED) {
+	if (ev->param.conn.private_data_len) {
 		struct nvme_rdma_cm_rej *rej =
 			(struct nvme_rdma_cm_rej *)ev->param.conn.private_data;
 
-- 
2.7.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] nvme-rdma: don't use IB-CM status code in reject path
  2016-06-13  6:53 ` Steve Wise
@ 2016-06-15 10:28     ` Christoph Hellwig
  -1 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2016-06-15 10:28 UTC (permalink / raw)
  To: Steve Wise
  Cc: Christoph Hellwig, linux-rdma-u79uwXL29TY76Z2rM5mHXA,
	linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Sagi Grimberg

On Sun, Jun 12, 2016 at 11:53:17PM -0700, Steve Wise wrote:
> Instead, check the private data length to determine if there
> is private data in the reject.
> 
> Signed-off-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>

Thanks Steve,

applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] nvme-rdma: don't use IB-CM status code in reject path
@ 2016-06-15 10:28     ` Christoph Hellwig
  0 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2016-06-15 10:28 UTC (permalink / raw)


On Sun, Jun 12, 2016@11:53:17PM -0700, Steve Wise wrote:
> Instead, check the private data length to determine if there
> is private data in the reject.
> 
> Signed-off-by: Steve Wise <swise at opengridcomputing.com>

Thanks Steve,

applied.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-06-15 10:28 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-13  6:53 [PATCH] nvme-rdma: don't use IB-CM status code in reject path Steve Wise
2016-06-13  6:53 ` Steve Wise
     [not found] ` <20160614175333.853CCE0753-/5N3P9jjx0xzbRFIqnYvSA@public.gmane.org>
2016-06-15 10:28   ` Christoph Hellwig
2016-06-15 10:28     ` Christoph Hellwig

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.