All of lore.kernel.org
 help / color / mirror / Atom feed
* [cryptodev:master 47/51] crypto/drbg.c:1637:39-40: Unneeded semicolon
@ 2016-06-15 11:13 kbuild test robot
  2016-06-15 11:13 ` [PATCH] crypto: fix semicolon.cocci warnings kbuild test robot
  0 siblings, 1 reply; 4+ messages in thread
From: kbuild test robot @ 2016-06-15 11:13 UTC (permalink / raw)
  Cc: kbuild-all, linux-crypto, Herbert Xu, Stephan Mueller

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
head:   5a7de97309f5af4458b1a25a2a529a1a893c5269
commit: 355912852115cd8aa4ad02c25182ae615ce925fb [47/51] crypto: drbg - use CTR AES instead of ECB AES


coccinelle warnings: (new ones prefixed by >>)

>> crypto/drbg.c:1637:39-40: Unneeded semicolon

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] crypto: fix semicolon.cocci warnings
  2016-06-15 11:13 [cryptodev:master 47/51] crypto/drbg.c:1637:39-40: Unneeded semicolon kbuild test robot
@ 2016-06-15 11:13 ` kbuild test robot
  2016-06-15 11:40   ` Stephan Mueller
  2016-06-20 11:33   ` Herbert Xu
  0 siblings, 2 replies; 4+ messages in thread
From: kbuild test robot @ 2016-06-15 11:13 UTC (permalink / raw)
  Cc: kbuild-all, linux-crypto, Herbert Xu, Stephan Mueller

crypto/drbg.c:1637:39-40: Unneeded semicolon


 Remove unneeded semicolon.

Generated by: scripts/coccinelle/misc/semicolon.cocci

CC: Stephan Mueller <smueller@chronox.de>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 drbg.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/crypto/drbg.c
+++ b/crypto/drbg.c
@@ -1634,7 +1634,7 @@ static int drbg_fini_sym_kernel(struct d
 	drbg->ctr_handle = NULL;
 
 	if (drbg->ctr_req)
-		skcipher_request_free(drbg->ctr_req);;
+		skcipher_request_free(drbg->ctr_req);
 	drbg->ctr_req = NULL;
 
 	kfree(drbg->ctr_null_value_buf);

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] crypto: fix semicolon.cocci warnings
  2016-06-15 11:13 ` [PATCH] crypto: fix semicolon.cocci warnings kbuild test robot
@ 2016-06-15 11:40   ` Stephan Mueller
  2016-06-20 11:33   ` Herbert Xu
  1 sibling, 0 replies; 4+ messages in thread
From: Stephan Mueller @ 2016-06-15 11:40 UTC (permalink / raw)
  To: kbuild test robot; +Cc: kbuild-all, linux-crypto, Herbert Xu

Am Mittwoch, 15. Juni 2016, 19:13:25 schrieb kbuild test robot:

Hi Fengguang,

> crypto/drbg.c:1637:39-40: Unneeded semicolon
> 
> 
>  Remove unneeded semicolon.

Thank you!

> 
> Generated by: scripts/coccinelle/misc/semicolon.cocci
> 
> CC: Stephan Mueller <smueller@chronox.de>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Acked-by: Stephan Mueller <smueller@chronox.de>
> ---
> 
>  drbg.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/crypto/drbg.c
> +++ b/crypto/drbg.c
> @@ -1634,7 +1634,7 @@ static int drbg_fini_sym_kernel(struct d
>  	drbg->ctr_handle = NULL;
> 
>  	if (drbg->ctr_req)
> -		skcipher_request_free(drbg->ctr_req);;
> +		skcipher_request_free(drbg->ctr_req);
>  	drbg->ctr_req = NULL;
> 
>  	kfree(drbg->ctr_null_value_buf);


Ciao
Stephan

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] crypto: fix semicolon.cocci warnings
  2016-06-15 11:13 ` [PATCH] crypto: fix semicolon.cocci warnings kbuild test robot
  2016-06-15 11:40   ` Stephan Mueller
@ 2016-06-20 11:33   ` Herbert Xu
  1 sibling, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2016-06-20 11:33 UTC (permalink / raw)
  To: kbuild test robot; +Cc: kbuild-all, linux-crypto, Stephan Mueller

On Wed, Jun 15, 2016 at 07:13:25PM +0800, kbuild test robot wrote:
> crypto/drbg.c:1637:39-40: Unneeded semicolon
> 
> 
>  Remove unneeded semicolon.
> 
> Generated by: scripts/coccinelle/misc/semicolon.cocci
> 
> CC: Stephan Mueller <smueller@chronox.de>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-06-20 12:04 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-15 11:13 [cryptodev:master 47/51] crypto/drbg.c:1637:39-40: Unneeded semicolon kbuild test robot
2016-06-15 11:13 ` [PATCH] crypto: fix semicolon.cocci warnings kbuild test robot
2016-06-15 11:40   ` Stephan Mueller
2016-06-20 11:33   ` Herbert Xu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.