From: Michal Hocko <mhocko@kernel.org> To: zhongjiang <zhongjiang@huawei.com> Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: fix account pmd page to the process Date: Thu, 16 Jun 2016 17:42:15 +0200 [thread overview] Message-ID: <20160616154214.GA12284@dhcp22.suse.cz> (raw) In-Reply-To: <1466076971-24609-1-git-send-email-zhongjiang@huawei.com> On Thu 16-06-16 19:36:11, zhongjiang wrote: > From: zhong jiang <zhongjiang@huawei.com> > > when a process acquire a pmd table shared by other process, we > increase the account to current process. otherwise, a race result > in other tasks have set the pud entry. so it no need to increase it. > > Signed-off-by: zhong jiang <zhongjiang@huawei.com> > --- > mm/hugetlb.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 19d0d08..3b025c5 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -4189,10 +4189,9 @@ pte_t *huge_pmd_share(struct mm_struct *mm, unsigned long addr, pud_t *pud) > if (pud_none(*pud)) { > pud_populate(mm, pud, > (pmd_t *)((unsigned long)spte & PAGE_MASK)); > - } else { > + } else > put_page(virt_to_page(spte)); > - mm_inc_nr_pmds(mm); > - } The code is quite puzzling but is this correct? Shouldn't we rather do mm_dec_nr_pmds(mm) in that path to undo the previous inc? > + > spin_unlock(ptl); > out: > pte = (pte_t *)pmd_alloc(mm, pud, addr); > -- > 1.8.3.1 -- Michal Hocko SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org> To: zhongjiang <zhongjiang@huawei.com> Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: fix account pmd page to the process Date: Thu, 16 Jun 2016 17:42:15 +0200 [thread overview] Message-ID: <20160616154214.GA12284@dhcp22.suse.cz> (raw) In-Reply-To: <1466076971-24609-1-git-send-email-zhongjiang@huawei.com> On Thu 16-06-16 19:36:11, zhongjiang wrote: > From: zhong jiang <zhongjiang@huawei.com> > > when a process acquire a pmd table shared by other process, we > increase the account to current process. otherwise, a race result > in other tasks have set the pud entry. so it no need to increase it. > > Signed-off-by: zhong jiang <zhongjiang@huawei.com> > --- > mm/hugetlb.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 19d0d08..3b025c5 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -4189,10 +4189,9 @@ pte_t *huge_pmd_share(struct mm_struct *mm, unsigned long addr, pud_t *pud) > if (pud_none(*pud)) { > pud_populate(mm, pud, > (pmd_t *)((unsigned long)spte & PAGE_MASK)); > - } else { > + } else > put_page(virt_to_page(spte)); > - mm_inc_nr_pmds(mm); > - } The code is quite puzzling but is this correct? Shouldn't we rather do mm_dec_nr_pmds(mm) in that path to undo the previous inc? > + > spin_unlock(ptl); > out: > pte = (pte_t *)pmd_alloc(mm, pud, addr); > -- > 1.8.3.1 -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-06-16 15:42 UTC|newest] Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-06-16 11:36 [PATCH] mm: fix account pmd page to the process zhongjiang 2016-06-16 11:36 ` zhongjiang 2016-06-16 15:42 ` Michal Hocko [this message] 2016-06-16 15:42 ` Michal Hocko 2016-06-16 15:43 ` Michal Hocko 2016-06-16 15:43 ` Michal Hocko 2016-06-16 16:05 ` Mike Kravetz 2016-06-16 16:05 ` Mike Kravetz 2016-06-16 16:31 ` Michal Hocko 2016-06-16 16:31 ` Michal Hocko 2016-06-16 16:47 ` Mike Kravetz 2016-06-16 16:47 ` Mike Kravetz 2016-06-17 12:25 ` Kirill A. Shutemov 2016-06-17 12:25 ` Kirill A. Shutemov 2016-06-17 13:00 ` Michal Hocko 2016-06-17 13:00 ` Michal Hocko 2016-06-17 14:25 ` Kirill A. Shutemov 2016-06-17 14:25 ` Kirill A. Shutemov 2016-06-17 15:39 ` Mike Kravetz 2016-06-17 15:39 ` Mike Kravetz 2016-06-18 5:07 ` zhong jiang 2016-06-18 5:07 ` zhong jiang 2016-06-17 11:18 ` zhong jiang 2016-06-17 11:18 ` zhong jiang [not found] <1466163941-12952-1-git-send-email-zhongjiang@huawei.com> 2016-06-17 12:01 ` zhong jiang 2016-06-17 12:01 ` zhong jiang -- strict thread matches above, loose matches on Subject: below -- 2016-06-17 11:56 zhongjiang 2016-06-17 11:56 ` zhongjiang 2016-06-17 12:21 ` Michal Hocko 2016-06-17 12:21 ` Michal Hocko 2016-06-17 13:04 ` zhong jiang 2016-06-17 13:04 ` zhong jiang [not found] <1466076175-23444-1-git-send-email-zhongjiang@huawei.com> 2016-06-16 11:30 ` zhong jiang 2016-06-16 11:30 ` zhong jiang 2016-06-16 11:28 zhongjiang 2016-06-16 11:28 ` zhongjiang 2016-06-16 11:17 zhongjiang 2016-06-16 11:17 ` zhongjiang 2016-06-16 11:16 zhongjiang 2016-06-16 11:16 ` zhongjiang 2016-06-16 11:13 zhongjiang 2016-06-16 11:13 ` zhongjiang 2016-06-16 7:47 zhongjiang 2016-06-16 7:47 ` zhongjiang 2016-06-15 14:48 zhongjiang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160616154214.GA12284@dhcp22.suse.cz \ --to=mhocko@kernel.org \ --cc=akpm@linux-foundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=zhongjiang@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.