From: Michal Hocko <mhocko@kernel.org>
To: "Odzioba, Lukasz" <lukasz.odzioba@intel.com>
Cc: "Hansen, Dave" <dave.hansen@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"kirill.shutemov@linux.intel.com"
<kirill.shutemov@linux.intel.com>,
"aarcange@redhat.com" <aarcange@redhat.com>,
"vdavydov@parallels.com" <vdavydov@parallels.com>,
"mingli199x@qq.com" <mingli199x@qq.com>,
"minchan@kernel.org" <minchan@kernel.org>,
"Anaczkowski, Lukasz" <lukasz.anaczkowski@intel.com>,
"Shutemov, Kirill" <kirill.shutemov@intel.com>
Subject: Re: [PATCH 1/1] mm/swap.c: flush lru_add pvecs on compound page arrival
Date: Thu, 16 Jun 2016 20:19:12 +0200 [thread overview]
Message-ID: <20160616181912.GQ6836@dhcp22.suse.cz> (raw)
In-Reply-To: <D6EDEBF1F91015459DB866AC4EE162CC023FB491@IRSMSX103.ger.corp.intel.com>
On Thu 16-06-16 18:08:57, Odzioba, Lukasz wrote:
> On Thru 09-06-16 02:22 PM Michal Hocko wrote:
> > I agree it would be better to do the same for others as well. Even if
> > this is not an immediate problem for those.
>
> I am not able to find clear reasons why we shouldn't do it for the rest.
> Ok so what do we do now? I'll send v2 with proposed changes.
> Then do we still want to have stats on those pvecs?
> In my opinion it's not worth it now.
I think the fix has a higher priority - we also want to backport it to
stable trees IMO. We can discuss the stats and how to present them
later.
--
Michal Hocko
SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org>
To: "Odzioba, Lukasz" <lukasz.odzioba@intel.com>
Cc: "Hansen, Dave" <dave.hansen@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"kirill.shutemov@linux.intel.com"
<kirill.shutemov@linux.intel.com>,
"aarcange@redhat.com" <aarcange@redhat.com>,
"vdavydov@parallels.com" <vdavydov@parallels.com>,
"mingli199x@qq.com" <mingli199x@qq.com>,
"minchan@kernel.org" <minchan@kernel.org>,
"Anaczkowski, Lukasz" <lukasz.anaczkowski@intel.com>,
"Shutemov, Kirill" <kirill.shutemov@intel.com>
Subject: Re: [PATCH 1/1] mm/swap.c: flush lru_add pvecs on compound page arrival
Date: Thu, 16 Jun 2016 20:19:12 +0200 [thread overview]
Message-ID: <20160616181912.GQ6836@dhcp22.suse.cz> (raw)
In-Reply-To: <D6EDEBF1F91015459DB866AC4EE162CC023FB491@IRSMSX103.ger.corp.intel.com>
On Thu 16-06-16 18:08:57, Odzioba, Lukasz wrote:
> On Thru 09-06-16 02:22 PM Michal Hocko wrote:
> > I agree it would be better to do the same for others as well. Even if
> > this is not an immediate problem for those.
>
> I am not able to find clear reasons why we shouldn't do it for the rest.
> Ok so what do we do now? I'll send v2 with proposed changes.
> Then do we still want to have stats on those pvecs?
> In my opinion it's not worth it now.
I think the fix has a higher priority - we also want to backport it to
stable trees IMO. We can discuss the stats and how to present them
later.
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-06-16 18:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 14:35 [PATCH 1/1] mm/swap.c: flush lru_add pvecs on compound page arrival Lukasz Odzioba
2016-06-08 14:35 ` Lukasz Odzioba
2016-06-08 15:04 ` Michal Hocko
2016-06-08 15:04 ` Michal Hocko
2016-06-09 8:01 ` Odzioba, Lukasz
2016-06-09 8:01 ` Odzioba, Lukasz
2016-06-08 15:31 ` Dave Hansen
2016-06-08 15:31 ` Dave Hansen
2016-06-08 16:06 ` Michal Hocko
2016-06-08 16:06 ` Michal Hocko
2016-06-08 16:34 ` Dave Hansen
2016-06-08 16:34 ` Dave Hansen
2016-06-09 12:21 ` Michal Hocko
2016-06-09 12:21 ` Michal Hocko
2016-06-16 18:08 ` Odzioba, Lukasz
2016-06-16 18:08 ` Odzioba, Lukasz
2016-06-16 18:19 ` Michal Hocko [this message]
2016-06-16 18:19 ` Michal Hocko
2016-06-16 20:03 ` Odzioba, Lukasz
2016-06-16 20:03 ` Odzioba, Lukasz
2016-06-09 8:50 ` Odzioba, Lukasz
2016-06-09 8:50 ` Odzioba, Lukasz
2016-06-09 15:41 ` Dave Hansen
2016-06-09 15:41 ` Dave Hansen
2016-06-13 21:01 ` Odzioba, Lukasz
2016-06-13 21:01 ` Odzioba, Lukasz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160616181912.GQ6836@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=kirill.shutemov@intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lukasz.anaczkowski@intel.com \
--cc=lukasz.odzioba@intel.com \
--cc=minchan@kernel.org \
--cc=mingli199x@qq.com \
--cc=vdavydov@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.