From: Mark Brown <broonie@kernel.org>
To: Andi Shyti <andi.shyti@samsung.com>
Cc: Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Andi Shyti <andi@etezian.org>
Subject: Re: [PATCH 1/5] spi: do not fail if the CS line is not connected
Date: Fri, 17 Jun 2016 11:47:25 +0100 [thread overview]
Message-ID: <20160617104725.GC26099@sirena.org.uk> (raw)
In-Reply-To: <1466150245-2648-2-git-send-email-andi.shyti@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 527 bytes --]
On Fri, Jun 17, 2016 at 04:57:21PM +0900, Andi Shyti wrote:
> Some SPI connected devices do not have any CS line connected as
> some devices are alway enabled. Indeed, until now, a common
> workaround was to assign to num_chipselect a -1 value or 255
> (num_chipselect is unsigned).
>
> In this case do not fail and defer to the SPI device drivers the
> responsibility to check whether the num-cs is '0'.
A SPI controller always has one chip seelct, it may not be controllable
but it's at least logically present.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Andi Shyti <andi.shyti-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Cc: Kukjin Kim <kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Krzysztof Kozlowski
<k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Andi Shyti <andi-ahk0KpmfxKRAfugRpC6u6w@public.gmane.org>
Subject: Re: [PATCH 1/5] spi: do not fail if the CS line is not connected
Date: Fri, 17 Jun 2016 11:47:25 +0100 [thread overview]
Message-ID: <20160617104725.GC26099@sirena.org.uk> (raw)
In-Reply-To: <1466150245-2648-2-git-send-email-andi.shyti-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 527 bytes --]
On Fri, Jun 17, 2016 at 04:57:21PM +0900, Andi Shyti wrote:
> Some SPI connected devices do not have any CS line connected as
> some devices are alway enabled. Indeed, until now, a common
> workaround was to assign to num_chipselect a -1 value or 255
> (num_chipselect is unsigned).
>
> In this case do not fail and defer to the SPI device drivers the
> responsibility to check whether the num-cs is '0'.
A SPI controller always has one chip seelct, it may not be controllable
but it's at least logically present.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] spi: do not fail if the CS line is not connected
Date: Fri, 17 Jun 2016 11:47:25 +0100 [thread overview]
Message-ID: <20160617104725.GC26099@sirena.org.uk> (raw)
In-Reply-To: <1466150245-2648-2-git-send-email-andi.shyti@samsung.com>
On Fri, Jun 17, 2016 at 04:57:21PM +0900, Andi Shyti wrote:
> Some SPI connected devices do not have any CS line connected as
> some devices are alway enabled. Indeed, until now, a common
> workaround was to assign to num_chipselect a -1 value or 255
> (num_chipselect is unsigned).
>
> In this case do not fail and defer to the SPI device drivers the
> responsibility to check whether the num-cs is '0'.
A SPI controller always has one chip seelct, it may not be controllable
but it's at least logically present.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160617/ac3e4287/attachment.sig>
next prev parent reply other threads:[~2016-06-17 10:47 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 7:57 [PATCH 0/5] SPI CS line logical change and s3c64xx code rework Andi Shyti
2016-06-17 7:57 ` Andi Shyti
2016-06-17 7:57 ` Andi Shyti
2016-06-17 7:57 ` [PATCH 1/5] spi: do not fail if the CS line is not connected Andi Shyti
2016-06-17 7:57 ` Andi Shyti
2016-06-17 7:57 ` Andi Shyti
2016-06-17 10:47 ` Mark Brown [this message]
2016-06-17 10:47 ` Mark Brown
2016-06-17 10:47 ` Mark Brown
2016-06-17 11:36 ` Andi Shyti
2016-06-17 11:36 ` Andi Shyti
2016-06-17 12:28 ` Mark Brown
2016-06-17 12:28 ` Mark Brown
2016-06-17 12:28 ` Mark Brown
2016-06-19 6:09 ` Andi Shyti
2016-06-19 6:09 ` Andi Shyti
2016-06-19 6:09 ` Andi Shyti
2016-06-26 12:48 ` Mark Brown
2016-06-26 12:48 ` Mark Brown
2016-06-26 12:48 ` Mark Brown
2016-06-27 10:57 ` Andi Shyti
2016-06-27 10:57 ` Andi Shyti
2016-06-27 10:57 ` Andi Shyti
2016-06-27 13:06 ` Mark Brown
2016-06-27 13:06 ` Mark Brown
2016-06-27 14:08 ` Andi Shyti
2016-06-27 14:08 ` Andi Shyti
2016-06-27 14:08 ` Andi Shyti
2016-06-17 7:57 ` [PATCH 2/5] spi: s3c64xx: group the CS signalling writes in a single function Andi Shyti
2016-06-17 7:57 ` Andi Shyti
2016-06-17 7:57 ` Andi Shyti
2016-06-30 12:15 ` Applied "spi: s3c64xx: group the CS signalling writes in a single function" to the spi tree Mark Brown
2016-06-30 12:15 ` Mark Brown
2016-06-17 7:57 ` [PATCH 3/5] spi: s3c64xx: consider the case where the CS line is not connected Andi Shyti
2016-06-17 7:57 ` Andi Shyti
2016-06-17 7:57 ` [PATCH 4/5] spi: s3c64xx: do not configure the device twice Andi Shyti
2016-06-17 7:57 ` Andi Shyti
2016-06-17 7:57 ` Andi Shyti
2016-06-30 12:15 ` Applied "spi: s3c64xx: do not configure the device twice" to the spi tree Mark Brown
2016-06-30 12:15 ` Mark Brown
2016-06-17 7:57 ` [PATCH 5/5] spi: s3c63xx: simplify if statement in prepare_transfer function Andi Shyti
2016-06-17 7:57 ` Andi Shyti
2016-06-17 7:57 ` Andi Shyti
2016-06-30 12:15 ` Applied "spi: s3c64xx: simplify if statement in prepare_transfer function" to the spi tree Mark Brown
2016-06-30 12:15 ` Mark Brown
2016-06-30 12:15 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160617104725.GC26099@sirena.org.uk \
--to=broonie@kernel.org \
--cc=andi.shyti@samsung.com \
--cc=andi@etezian.org \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.