* [PATCH] drm/i915: Limit i915_ring_test_irq debugfs to actual rings
@ 2016-06-17 13:35 Chris Wilson
2016-06-17 14:16 ` ✗ Ro.CI.BAT: warning for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Chris Wilson @ 2016-06-17 13:35 UTC (permalink / raw)
To: intel-gfx; +Cc: Mika Kuoppala
For simplicity in testing, only report known rings in the mask. This
allows userspace to try and trigger a missed irq on every ring and do a
comparison between i915_ring_test_irq and i915_ring_missed_irq to see if
any rings failed.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@intel.com>
---
drivers/gpu/drm/i915/i915_debugfs.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index 3da36db9c830..1da821479161 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -4615,17 +4615,10 @@ i915_ring_test_irq_set(void *data, u64 val)
{
struct drm_device *dev = data;
struct drm_i915_private *dev_priv = dev->dev_private;
- int ret;
DRM_DEBUG_DRIVER("Masking interrupts on rings 0x%08llx\n", val);
-
- /* Lock against concurrent debugfs callers */
- ret = mutex_lock_interruptible(&dev->struct_mutex);
- if (ret)
- return ret;
-
+ val &= INTEL_INFO(dev_priv)->ring_mask;
dev_priv->gpu_error.test_irq_rings = val;
- mutex_unlock(&dev->struct_mutex);
return 0;
}
--
2.8.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* ✗ Ro.CI.BAT: warning for drm/i915: Limit i915_ring_test_irq debugfs to actual rings
2016-06-17 13:35 [PATCH] drm/i915: Limit i915_ring_test_irq debugfs to actual rings Chris Wilson
@ 2016-06-17 14:16 ` Patchwork
2016-06-21 13:26 ` [PATCH] " Chris Wilson
2016-07-04 8:53 ` Mika Kuoppala
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2016-06-17 14:16 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Limit i915_ring_test_irq debugfs to actual rings
URL : https://patchwork.freedesktop.org/series/8833/
State : warning
== Summary ==
Series 8833v1 drm/i915: Limit i915_ring_test_irq debugfs to actual rings
http://patchwork.freedesktop.org/api/1.0/series/8833/revisions/1/mbox
Test kms_pipe_crc_basic:
Subgroup nonblocking-crc-pipe-b:
pass -> SKIP (fi-skl-i5-6260u)
Subgroup suspend-read-crc-pipe-b:
skip -> DMESG-WARN (ro-bdw-i5-5250u)
Subgroup suspend-read-crc-pipe-c:
skip -> DMESG-WARN (ro-bdw-i5-5250u)
fi-skl-i5-6260u total:213 pass:200 dwarn:1 dfail:0 fail:0 skip:12
fi-skl-i7-6700k total:213 pass:187 dwarn:1 dfail:0 fail:0 skip:25
fi-snb-i7-2600 total:213 pass:173 dwarn:1 dfail:0 fail:0 skip:39
ro-bdw-i5-5250u total:213 pass:196 dwarn:4 dfail:0 fail:0 skip:13
ro-bdw-i7-5557U total:213 pass:197 dwarn:1 dfail:0 fail:0 skip:15
ro-bdw-i7-5600u total:213 pass:184 dwarn:1 dfail:0 fail:0 skip:28
ro-byt-n2820 total:213 pass:172 dwarn:1 dfail:0 fail:3 skip:37
ro-hsw-i3-4010u total:213 pass:189 dwarn:1 dfail:0 fail:0 skip:23
ro-hsw-i7-4770r total:213 pass:189 dwarn:1 dfail:0 fail:0 skip:23
ro-ilk-i7-620lm total:213 pass:149 dwarn:1 dfail:0 fail:1 skip:62
ro-ilk1-i5-650 total:208 pass:149 dwarn:1 dfail:0 fail:1 skip:57
ro-ivb-i7-3770 total:213 pass:180 dwarn:1 dfail:0 fail:0 skip:32
ro-ivb2-i7-3770 total:213 pass:184 dwarn:1 dfail:0 fail:0 skip:28
ro-skl3-i5-6260u total:213 pass:201 dwarn:1 dfail:0 fail:0 skip:11
ro-snb-i7-2620M total:213 pass:173 dwarn:1 dfail:0 fail:1 skip:38
fi-hsw-i7-4770k failed to connect after reboot
ro-bsw-n3050 failed to connect after reboot
Results at /archive/results/CI_IGT_test/RO_Patchwork_1212/
011c1da drm-intel-nightly: 2016y-06m-17d-13h-33m-01s UTC integration manifest
64ba27a drm/i915: Limit i915_ring_test_irq debugfs to actual rings
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: Limit i915_ring_test_irq debugfs to actual rings
2016-06-17 13:35 [PATCH] drm/i915: Limit i915_ring_test_irq debugfs to actual rings Chris Wilson
2016-06-17 14:16 ` ✗ Ro.CI.BAT: warning for " Patchwork
@ 2016-06-21 13:26 ` Chris Wilson
2016-07-04 8:53 ` Mika Kuoppala
2 siblings, 0 replies; 5+ messages in thread
From: Chris Wilson @ 2016-06-21 13:26 UTC (permalink / raw)
To: intel-gfx; +Cc: Mika Kuoppala
On Fri, Jun 17, 2016 at 02:35:05PM +0100, Chris Wilson wrote:
> For simplicity in testing, only report known rings in the mask. This
> allows userspace to try and trigger a missed irq on every ring and do a
> comparison between i915_ring_test_irq and i915_ring_missed_irq to see if
> any rings failed.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@intel.com>
Ping?
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: Limit i915_ring_test_irq debugfs to actual rings
2016-06-17 13:35 [PATCH] drm/i915: Limit i915_ring_test_irq debugfs to actual rings Chris Wilson
2016-06-17 14:16 ` ✗ Ro.CI.BAT: warning for " Patchwork
2016-06-21 13:26 ` [PATCH] " Chris Wilson
@ 2016-07-04 8:53 ` Mika Kuoppala
2016-07-04 9:35 ` Chris Wilson
2 siblings, 1 reply; 5+ messages in thread
From: Mika Kuoppala @ 2016-07-04 8:53 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
Chris Wilson <chris@chris-wilson.co.uk> writes:
> For simplicity in testing, only report known rings in the mask. This
> allows userspace to try and trigger a missed irq on every ring and do a
> comparison between i915_ring_test_irq and i915_ring_missed_irq to see if
> any rings failed.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@intel.com>
> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index 3da36db9c830..1da821479161 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -4615,17 +4615,10 @@ i915_ring_test_irq_set(void *data, u64 val)
> {
> struct drm_device *dev = data;
> struct drm_i915_private *dev_priv = dev->dev_private;
> - int ret;
>
> DRM_DEBUG_DRIVER("Masking interrupts on rings 0x%08llx\n", val);
Moving this dbg message past masking would make more sense?
Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com>
> -
> - /* Lock against concurrent debugfs callers */
> - ret = mutex_lock_interruptible(&dev->struct_mutex);
> - if (ret)
> - return ret;
> -
> + val &= INTEL_INFO(dev_priv)->ring_mask;
> dev_priv->gpu_error.test_irq_rings = val;
> - mutex_unlock(&dev->struct_mutex);
>
> return 0;
> }
> --
> 2.8.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: Limit i915_ring_test_irq debugfs to actual rings
2016-07-04 8:53 ` Mika Kuoppala
@ 2016-07-04 9:35 ` Chris Wilson
0 siblings, 0 replies; 5+ messages in thread
From: Chris Wilson @ 2016-07-04 9:35 UTC (permalink / raw)
To: Mika Kuoppala; +Cc: intel-gfx
On Mon, Jul 04, 2016 at 11:53:01AM +0300, Mika Kuoppala wrote:
> Chris Wilson <chris@chris-wilson.co.uk> writes:
> > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> > index 3da36db9c830..1da821479161 100644
> > --- a/drivers/gpu/drm/i915/i915_debugfs.c
> > +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> > @@ -4615,17 +4615,10 @@ i915_ring_test_irq_set(void *data, u64 val)
> > {
> > struct drm_device *dev = data;
> > struct drm_i915_private *dev_priv = dev->dev_private;
> > - int ret;
> >
> > DRM_DEBUG_DRIVER("Masking interrupts on rings 0x%08llx\n", val);
>
> Moving this dbg message past masking would make more sense?
Yes, it does. Done and pushed.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-07-04 9:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-17 13:35 [PATCH] drm/i915: Limit i915_ring_test_irq debugfs to actual rings Chris Wilson
2016-06-17 14:16 ` ✗ Ro.CI.BAT: warning for " Patchwork
2016-06-21 13:26 ` [PATCH] " Chris Wilson
2016-07-04 8:53 ` Mika Kuoppala
2016-07-04 9:35 ` Chris Wilson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.