All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ganesh Mahendran <opensource.ganesh@gmail.com>
To: Vlastimil Babka <vbabka@suse.cz>, akpm@linux-foundation.org
Cc: Michal Hocko <mhocko@kernel.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	iamjoonsoo.kim@lge.com, hillf.zj@alibaba-inc.com,
	minchan@kernel.org
Subject: Re: [PATCH] mm/compaction: remove local variable is_lru
Date: Sat, 18 Jun 2016 09:48:41 +0800	[thread overview]
Message-ID: <20160618014841.GA7422@leo-test> (raw)
In-Reply-To: <fbcd77c3-b192-3415-8417-6c8b07ce2146@suse.cz>

On Fri, Jun 17, 2016 at 02:50:12PM +0200, Vlastimil Babka wrote:
> On 06/17/2016 11:50 AM, Michal Hocko wrote:
> >On Fri 17-06-16 17:32:51, Ganesh Mahendran wrote:
> >>local varialbe is_lru was used for tracking non-lru pages(such as
> >>balloon pages).
> >>
> >>But commit
> >>112ea7b668d3 ("mm: migrate: support non-lru movable page migration")
> >
> >this commit sha is not stable because it is from the linux-next tree.
> >
> >>introduced a common framework for non-lru page migration and moved
> >>the compound pages check before non-lru movable pages check.
> >>
> >>So there is no need to use local variable is_lru.
> >>
> >>Signed-off-by: Ganesh Mahendran <opensource.ganesh@gmail.com>
> >
> >Other than that the patch looks ok and maybe it would be worth folding
> >into the mm-migrate-support-non-lru-movable-page-migration.patch
> 
> Agreed.

Thanks.

Hi, Andrew:

Please help to fold this patch into:
mm-migrate-support-non-lru-movable-page-migration.patch

---

      reply	other threads:[~2016-06-18  1:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-17  9:32 [PATCH] mm/compaction: remove local variable is_lru Ganesh Mahendran
2016-06-17  9:32 ` Ganesh Mahendran
2016-06-17  9:49 ` Hillf Danton
2016-06-17  9:49   ` Hillf Danton
2016-06-17  9:50 ` Michal Hocko
2016-06-17  9:50   ` Michal Hocko
2016-06-17 12:50   ` Vlastimil Babka
2016-06-17 12:50     ` Vlastimil Babka
2016-06-18  1:48     ` Ganesh Mahendran [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160618014841.GA7422@leo-test \
    --to=opensource.ganesh@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=hillf.zj@alibaba-inc.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=minchan@kernel.org \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.