From: Michal Hocko <mhocko@kernel.org> To: Ganesh Mahendran <opensource.ganesh@gmail.com> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, vbabka@suse.cz, iamjoonsoo.kim@lge.com, hillf.zj@alibaba-inc.com, minchan@kernel.org Subject: Re: [PATCH] mm/compaction: remove local variable is_lru Date: Fri, 17 Jun 2016 11:50:31 +0200 [thread overview] Message-ID: <20160617095030.GB21670@dhcp22.suse.cz> (raw) In-Reply-To: <1466155971-6280-1-git-send-email-opensource.ganesh@gmail.com> On Fri 17-06-16 17:32:51, Ganesh Mahendran wrote: > local varialbe is_lru was used for tracking non-lru pages(such as > balloon pages). > > But commit > 112ea7b668d3 ("mm: migrate: support non-lru movable page migration") this commit sha is not stable because it is from the linux-next tree. > introduced a common framework for non-lru page migration and moved > the compound pages check before non-lru movable pages check. > > So there is no need to use local variable is_lru. > > Signed-off-by: Ganesh Mahendran <opensource.ganesh@gmail.com> Other than that the patch looks ok and maybe it would be worth folding into the mm-migrate-support-non-lru-movable-page-migration.patch > --- > mm/compaction.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index fbb7b38..780be7f 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -724,7 +724,6 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn, > > /* Time to isolate some pages for migration */ > for (; low_pfn < end_pfn; low_pfn++) { > - bool is_lru; > > if (skip_on_failure && low_pfn >= next_skip_pfn) { > /* > @@ -807,8 +806,7 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn, > * It's possible to migrate LRU and non-lru movable pages. > * Skip any other type of page > */ > - is_lru = PageLRU(page); > - if (!is_lru) { > + if (!PageLRU(page)) { > /* > * __PageMovable can return false positive so we need > * to verify it under page_lock. > -- > 1.9.1 > -- Michal Hocko SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org> To: Ganesh Mahendran <opensource.ganesh@gmail.com> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, vbabka@suse.cz, iamjoonsoo.kim@lge.com, hillf.zj@alibaba-inc.com, minchan@kernel.org Subject: Re: [PATCH] mm/compaction: remove local variable is_lru Date: Fri, 17 Jun 2016 11:50:31 +0200 [thread overview] Message-ID: <20160617095030.GB21670@dhcp22.suse.cz> (raw) In-Reply-To: <1466155971-6280-1-git-send-email-opensource.ganesh@gmail.com> On Fri 17-06-16 17:32:51, Ganesh Mahendran wrote: > local varialbe is_lru was used for tracking non-lru pages(such as > balloon pages). > > But commit > 112ea7b668d3 ("mm: migrate: support non-lru movable page migration") this commit sha is not stable because it is from the linux-next tree. > introduced a common framework for non-lru page migration and moved > the compound pages check before non-lru movable pages check. > > So there is no need to use local variable is_lru. > > Signed-off-by: Ganesh Mahendran <opensource.ganesh@gmail.com> Other than that the patch looks ok and maybe it would be worth folding into the mm-migrate-support-non-lru-movable-page-migration.patch > --- > mm/compaction.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index fbb7b38..780be7f 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -724,7 +724,6 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn, > > /* Time to isolate some pages for migration */ > for (; low_pfn < end_pfn; low_pfn++) { > - bool is_lru; > > if (skip_on_failure && low_pfn >= next_skip_pfn) { > /* > @@ -807,8 +806,7 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn, > * It's possible to migrate LRU and non-lru movable pages. > * Skip any other type of page > */ > - is_lru = PageLRU(page); > - if (!is_lru) { > + if (!PageLRU(page)) { > /* > * __PageMovable can return false positive so we need > * to verify it under page_lock. > -- > 1.9.1 > -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-06-17 9:50 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-06-17 9:32 [PATCH] mm/compaction: remove local variable is_lru Ganesh Mahendran 2016-06-17 9:32 ` Ganesh Mahendran 2016-06-17 9:49 ` Hillf Danton 2016-06-17 9:49 ` Hillf Danton 2016-06-17 9:50 ` Michal Hocko [this message] 2016-06-17 9:50 ` Michal Hocko 2016-06-17 12:50 ` Vlastimil Babka 2016-06-17 12:50 ` Vlastimil Babka 2016-06-18 1:48 ` Ganesh Mahendran
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160617095030.GB21670@dhcp22.suse.cz \ --to=mhocko@kernel.org \ --cc=akpm@linux-foundation.org \ --cc=hillf.zj@alibaba-inc.com \ --cc=iamjoonsoo.kim@lge.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=minchan@kernel.org \ --cc=opensource.ganesh@gmail.com \ --cc=vbabka@suse.cz \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.