* [PATCH] THP: Fix comments of __pmd_trans_huge_lock
@ 2016-06-17 21:46 ` Huang, Ying
0 siblings, 0 replies; 4+ messages in thread
From: Huang, Ying @ 2016-06-17 21:46 UTC (permalink / raw)
To: Kirill A . Shutemov
Cc: Huang Ying, Andrew Morton, Vlastimil Babka, Jerome Marchand,
Andrea Arcangeli, Ebru Akagunduz, linux-mm, linux-kernel
From: Huang Ying <ying.huang@intel.com>
To make the comments consistent with the already changed code.
Signed-off-by: "Huang, Ying" <ying.huang@intel.com>
---
mm/huge_memory.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index 2ad52d5..641ca27 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -1824,10 +1824,10 @@ int change_huge_pmd(struct vm_area_struct *vma, pmd_t *pmd,
}
/*
- * Returns true if a given pmd maps a thp, false otherwise.
+ * Returns page table lock pointer if a given pmd maps a thp, NULL otherwise.
*
- * Note that if it returns true, this routine returns without unlocking page
- * table lock. So callers must unlock it.
+ * Note that if it returns page table lock pointer, this routine returns without
+ * unlocking page table lock. So callers must unlock it.
*/
spinlock_t *__pmd_trans_huge_lock(pmd_t *pmd, struct vm_area_struct *vma)
{
--
2.8.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] THP: Fix comments of __pmd_trans_huge_lock
@ 2016-06-17 21:46 ` Huang, Ying
0 siblings, 0 replies; 4+ messages in thread
From: Huang, Ying @ 2016-06-17 21:46 UTC (permalink / raw)
To: Kirill A . Shutemov
Cc: Huang Ying, Andrew Morton, Vlastimil Babka, Jerome Marchand,
Andrea Arcangeli, Ebru Akagunduz, linux-mm, linux-kernel
From: Huang Ying <ying.huang@intel.com>
To make the comments consistent with the already changed code.
Signed-off-by: "Huang, Ying" <ying.huang@intel.com>
---
mm/huge_memory.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index 2ad52d5..641ca27 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -1824,10 +1824,10 @@ int change_huge_pmd(struct vm_area_struct *vma, pmd_t *pmd,
}
/*
- * Returns true if a given pmd maps a thp, false otherwise.
+ * Returns page table lock pointer if a given pmd maps a thp, NULL otherwise.
*
- * Note that if it returns true, this routine returns without unlocking page
- * table lock. So callers must unlock it.
+ * Note that if it returns page table lock pointer, this routine returns without
+ * unlocking page table lock. So callers must unlock it.
*/
spinlock_t *__pmd_trans_huge_lock(pmd_t *pmd, struct vm_area_struct *vma)
{
--
2.8.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] THP: Fix comments of __pmd_trans_huge_lock
2016-06-17 21:46 ` Huang, Ying
@ 2016-06-20 8:27 ` Kirill A. Shutemov
-1 siblings, 0 replies; 4+ messages in thread
From: Kirill A. Shutemov @ 2016-06-20 8:27 UTC (permalink / raw)
To: Huang, Ying
Cc: Kirill A . Shutemov, Andrew Morton, Vlastimil Babka,
Jerome Marchand, Andrea Arcangeli, Ebru Akagunduz, linux-mm,
linux-kernel
On Fri, Jun 17, 2016 at 02:46:36PM -0700, Huang, Ying wrote:
> From: Huang Ying <ying.huang@intel.com>
>
> To make the comments consistent with the already changed code.
>
> Signed-off-by: "Huang, Ying" <ying.huang@intel.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
--
Kirill A. Shutemov
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] THP: Fix comments of __pmd_trans_huge_lock
@ 2016-06-20 8:27 ` Kirill A. Shutemov
0 siblings, 0 replies; 4+ messages in thread
From: Kirill A. Shutemov @ 2016-06-20 8:27 UTC (permalink / raw)
To: Huang, Ying
Cc: Kirill A . Shutemov, Andrew Morton, Vlastimil Babka,
Jerome Marchand, Andrea Arcangeli, Ebru Akagunduz, linux-mm,
linux-kernel
On Fri, Jun 17, 2016 at 02:46:36PM -0700, Huang, Ying wrote:
> From: Huang Ying <ying.huang@intel.com>
>
> To make the comments consistent with the already changed code.
>
> Signed-off-by: "Huang, Ying" <ying.huang@intel.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-06-20 8:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-17 21:46 [PATCH] THP: Fix comments of __pmd_trans_huge_lock Huang, Ying
2016-06-17 21:46 ` Huang, Ying
2016-06-20 8:27 ` Kirill A. Shutemov
2016-06-20 8:27 ` Kirill A. Shutemov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.