* [PATCH] arm64: dts: r8a7795: Add CAN FD support
@ 2016-03-01 10:04 ` Ramesh Shanmugasundaram
0 siblings, 0 replies; 18+ messages in thread
From: Ramesh Shanmugasundaram @ 2016-03-01 10:04 UTC (permalink / raw)
To: mkl-bIcnvbaLZ9MEGnE8C9+IrQ, wg-5Yr1BZd7O62+XT7JhA+gdA,
horms-/R6kz+dDXgpPR4JQBCEnsQ, magnus.damm-Re5JQEeQqe8AvxtiuMwx3w,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ
Cc: linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-can-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
chris.paterson2-zM6kxYcvzFBBDgjK7y7TUQ, Ramesh Shanmugasundaram
Adds CAN FD controller node for r8a7795.
Note: CAN FD controller register base address specified in R-Car Gen3
Hardware User Manual v0.5E is incorrect. The correct address is:
CAN FD - 0xe66c0000
Signed-off-by: Ramesh Shanmugasundaram <ramesh.shanmugasundaram-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
---
Hi All,
This patch is based on linux-next (tag:next-20160225) with the following
patches applied on top.
[PATCH v2] arm64: dts: r8a7795: Add CAN external clock support
[PATCH] arm64: dts: r8a7795: Add CAN support
The respective CAN subsystem changes are submitted separately here (https://www.mail-archive.com/linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org/msg01388.html)
Thanks,
Ramesh
---
arch/arm64/boot/dts/renesas/r8a7795.dtsi | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index a88f8d8..5049ba6 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -553,6 +553,30 @@
status = "disabled";
};
+ canfd: canfd@e66c0000 {
+ compatible = "renesas,r8a7795-canfd",
+ "renesas,rcar-gen3-canfd";
+ reg = <0 0xe66c0000 0 0x8000>;
+ interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 914>,
+ <&cpg CPG_CORE R8A7795_CLK_CANFD>,
+ <&can_clk>;
+ clock-names = "fck", "canfd", "can_clk";
+ assigned-clocks = <&cpg CPG_CORE R8A7795_CLK_CANFD>;
+ assigned-clock-rates = <40000000>;
+ power-domains = <&cpg>;
+ status = "disabled";
+
+ channel0 {
+ status = "disabled";
+ };
+
+ channel1 {
+ status = "disabled";
+ };
+ };
+
hscif0: serial@e6540000 {
compatible = "renesas,hscif-r8a7795",
"renesas,rcar-gen3-hscif",
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH] arm64: dts: r8a7795: Add CAN FD support
@ 2016-03-01 10:04 ` Ramesh Shanmugasundaram
0 siblings, 0 replies; 18+ messages in thread
From: Ramesh Shanmugasundaram @ 2016-03-01 10:04 UTC (permalink / raw)
To: mkl, wg, horms, magnus.damm, robh+dt, pawel.moll, mark.rutland,
ijc+devicetree, galak
Cc: linux-renesas-soc, devicetree, linux-can, linux-arm-kernel,
chris.paterson2, Ramesh Shanmugasundaram
Adds CAN FD controller node for r8a7795.
Note: CAN FD controller register base address specified in R-Car Gen3
Hardware User Manual v0.5E is incorrect. The correct address is:
CAN FD - 0xe66c0000
Signed-off-by: Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>
---
Hi All,
This patch is based on linux-next (tag:next-20160225) with the following
patches applied on top.
[PATCH v2] arm64: dts: r8a7795: Add CAN external clock support
[PATCH] arm64: dts: r8a7795: Add CAN support
The respective CAN subsystem changes are submitted separately here (https://www.mail-archive.com/linux-renesas-soc@vger.kernel.org/msg01388.html)
Thanks,
Ramesh
---
arch/arm64/boot/dts/renesas/r8a7795.dtsi | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index a88f8d8..5049ba6 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -553,6 +553,30 @@
status = "disabled";
};
+ canfd: canfd@e66c0000 {
+ compatible = "renesas,r8a7795-canfd",
+ "renesas,rcar-gen3-canfd";
+ reg = <0 0xe66c0000 0 0x8000>;
+ interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 914>,
+ <&cpg CPG_CORE R8A7795_CLK_CANFD>,
+ <&can_clk>;
+ clock-names = "fck", "canfd", "can_clk";
+ assigned-clocks = <&cpg CPG_CORE R8A7795_CLK_CANFD>;
+ assigned-clock-rates = <40000000>;
+ power-domains = <&cpg>;
+ status = "disabled";
+
+ channel0 {
+ status = "disabled";
+ };
+
+ channel1 {
+ status = "disabled";
+ };
+ };
+
hscif0: serial@e6540000 {
compatible = "renesas,hscif-r8a7795",
"renesas,rcar-gen3-hscif",
--
1.9.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH] arm64: dts: r8a7795: Add CAN FD support
@ 2016-03-01 10:04 ` Ramesh Shanmugasundaram
0 siblings, 0 replies; 18+ messages in thread
From: Ramesh Shanmugasundaram @ 2016-03-01 10:04 UTC (permalink / raw)
To: linux-arm-kernel
Adds CAN FD controller node for r8a7795.
Note: CAN FD controller register base address specified in R-Car Gen3
Hardware User Manual v0.5E is incorrect. The correct address is:
CAN FD - 0xe66c0000
Signed-off-by: Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>
---
Hi All,
This patch is based on linux-next (tag:next-20160225) with the following
patches applied on top.
[PATCH v2] arm64: dts: r8a7795: Add CAN external clock support
[PATCH] arm64: dts: r8a7795: Add CAN support
The respective CAN subsystem changes are submitted separately here (https://www.mail-archive.com/linux-renesas-soc at vger.kernel.org/msg01388.html)
Thanks,
Ramesh
---
arch/arm64/boot/dts/renesas/r8a7795.dtsi | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index a88f8d8..5049ba6 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -553,6 +553,30 @@
status = "disabled";
};
+ canfd: canfd at e66c0000 {
+ compatible = "renesas,r8a7795-canfd",
+ "renesas,rcar-gen3-canfd";
+ reg = <0 0xe66c0000 0 0x8000>;
+ interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 914>,
+ <&cpg CPG_CORE R8A7795_CLK_CANFD>,
+ <&can_clk>;
+ clock-names = "fck", "canfd", "can_clk";
+ assigned-clocks = <&cpg CPG_CORE R8A7795_CLK_CANFD>;
+ assigned-clock-rates = <40000000>;
+ power-domains = <&cpg>;
+ status = "disabled";
+
+ channel0 {
+ status = "disabled";
+ };
+
+ channel1 {
+ status = "disabled";
+ };
+ };
+
hscif0: serial at e6540000 {
compatible = "renesas,hscif-r8a7795",
"renesas,rcar-gen3-hscif",
--
1.9.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH] arm64: dts: r8a7795: Add CAN FD support
2016-03-01 10:04 ` Ramesh Shanmugasundaram
@ 2016-03-01 13:12 ` Sergei Shtylyov
-1 siblings, 0 replies; 18+ messages in thread
From: Sergei Shtylyov @ 2016-03-01 13:12 UTC (permalink / raw)
To: Ramesh Shanmugasundaram, mkl, wg, horms, magnus.damm, robh+dt,
pawel.moll, mark.rutland, ijc+devicetree, galak
Cc: linux-renesas-soc, devicetree, linux-can, linux-arm-kernel,
chris.paterson2
Hello.
On 3/1/2016 1:04 PM, Ramesh Shanmugasundaram wrote:
> Adds CAN FD controller node for r8a7795.
>
> Note: CAN FD controller register base address specified in R-Car Gen3
> Hardware User Manual v0.5E is incorrect. The correct address is:
>
> CAN FD - 0xe66c0000
>
> Signed-off-by: Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>
> ---
> Hi All,
>
> This patch is based on linux-next (tag:next-20160225) with the following
> patches applied on top.
>
> [PATCH v2] arm64: dts: r8a7795: Add CAN external clock support
> [PATCH] arm64: dts: r8a7795: Add CAN support
>
> The respective CAN subsystem changes are submitted separately here (https://www.mail-archive.com/linux-renesas-soc@vger.kernel.org/msg01388.html)
>
> Thanks,
> Ramesh
> ---
> arch/arm64/boot/dts/renesas/r8a7795.dtsi | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> index a88f8d8..5049ba6 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> @@ -553,6 +553,30 @@
> status = "disabled";
> };
>
> + canfd: canfd@e66c0000 {
The node name should still be "can@e66c0000", I think.
MBR, Sergei
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] arm64: dts: r8a7795: Add CAN FD support
@ 2016-03-01 13:12 ` Sergei Shtylyov
0 siblings, 0 replies; 18+ messages in thread
From: Sergei Shtylyov @ 2016-03-01 13:12 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 3/1/2016 1:04 PM, Ramesh Shanmugasundaram wrote:
> Adds CAN FD controller node for r8a7795.
>
> Note: CAN FD controller register base address specified in R-Car Gen3
> Hardware User Manual v0.5E is incorrect. The correct address is:
>
> CAN FD - 0xe66c0000
>
> Signed-off-by: Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>
> ---
> Hi All,
>
> This patch is based on linux-next (tag:next-20160225) with the following
> patches applied on top.
>
> [PATCH v2] arm64: dts: r8a7795: Add CAN external clock support
> [PATCH] arm64: dts: r8a7795: Add CAN support
>
> The respective CAN subsystem changes are submitted separately here (https://www.mail-archive.com/linux-renesas-soc at vger.kernel.org/msg01388.html)
>
> Thanks,
> Ramesh
> ---
> arch/arm64/boot/dts/renesas/r8a7795.dtsi | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> index a88f8d8..5049ba6 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> @@ -553,6 +553,30 @@
> status = "disabled";
> };
>
> + canfd: canfd at e66c0000 {
The node name should still be "can at e66c0000", I think.
MBR, Sergei
^ permalink raw reply [flat|nested] 18+ messages in thread
* RE: [PATCH] arm64: dts: r8a7795: Add CAN FD support
2016-03-01 13:12 ` Sergei Shtylyov
@ 2016-03-02 7:29 ` Ramesh Shanmugasundaram
-1 siblings, 0 replies; 18+ messages in thread
From: Ramesh Shanmugasundaram @ 2016-03-02 7:29 UTC (permalink / raw)
To: Sergei Shtylyov, mkl, wg, horms, magnus.damm, robh+dt,
pawel.moll, mark.rutland, ijc+devicetree, galak
Cc: linux-renesas-soc, devicetree, linux-can, linux-arm-kernel,
Chris Paterson
Hi Sergei,
> On 3/1/2016 1:04 PM, Ramesh Shanmugasundaram wrote:
>
> > Adds CAN FD controller node for r8a7795.
> >
> > Note: CAN FD controller register base address specified in R-Car Gen3
> > Hardware User Manual v0.5E is incorrect. The correct address is:
> >
> > CAN FD - 0xe66c0000
> >
> > Signed-off-by: Ramesh Shanmugasundaram
> > <ramesh.shanmugasundaram@bp.renesas.com>
> > ---
> > Hi All,
> >
> > This patch is based on linux-next (tag:next-20160225) with the
> following
> > patches applied on top.
> >
> > [PATCH v2] arm64: dts: r8a7795: Add CAN external clock support
> > [PATCH] arm64: dts: r8a7795: Add CAN support
> >
> > The respective CAN subsystem changes are submitted separately here
> > (https://www.mail-archive.com/linux-renesas-soc@vger.kernel.org/msg013
> > 88.html)
> >
> > Thanks,
> > Ramesh
> > ---
> > arch/arm64/boot/dts/renesas/r8a7795.dtsi | 24 ++++++++++++++++++++++++
> > 1 file changed, 24 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> > b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> > index a88f8d8..5049ba6 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> > @@ -553,6 +553,30 @@
> > status = "disabled";
> > };
> >
> > + canfd: canfd@e66c0000 {
>
> The node name should still be "can@e66c0000", I think.
Thanks for the review.
The SoC has CAN controller too and hence I chose this node name to differentiate. A grep of canfd on sysfs would tell if the controller is enabled. The channels on "net" would still be named "canx".
I'll change it if you still feel "can@e66c0000" is more appropriate.
Thanks,
Ramesh
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] arm64: dts: r8a7795: Add CAN FD support
@ 2016-03-02 7:29 ` Ramesh Shanmugasundaram
0 siblings, 0 replies; 18+ messages in thread
From: Ramesh Shanmugasundaram @ 2016-03-02 7:29 UTC (permalink / raw)
To: linux-arm-kernel
Hi Sergei,
> On 3/1/2016 1:04 PM, Ramesh Shanmugasundaram wrote:
>
> > Adds CAN FD controller node for r8a7795.
> >
> > Note: CAN FD controller register base address specified in R-Car Gen3
> > Hardware User Manual v0.5E is incorrect. The correct address is:
> >
> > CAN FD - 0xe66c0000
> >
> > Signed-off-by: Ramesh Shanmugasundaram
> > <ramesh.shanmugasundaram@bp.renesas.com>
> > ---
> > Hi All,
> >
> > This patch is based on linux-next (tag:next-20160225) with the
> following
> > patches applied on top.
> >
> > [PATCH v2] arm64: dts: r8a7795: Add CAN external clock support
> > [PATCH] arm64: dts: r8a7795: Add CAN support
> >
> > The respective CAN subsystem changes are submitted separately here
> > (https://www.mail-archive.com/linux-renesas-soc at vger.kernel.org/msg013
> > 88.html)
> >
> > Thanks,
> > Ramesh
> > ---
> > arch/arm64/boot/dts/renesas/r8a7795.dtsi | 24 ++++++++++++++++++++++++
> > 1 file changed, 24 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> > b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> > index a88f8d8..5049ba6 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> > @@ -553,6 +553,30 @@
> > status = "disabled";
> > };
> >
> > + canfd: canfd at e66c0000 {
>
> The node name should still be "can at e66c0000", I think.
Thanks for the review.
The SoC has CAN controller too and hence I chose this node name to differentiate. A grep of canfd on sysfs would tell if the controller is enabled. The channels on "net" would still be named "canx".
I'll change it if you still feel "can at e66c0000" is more appropriate.
Thanks,
Ramesh
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] arm64: dts: r8a7795: Add CAN FD support
2016-03-02 7:29 ` Ramesh Shanmugasundaram
@ 2016-03-02 7:53 ` Simon Horman
-1 siblings, 0 replies; 18+ messages in thread
From: Simon Horman @ 2016-03-02 7:53 UTC (permalink / raw)
To: Ramesh Shanmugasundaram
Cc: Sergei Shtylyov, mkl, wg, magnus.damm, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, linux-renesas-soc,
devicetree, linux-can, linux-arm-kernel, Chris Paterson
On Wed, Mar 02, 2016 at 07:29:04AM +0000, Ramesh Shanmugasundaram wrote:
> Hi Sergei,
>
> > On 3/1/2016 1:04 PM, Ramesh Shanmugasundaram wrote:
> >
> > > Adds CAN FD controller node for r8a7795.
> > >
> > > Note: CAN FD controller register base address specified in R-Car Gen3
> > > Hardware User Manual v0.5E is incorrect. The correct address is:
> > >
> > > CAN FD - 0xe66c0000
> > >
> > > Signed-off-by: Ramesh Shanmugasundaram
> > > <ramesh.shanmugasundaram@bp.renesas.com>
> > > ---
> > > Hi All,
> > >
> > > This patch is based on linux-next (tag:next-20160225) with the
> > following
> > > patches applied on top.
> > >
> > > [PATCH v2] arm64: dts: r8a7795: Add CAN external clock support
> > > [PATCH] arm64: dts: r8a7795: Add CAN support
> > >
> > > The respective CAN subsystem changes are submitted separately here
> > > (https://www.mail-archive.com/linux-renesas-soc@vger.kernel.org/msg013
> > > 88.html)
> > >
> > > Thanks,
> > > Ramesh
> > > ---
> > > arch/arm64/boot/dts/renesas/r8a7795.dtsi | 24 ++++++++++++++++++++++++
> > > 1 file changed, 24 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> > > b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> > > index a88f8d8..5049ba6 100644
> > > --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> > > +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> > > @@ -553,6 +553,30 @@
> > > status = "disabled";
> > > };
> > >
> > > + canfd: canfd@e66c0000 {
> >
> > The node name should still be "can@e66c0000", I think.
>
> Thanks for the review.
>
> The SoC has CAN controller too and hence I chose this node name to differentiate. A grep of canfd on sysfs would tell if the controller is enabled. The channels on "net" would still be named "canx".
>
> I'll change it if you still feel "can@e66c0000" is more appropriate.
FWIW, "can@e66c0000" seems more appropriate to me.
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] arm64: dts: r8a7795: Add CAN FD support
@ 2016-03-02 7:53 ` Simon Horman
0 siblings, 0 replies; 18+ messages in thread
From: Simon Horman @ 2016-03-02 7:53 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Mar 02, 2016 at 07:29:04AM +0000, Ramesh Shanmugasundaram wrote:
> Hi Sergei,
>
> > On 3/1/2016 1:04 PM, Ramesh Shanmugasundaram wrote:
> >
> > > Adds CAN FD controller node for r8a7795.
> > >
> > > Note: CAN FD controller register base address specified in R-Car Gen3
> > > Hardware User Manual v0.5E is incorrect. The correct address is:
> > >
> > > CAN FD - 0xe66c0000
> > >
> > > Signed-off-by: Ramesh Shanmugasundaram
> > > <ramesh.shanmugasundaram@bp.renesas.com>
> > > ---
> > > Hi All,
> > >
> > > This patch is based on linux-next (tag:next-20160225) with the
> > following
> > > patches applied on top.
> > >
> > > [PATCH v2] arm64: dts: r8a7795: Add CAN external clock support
> > > [PATCH] arm64: dts: r8a7795: Add CAN support
> > >
> > > The respective CAN subsystem changes are submitted separately here
> > > (https://www.mail-archive.com/linux-renesas-soc at vger.kernel.org/msg013
> > > 88.html)
> > >
> > > Thanks,
> > > Ramesh
> > > ---
> > > arch/arm64/boot/dts/renesas/r8a7795.dtsi | 24 ++++++++++++++++++++++++
> > > 1 file changed, 24 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> > > b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> > > index a88f8d8..5049ba6 100644
> > > --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> > > +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> > > @@ -553,6 +553,30 @@
> > > status = "disabled";
> > > };
> > >
> > > + canfd: canfd at e66c0000 {
> >
> > The node name should still be "can at e66c0000", I think.
>
> Thanks for the review.
>
> The SoC has CAN controller too and hence I chose this node name to differentiate. A grep of canfd on sysfs would tell if the controller is enabled. The channels on "net" would still be named "canx".
>
> I'll change it if you still feel "can at e66c0000" is more appropriate.
FWIW, "can at e66c0000" seems more appropriate to me.
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v2] arm64: dts: r8a7795: Add CAN FD support
2016-03-01 10:04 ` Ramesh Shanmugasundaram
(?)
@ 2016-03-02 8:15 ` Ramesh Shanmugasundaram
-1 siblings, 0 replies; 18+ messages in thread
From: Ramesh Shanmugasundaram @ 2016-03-02 8:15 UTC (permalink / raw)
To: mkl-bIcnvbaLZ9MEGnE8C9+IrQ, wg-5Yr1BZd7O62+XT7JhA+gdA,
horms-/R6kz+dDXgpPR4JQBCEnsQ, magnus.damm-Re5JQEeQqe8AvxtiuMwx3w,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ
Cc: linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-can-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
chris.paterson2-zM6kxYcvzFBBDgjK7y7TUQ, Ramesh Shanmugasundaram
Adds CAN FD controller node for r8a7795.
Note: CAN FD controller register base address specified in R-Car Gen3
Hardware User Manual v0.5E is incorrect. The correct address is:
CAN FD - 0xe66c0000
Signed-off-by: Ramesh Shanmugasundaram <ramesh.shanmugasundaram-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
---
Thanks Sergei, Simon for the comments.
Changes since v1:
As suggested by Sergei, Simon
* Changed node name from canfd@ to can@
---
arch/arm64/boot/dts/renesas/r8a7795.dtsi | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index a88f8d8..9185688 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -553,6 +553,30 @@
status = "disabled";
};
+ canfd: can@e66c0000 {
+ compatible = "renesas,r8a7795-canfd",
+ "renesas,rcar-gen3-canfd";
+ reg = <0 0xe66c0000 0 0x8000>;
+ interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 914>,
+ <&cpg CPG_CORE R8A7795_CLK_CANFD>,
+ <&can_clk>;
+ clock-names = "fck", "canfd", "can_clk";
+ assigned-clocks = <&cpg CPG_CORE R8A7795_CLK_CANFD>;
+ assigned-clock-rates = <40000000>;
+ power-domains = <&cpg>;
+ status = "disabled";
+
+ channel0 {
+ status = "disabled";
+ };
+
+ channel1 {
+ status = "disabled";
+ };
+ };
+
hscif0: serial@e6540000 {
compatible = "renesas,hscif-r8a7795",
"renesas,rcar-gen3-hscif",
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v2] arm64: dts: r8a7795: Add CAN FD support
@ 2016-03-02 8:15 ` Ramesh Shanmugasundaram
0 siblings, 0 replies; 18+ messages in thread
From: Ramesh Shanmugasundaram @ 2016-03-02 8:15 UTC (permalink / raw)
To: mkl, wg, horms, magnus.damm, robh+dt, pawel.moll, mark.rutland,
ijc+devicetree, galak
Cc: linux-renesas-soc, devicetree, linux-can, linux-arm-kernel,
chris.paterson2, Ramesh Shanmugasundaram
Adds CAN FD controller node for r8a7795.
Note: CAN FD controller register base address specified in R-Car Gen3
Hardware User Manual v0.5E is incorrect. The correct address is:
CAN FD - 0xe66c0000
Signed-off-by: Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>
---
Thanks Sergei, Simon for the comments.
Changes since v1:
As suggested by Sergei, Simon
* Changed node name from canfd@ to can@
---
arch/arm64/boot/dts/renesas/r8a7795.dtsi | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index a88f8d8..9185688 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -553,6 +553,30 @@
status = "disabled";
};
+ canfd: can@e66c0000 {
+ compatible = "renesas,r8a7795-canfd",
+ "renesas,rcar-gen3-canfd";
+ reg = <0 0xe66c0000 0 0x8000>;
+ interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 914>,
+ <&cpg CPG_CORE R8A7795_CLK_CANFD>,
+ <&can_clk>;
+ clock-names = "fck", "canfd", "can_clk";
+ assigned-clocks = <&cpg CPG_CORE R8A7795_CLK_CANFD>;
+ assigned-clock-rates = <40000000>;
+ power-domains = <&cpg>;
+ status = "disabled";
+
+ channel0 {
+ status = "disabled";
+ };
+
+ channel1 {
+ status = "disabled";
+ };
+ };
+
hscif0: serial@e6540000 {
compatible = "renesas,hscif-r8a7795",
"renesas,rcar-gen3-hscif",
--
1.9.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v2] arm64: dts: r8a7795: Add CAN FD support
@ 2016-03-02 8:15 ` Ramesh Shanmugasundaram
0 siblings, 0 replies; 18+ messages in thread
From: Ramesh Shanmugasundaram @ 2016-03-02 8:15 UTC (permalink / raw)
To: linux-arm-kernel
Adds CAN FD controller node for r8a7795.
Note: CAN FD controller register base address specified in R-Car Gen3
Hardware User Manual v0.5E is incorrect. The correct address is:
CAN FD - 0xe66c0000
Signed-off-by: Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>
---
Thanks Sergei, Simon for the comments.
Changes since v1:
As suggested by Sergei, Simon
* Changed node name from canfd@ to can@
---
arch/arm64/boot/dts/renesas/r8a7795.dtsi | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index a88f8d8..9185688 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -553,6 +553,30 @@
status = "disabled";
};
+ canfd: can at e66c0000 {
+ compatible = "renesas,r8a7795-canfd",
+ "renesas,rcar-gen3-canfd";
+ reg = <0 0xe66c0000 0 0x8000>;
+ interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 914>,
+ <&cpg CPG_CORE R8A7795_CLK_CANFD>,
+ <&can_clk>;
+ clock-names = "fck", "canfd", "can_clk";
+ assigned-clocks = <&cpg CPG_CORE R8A7795_CLK_CANFD>;
+ assigned-clock-rates = <40000000>;
+ power-domains = <&cpg>;
+ status = "disabled";
+
+ channel0 {
+ status = "disabled";
+ };
+
+ channel1 {
+ status = "disabled";
+ };
+ };
+
hscif0: serial at e6540000 {
compatible = "renesas,hscif-r8a7795",
"renesas,rcar-gen3-hscif",
--
1.9.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH] arm64: dts: r8a7795: Add CAN FD support
2016-03-02 7:29 ` Ramesh Shanmugasundaram
@ 2016-03-02 12:03 ` Sergei Shtylyov
-1 siblings, 0 replies; 18+ messages in thread
From: Sergei Shtylyov @ 2016-03-02 12:03 UTC (permalink / raw)
To: Ramesh Shanmugasundaram, mkl, wg, horms, magnus.damm, robh+dt,
pawel.moll, mark.rutland, ijc+devicetree, galak
Cc: linux-renesas-soc, devicetree, linux-can, linux-arm-kernel,
Chris Paterson
Hello.
On 3/2/2016 10:29 AM, Ramesh Shanmugasundaram wrote:
>>> Adds CAN FD controller node for r8a7795.
>>>
>>> Note: CAN FD controller register base address specified in R-Car Gen3
>>> Hardware User Manual v0.5E is incorrect. The correct address is:
>>>
>>> CAN FD - 0xe66c0000
>>>
>>> Signed-off-by: Ramesh Shanmugasundaram
>>> <ramesh.shanmugasundaram@bp.renesas.com>
>>> ---
>>> Hi All,
>>>
>>> This patch is based on linux-next (tag:next-20160225) with the
>> following
>>> patches applied on top.
>>>
>>> [PATCH v2] arm64: dts: r8a7795: Add CAN external clock support
>>> [PATCH] arm64: dts: r8a7795: Add CAN support
>>>
>>> The respective CAN subsystem changes are submitted separately here
>>> (https://www.mail-archive.com/linux-renesas-soc@vger.kernel.org/msg013
>>> 88.html)
>>>
>>> Thanks,
>>> Ramesh
>>> ---
>>> arch/arm64/boot/dts/renesas/r8a7795.dtsi | 24 ++++++++++++++++++++++++
>>> 1 file changed, 24 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>> b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>> index a88f8d8..5049ba6 100644
>>> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>> @@ -553,6 +553,30 @@
>>> status = "disabled";
>>> };
>>>
>>> + canfd: canfd@e66c0000 {
>>
>> The node name should still be "can@e66c0000", I think.
>
> Thanks for the review.
>
> The SoC has CAN controller too
Yes, I figured. BTW, is the CAN-FD identical to the older CAN on the
hardware level? I haven't see you posting the CAN-FD driver yet...
> and hence I chose this node name to differentiate. A grep of canfd on sysfs would tell if the controller is enabled. The channels on "net" would still be named "canx".
>
> I'll change it if you still feel "can@e66c0000" is more appropriate.
It is -- the node names should be generic and ePAPR even has the "can"
name listed explicitly in the section 2.2.2.
> Thanks,
> Ramesh
MBR, Sergei
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] arm64: dts: r8a7795: Add CAN FD support
@ 2016-03-02 12:03 ` Sergei Shtylyov
0 siblings, 0 replies; 18+ messages in thread
From: Sergei Shtylyov @ 2016-03-02 12:03 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 3/2/2016 10:29 AM, Ramesh Shanmugasundaram wrote:
>>> Adds CAN FD controller node for r8a7795.
>>>
>>> Note: CAN FD controller register base address specified in R-Car Gen3
>>> Hardware User Manual v0.5E is incorrect. The correct address is:
>>>
>>> CAN FD - 0xe66c0000
>>>
>>> Signed-off-by: Ramesh Shanmugasundaram
>>> <ramesh.shanmugasundaram@bp.renesas.com>
>>> ---
>>> Hi All,
>>>
>>> This patch is based on linux-next (tag:next-20160225) with the
>> following
>>> patches applied on top.
>>>
>>> [PATCH v2] arm64: dts: r8a7795: Add CAN external clock support
>>> [PATCH] arm64: dts: r8a7795: Add CAN support
>>>
>>> The respective CAN subsystem changes are submitted separately here
>>> (https://www.mail-archive.com/linux-renesas-soc at vger.kernel.org/msg013
>>> 88.html)
>>>
>>> Thanks,
>>> Ramesh
>>> ---
>>> arch/arm64/boot/dts/renesas/r8a7795.dtsi | 24 ++++++++++++++++++++++++
>>> 1 file changed, 24 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>> b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>> index a88f8d8..5049ba6 100644
>>> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>> @@ -553,6 +553,30 @@
>>> status = "disabled";
>>> };
>>>
>>> + canfd: canfd at e66c0000 {
>>
>> The node name should still be "can at e66c0000", I think.
>
> Thanks for the review.
>
> The SoC has CAN controller too
Yes, I figured. BTW, is the CAN-FD identical to the older CAN on the
hardware level? I haven't see you posting the CAN-FD driver yet...
> and hence I chose this node name to differentiate. A grep of canfd on sysfs would tell if the controller is enabled. The channels on "net" would still be named "canx".
>
> I'll change it if you still feel "can at e66c0000" is more appropriate.
It is -- the node names should be generic and ePAPR even has the "can"
name listed explicitly in the section 2.2.2.
> Thanks,
> Ramesh
MBR, Sergei
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v3] arm64: dts: r8a7795: Add CAN FD support
2016-03-02 8:15 ` Ramesh Shanmugasundaram
@ 2016-06-17 12:35 ` Ramesh Shanmugasundaram
-1 siblings, 0 replies; 18+ messages in thread
From: Ramesh Shanmugasundaram @ 2016-06-17 12:35 UTC (permalink / raw)
To: horms, magnus.damm
Cc: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
linux-renesas-soc, linux-arm-kernel, devicetree, chris.paterson2,
Ramesh Shanmugasundaram
Adds CAN FD controller node for r8a7795.
Note: CAN FD controller register base address specified in R-Car Gen3
Hardware User Manual v0.5E is incorrect. The correct address is:
CAN FD - 0xe66c0000
Signed-off-by: Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>
---
Note:
Bindings already Acked-by: Rob H on driver patch set
(https://www.mail-archive.com/netdev@vger.kernel.org/msg102789.html)
Changes since v2:
Rebased to Simon's latest tag:renesas-devel-20160616-v4.7-rc3
Changes since v1:
As suggested by Sergei, Simon - changed node name from canfd@ to can@
---
arch/arm64/boot/dts/renesas/r8a7795.dtsi | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index fad6dd8..b902356 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -583,6 +583,30 @@
status = "disabled";
};
+ canfd: can@e66c0000 {
+ compatible = "renesas,r8a7795-canfd",
+ "renesas,rcar-gen3-canfd";
+ reg = <0 0xe66c0000 0 0x8000>;
+ interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 914>,
+ <&cpg CPG_CORE R8A7795_CLK_CANFD>,
+ <&can_clk>;
+ clock-names = "fck", "canfd", "can_clk";
+ assigned-clocks = <&cpg CPG_CORE R8A7795_CLK_CANFD>;
+ assigned-clock-rates = <40000000>;
+ power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;
+ status = "disabled";
+
+ channel0 {
+ status = "disabled";
+ };
+
+ channel1 {
+ status = "disabled";
+ };
+ };
+
hscif0: serial@e6540000 {
compatible = "renesas,hscif-r8a7795",
"renesas,rcar-gen3-hscif",
--
1.9.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v3] arm64: dts: r8a7795: Add CAN FD support
@ 2016-06-17 12:35 ` Ramesh Shanmugasundaram
0 siblings, 0 replies; 18+ messages in thread
From: Ramesh Shanmugasundaram @ 2016-06-17 12:35 UTC (permalink / raw)
To: linux-arm-kernel
Adds CAN FD controller node for r8a7795.
Note: CAN FD controller register base address specified in R-Car Gen3
Hardware User Manual v0.5E is incorrect. The correct address is:
CAN FD - 0xe66c0000
Signed-off-by: Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>
---
Note:
Bindings already Acked-by: Rob H on driver patch set
(https://www.mail-archive.com/netdev at vger.kernel.org/msg102789.html)
Changes since v2:
Rebased to Simon's latest tag:renesas-devel-20160616-v4.7-rc3
Changes since v1:
As suggested by Sergei, Simon - changed node name from canfd@ to can@
---
arch/arm64/boot/dts/renesas/r8a7795.dtsi | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index fad6dd8..b902356 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -583,6 +583,30 @@
status = "disabled";
};
+ canfd: can at e66c0000 {
+ compatible = "renesas,r8a7795-canfd",
+ "renesas,rcar-gen3-canfd";
+ reg = <0 0xe66c0000 0 0x8000>;
+ interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 914>,
+ <&cpg CPG_CORE R8A7795_CLK_CANFD>,
+ <&can_clk>;
+ clock-names = "fck", "canfd", "can_clk";
+ assigned-clocks = <&cpg CPG_CORE R8A7795_CLK_CANFD>;
+ assigned-clock-rates = <40000000>;
+ power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;
+ status = "disabled";
+
+ channel0 {
+ status = "disabled";
+ };
+
+ channel1 {
+ status = "disabled";
+ };
+ };
+
hscif0: serial at e6540000 {
compatible = "renesas,hscif-r8a7795",
"renesas,rcar-gen3-hscif",
--
1.9.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH v3] arm64: dts: r8a7795: Add CAN FD support
2016-06-17 12:35 ` Ramesh Shanmugasundaram
@ 2016-06-21 1:38 ` Simon Horman
-1 siblings, 0 replies; 18+ messages in thread
From: Simon Horman @ 2016-06-21 1:38 UTC (permalink / raw)
To: Ramesh Shanmugasundaram
Cc: magnus.damm, robh+dt, pawel.moll, mark.rutland, ijc+devicetree,
galak, linux-renesas-soc, linux-arm-kernel, devicetree,
chris.paterson2
On Fri, Jun 17, 2016 at 01:35:43PM +0100, Ramesh Shanmugasundaram wrote:
> Adds CAN FD controller node for r8a7795.
>
> Note: CAN FD controller register base address specified in R-Car Gen3
> Hardware User Manual v0.5E is incorrect. The correct address is:
>
> CAN FD - 0xe66c0000
>
> Signed-off-by: Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>
> ---
>
> Note:
> Bindings already Acked-by: Rob H on driver patch set
> (https://www.mail-archive.com/netdev@vger.kernel.org/msg102789.html)
Thanks, I have queued this up.
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v3] arm64: dts: r8a7795: Add CAN FD support
@ 2016-06-21 1:38 ` Simon Horman
0 siblings, 0 replies; 18+ messages in thread
From: Simon Horman @ 2016-06-21 1:38 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jun 17, 2016 at 01:35:43PM +0100, Ramesh Shanmugasundaram wrote:
> Adds CAN FD controller node for r8a7795.
>
> Note: CAN FD controller register base address specified in R-Car Gen3
> Hardware User Manual v0.5E is incorrect. The correct address is:
>
> CAN FD - 0xe66c0000
>
> Signed-off-by: Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>
> ---
>
> Note:
> Bindings already Acked-by: Rob H on driver patch set
> (https://www.mail-archive.com/netdev at vger.kernel.org/msg102789.html)
Thanks, I have queued this up.
^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2016-06-21 1:38 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-01 10:04 [PATCH] arm64: dts: r8a7795: Add CAN FD support Ramesh Shanmugasundaram
2016-03-01 10:04 ` Ramesh Shanmugasundaram
2016-03-01 10:04 ` Ramesh Shanmugasundaram
2016-03-01 13:12 ` Sergei Shtylyov
2016-03-01 13:12 ` Sergei Shtylyov
2016-03-02 7:29 ` Ramesh Shanmugasundaram
2016-03-02 7:29 ` Ramesh Shanmugasundaram
2016-03-02 7:53 ` Simon Horman
2016-03-02 7:53 ` Simon Horman
2016-03-02 12:03 ` Sergei Shtylyov
2016-03-02 12:03 ` Sergei Shtylyov
[not found] ` <1456826640-23237-1-git-send-email-ramesh.shanmugasundaram-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
2016-03-02 8:15 ` [PATCH v2] " Ramesh Shanmugasundaram
2016-03-02 8:15 ` Ramesh Shanmugasundaram
2016-03-02 8:15 ` Ramesh Shanmugasundaram
2016-06-17 12:35 ` [PATCH v3] " Ramesh Shanmugasundaram
2016-06-17 12:35 ` Ramesh Shanmugasundaram
2016-06-21 1:38 ` Simon Horman
2016-06-21 1:38 ` Simon Horman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.