From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Mike Turquette <mturquette@baylibre.com>,
Chen-Yu Tsai <wens@csie.org>,
linux-clk@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>,
Andre Przywara <andre.przywara@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Vishnu Patekar <vishnupatekar0510@gmail.com>,
linux-arm-kernel@lists.infradead.org,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Jean-Francois Moine <moinejf@free.fr>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 04/15] clk: sunxi-ng: Add fixed factor clock support
Date: Tue, 21 Jun 2016 11:24:13 +0200 [thread overview]
Message-ID: <20160621092413.GP26668@lukather> (raw)
In-Reply-To: <20160621011537.GP1521@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 921 bytes --]
Hi Stephen,
On Mon, Jun 20, 2016 at 06:15:37PM -0700, Stephen Boyd wrote:
> On 06/07, Maxime Ripard wrote:
> > +
> > +#include <linux/clk-provider.h>
> > +
> > +#include "ccu_common.h"
> > +
> > +struct ccu_fixed_factor {
> > + u16 div;
> > + u16 mult;
> > +
> > + struct ccu_common common;
>
> Does this use the common structure although we have no usage for
> the members of struct ccu_common except struct clk_hw? I suppose
> this is done so registering a bunch of clks is easy?
Yes, when we discussed this with Mike back at the ELC, he said that he
really liked the approach you had the qualcomm clocks where you have a
single array with all the clocks, so I tried to follow that as much as
possible.
Even though it doesn't really make much sense here, indeed.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>,
Vishnu Patekar <vishnupatekar0510@gmail.com>,
Jean-Francois Moine <moinejf@free.fr>,
devicetree@vger.kernel.org,
Andre Przywara <andre.przywara@arm.com>,
Mike Turquette <mturquette@baylibre.com>,
linux-kernel@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>,
Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 04/15] clk: sunxi-ng: Add fixed factor clock support
Date: Tue, 21 Jun 2016 11:24:13 +0200 [thread overview]
Message-ID: <20160621092413.GP26668@lukather> (raw)
In-Reply-To: <20160621011537.GP1521@codeaurora.org>
[-- Attachment #1.1: Type: text/plain, Size: 921 bytes --]
Hi Stephen,
On Mon, Jun 20, 2016 at 06:15:37PM -0700, Stephen Boyd wrote:
> On 06/07, Maxime Ripard wrote:
> > +
> > +#include <linux/clk-provider.h>
> > +
> > +#include "ccu_common.h"
> > +
> > +struct ccu_fixed_factor {
> > + u16 div;
> > + u16 mult;
> > +
> > + struct ccu_common common;
>
> Does this use the common structure although we have no usage for
> the members of struct ccu_common except struct clk_hw? I suppose
> this is done so registering a bunch of clks is easy?
Yes, when we discussed this with Mike back at the ELC, he said that he
really liked the approach you had the qualcomm clocks where you have a
single array with all the clocks, so I tried to follow that as much as
possible.
Even though it doesn't really make much sense here, indeed.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 04/15] clk: sunxi-ng: Add fixed factor clock support
Date: Tue, 21 Jun 2016 11:24:13 +0200 [thread overview]
Message-ID: <20160621092413.GP26668@lukather> (raw)
In-Reply-To: <20160621011537.GP1521@codeaurora.org>
Hi Stephen,
On Mon, Jun 20, 2016 at 06:15:37PM -0700, Stephen Boyd wrote:
> On 06/07, Maxime Ripard wrote:
> > +
> > +#include <linux/clk-provider.h>
> > +
> > +#include "ccu_common.h"
> > +
> > +struct ccu_fixed_factor {
> > + u16 div;
> > + u16 mult;
> > +
> > + struct ccu_common common;
>
> Does this use the common structure although we have no usage for
> the members of struct ccu_common except struct clk_hw? I suppose
> this is done so registering a bunch of clks is easy?
Yes, when we discussed this with Mike back at the ELC, he said that he
really liked the approach you had the qualcomm clocks where you have a
single array with all the clocks, so I tried to follow that as much as
possible.
Even though it doesn't really make much sense here, indeed.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160621/89926c4e/attachment-0001.sig>
next prev parent reply other threads:[~2016-06-21 9:34 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 20:41 [PATCH v2 00/15] clk: sunxi: introduce "modern" clock support Maxime Ripard
2016-06-07 20:41 ` Maxime Ripard
2016-06-07 20:41 ` [PATCH v2 01/15] dt-bindings: sunxi: Add CCU binding documentation Maxime Ripard
2016-06-07 20:41 ` Maxime Ripard
2016-06-08 1:37 ` Chen-Yu Tsai
2016-06-08 1:37 ` Chen-Yu Tsai
2016-06-07 20:41 ` [PATCH v2 02/15] clk: sunxi-ng: Add common infrastructure Maxime Ripard
2016-06-07 20:41 ` Maxime Ripard
2016-06-07 20:41 ` Maxime Ripard
2016-06-09 7:39 ` Jean-Francois Moine
2016-06-09 7:39 ` Jean-Francois Moine
2016-06-09 7:39 ` Jean-Francois Moine
2016-06-07 20:41 ` [PATCH v2 03/15] clk: sunxi-ng: Add fractional lib Maxime Ripard
2016-06-07 20:41 ` Maxime Ripard
2016-06-07 20:41 ` Maxime Ripard
2016-06-07 20:41 ` [PATCH v2 04/15] clk: sunxi-ng: Add fixed factor clock support Maxime Ripard
2016-06-07 20:41 ` Maxime Ripard
2016-06-07 20:41 ` Maxime Ripard
2016-06-21 1:15 ` Stephen Boyd
2016-06-21 1:15 ` Stephen Boyd
2016-06-21 9:24 ` Maxime Ripard [this message]
2016-06-21 9:24 ` Maxime Ripard
2016-06-21 9:24 ` Maxime Ripard
2016-06-07 20:41 ` [PATCH v2 05/15] clk: sunxi-ng: Add gate " Maxime Ripard
2016-06-07 20:41 ` Maxime Ripard
2016-06-07 20:41 ` Maxime Ripard
2016-06-09 7:39 ` Jean-Francois Moine
2016-06-09 7:39 ` Jean-Francois Moine
2016-06-09 7:39 ` Jean-Francois Moine
2016-06-07 20:41 ` [PATCH v2 06/15] clk: sunxi-ng: Add mux " Maxime Ripard
2016-06-07 20:41 ` Maxime Ripard
2016-06-07 20:41 ` [PATCH v2 07/15] clk: sunxi-ng: Add phase " Maxime Ripard
2016-06-07 20:41 ` Maxime Ripard
2016-06-07 20:41 ` [PATCH v2 08/15] clk: sunxi-ng: Add divider Maxime Ripard
2016-06-07 20:41 ` Maxime Ripard
2016-06-09 7:40 ` Jean-Francois Moine
2016-06-09 7:40 ` Jean-Francois Moine
2016-06-09 7:40 ` Jean-Francois Moine
2016-06-11 8:27 ` Jean-Francois Moine
2016-06-11 8:27 ` Jean-Francois Moine
2016-06-11 8:27 ` Jean-Francois Moine
2016-06-11 8:27 ` Jean-Francois Moine
2016-06-07 20:41 ` [PATCH v2 09/15] clk: sunxi-ng: Add M-P factor clock support Maxime Ripard
2016-06-07 20:41 ` Maxime Ripard
2016-06-07 20:41 ` [PATCH v2 10/15] clk: sunxi-ng: Add N-K-factor " Maxime Ripard
2016-06-07 20:41 ` Maxime Ripard
2016-06-07 20:41 ` [PATCH v2 11/15] clk: sunxi-ng: Add N-M-factor " Maxime Ripard
2016-06-07 20:41 ` Maxime Ripard
2016-06-07 20:41 ` Maxime Ripard
2016-06-09 7:41 ` Jean-Francois Moine
2016-06-09 7:41 ` Jean-Francois Moine
2016-06-09 7:41 ` Jean-Francois Moine
2016-06-27 20:29 ` Maxime Ripard
2016-06-27 20:29 ` Maxime Ripard
2016-06-07 20:41 ` [PATCH v2 12/15] clk: sunxi-ng: Add N-K-M Factor clock Maxime Ripard
2016-06-07 20:41 ` Maxime Ripard
2016-06-07 20:41 ` [PATCH v2 13/15] clk: sunxi-ng: Add N-K-M-P factor clock Maxime Ripard
2016-06-07 20:41 ` Maxime Ripard
2016-06-21 1:42 ` Stephen Boyd
2016-06-21 1:42 ` Stephen Boyd
2016-06-07 20:41 ` [PATCH v2 14/15] clk: sunxi-ng: Add H3 clocks Maxime Ripard
2016-06-07 20:41 ` Maxime Ripard
2016-06-09 7:42 ` Jean-Francois Moine
2016-06-09 7:42 ` Jean-Francois Moine
2016-06-09 7:42 ` Jean-Francois Moine
2016-06-25 0:28 ` Michael Turquette
2016-06-25 0:28 ` Michael Turquette
2016-06-25 0:28 ` Michael Turquette
2016-06-25 0:28 ` Michael Turquette
2016-06-26 12:34 ` Maxime Ripard
2016-06-26 12:34 ` Maxime Ripard
2016-06-28 0:53 ` Michael Turquette
2016-06-28 0:53 ` Michael Turquette
2016-06-28 0:53 ` Michael Turquette
2016-06-28 8:32 ` Maxime Ripard
2016-06-28 8:32 ` Maxime Ripard
2016-06-07 20:41 ` [PATCH v2 15/15] ARM: dt: sun8i: switch the H3 to the new CCU driver Maxime Ripard
2016-06-07 20:41 ` Maxime Ripard
2016-06-21 1:48 ` [PATCH v2 00/15] clk: sunxi: introduce "modern" clock support Stephen Boyd
2016-06-21 1:48 ` Stephen Boyd
2016-06-21 1:48 ` Stephen Boyd
2016-06-26 16:24 ` Maxime Ripard
2016-06-26 16:24 ` Maxime Ripard
2016-06-21 9:40 ` Jean-Francois Moine
2016-06-21 9:40 ` Jean-Francois Moine
2016-06-21 9:40 ` Jean-Francois Moine
2016-06-21 9:40 ` Jean-Francois Moine
2016-06-21 14:47 ` Maxime Ripard
2016-06-21 14:47 ` Maxime Ripard
2016-06-21 14:47 ` Maxime Ripard
2016-06-21 18:29 ` Jean-Francois Moine
2016-06-21 18:29 ` Jean-Francois Moine
2016-06-21 18:29 ` Jean-Francois Moine
2016-06-21 18:29 ` Jean-Francois Moine
2016-06-27 20:46 ` Maxime Ripard
2016-06-27 20:46 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160621092413.GP26668@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=andre.przywara@arm.com \
--cc=boris.brezillon@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=moinejf@free.fr \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=vishnupatekar0510@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.