From: "Pali Rohár" <pali.rohar@gmail.com> To: Dmitry Torokhov <dmitry.torokhov@gmail.com> Cc: Hans de Goede <hdegoede@redhat.com>, Ben Gamari <ben@smart-cactus.org>, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/5] Input: alps - cleanup Date: Tue, 21 Jun 2016 13:27:30 +0200 [thread overview] Message-ID: <20160621112730.GU29844@pali> (raw) In-Reply-To: <20160621003113.GE22426@dtor-ws> On Monday 20 June 2016 17:31:13 Dmitry Torokhov wrote: > Hi Pali, > > On Mon, Jun 06, 2016 at 01:23:56PM +0200, Pali Rohár wrote: > > This patch series cleanup usage of alps_model_data table. > > > > Pali Rohár (5): > > Input: alps - move ALPS_PROTO_V6 out of alps_model_data table > > Input: alps - move ALPS_PROTO_V4 out of alps_model_data table > > Input: alps - move ALPS_PROTO_V1 out of alps_model_data table > > Input: alps - warn about unsupported ALPS V9 touchpad > > Input: alps - cleanup ALPS_PROTO_V2 detection > > Frankly, I do not quite like this series. The rule of thumb we had: if > we can use e7 data to identify the device it should go into table, > if we need to have more elaborate logic - then implement it in > __alps_indentify(). I would understand if we got rid of the table > completely, but we didn't. Hans and me agreed that alps_model_data array is for old touchpads defined as quirks table. So in this patch series I'm trying to eliminate using that array. And it is possible for V1, V4 and V6 touchpads because each protocol has only one entry in table. And last user is just V2 protocol which is I think better... So this is my motivation for this patch series. > I think the patch removing ALPS_PROTO_V4 and subsequent patch removing > command_mode_resp from alps_model_info are good, the rest are not so > much. > > Thanks. > -- Pali Rohár pali.rohar@gmail.com
WARNING: multiple messages have this Message-ID (diff)
From: "Pali Rohár" <pali.rohar@gmail.com> To: Dmitry Torokhov <dmitry.torokhov@gmail.com> Cc: Hans de Goede <hdegoede@redhat.com>, Ben Gamari <ben@smart-cactus.org>, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/5] Input: alps - cleanup Date: Tue, 21 Jun 2016 13:27:30 +0200 [thread overview] Message-ID: <20160621112730.GU29844@pali> (raw) In-Reply-To: <20160621003113.GE22426@dtor-ws> On Monday 20 June 2016 17:31:13 Dmitry Torokhov wrote: > Hi Pali, > > On Mon, Jun 06, 2016 at 01:23:56PM +0200, Pali Rohár wrote: > > This patch series cleanup usage of alps_model_data table. > > > > Pali Rohár (5): > > Input: alps - move ALPS_PROTO_V6 out of alps_model_data table > > Input: alps - move ALPS_PROTO_V4 out of alps_model_data table > > Input: alps - move ALPS_PROTO_V1 out of alps_model_data table > > Input: alps - warn about unsupported ALPS V9 touchpad > > Input: alps - cleanup ALPS_PROTO_V2 detection > > Frankly, I do not quite like this series. The rule of thumb we had: if > we can use e7 data to identify the device it should go into table, > if we need to have more elaborate logic - then implement it in > __alps_indentify(). I would understand if we got rid of the table > completely, but we didn't. Hans and me agreed that alps_model_data array is for old touchpads defined as quirks table. So in this patch series I'm trying to eliminate using that array. And it is possible for V1, V4 and V6 touchpads because each protocol has only one entry in table. And last user is just V2 protocol which is I think better... So this is my motivation for this patch series. > I think the patch removing ALPS_PROTO_V4 and subsequent patch removing > command_mode_resp from alps_model_info are good, the rest are not so > much. > > Thanks. > -- Pali Rohár pali.rohar@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-06-21 11:27 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-06-06 11:23 [PATCH 0/5] Input: alps - cleanup Pali Rohár 2016-06-06 11:23 ` Pali Rohár 2016-06-06 11:23 ` [PATCH 1/5] Input: alps - move ALPS_PROTO_V6 out of alps_model_data table Pali Rohár 2016-06-06 11:23 ` [PATCH 2/5] Input: alps - move ALPS_PROTO_V4 " Pali Rohár 2016-06-06 11:23 ` [PATCH 3/5] Input: alps - move ALPS_PROTO_V1 " Pali Rohár 2016-06-06 11:24 ` [PATCH 4/5] Input: alps - warn about unsupported ALPS V9 touchpad Pali Rohár 2016-06-06 11:24 ` [PATCH 5/5] Input: alps - cleanup ALPS_PROTO_V2 detection Pali Rohár 2016-06-06 11:32 ` [PATCH 0/5] Input: alps - cleanup Hans de Goede 2016-06-20 17:49 ` Pali Rohár 2016-06-16 20:24 ` Pali Rohár 2016-06-21 0:31 ` Dmitry Torokhov 2016-06-21 0:31 ` Dmitry Torokhov 2016-06-21 11:27 ` Pali Rohár [this message] 2016-06-21 11:27 ` Pali Rohár 2016-07-07 11:41 ` Pali Rohár 2016-07-07 11:41 ` Pali Rohár 2016-07-08 21:37 ` Dmitry Torokhov 2016-07-08 21:37 ` Dmitry Torokhov 2016-07-09 9:58 ` Pali Rohár 2016-08-09 7:56 ` Pali Rohár 2016-09-14 21:02 ` Pali Rohár 2016-10-21 21:09 ` Pali Rohár 2016-10-24 21:24 ` Dmitry Torokhov 2017-03-04 11:24 ` [PATCH v2 0/3] " Pali Rohár 2017-03-04 11:24 ` [PATCH v2 1/3] Input: alps - move ALPS_PROTO_V4 out of alps_model_data table Pali Rohár 2017-03-04 11:24 ` [PATCH v2 2/3] Input: alps - warn about unsupported ALPS V9 touchpad Pali Rohár 2017-03-04 11:24 ` [PATCH v2 3/3] Input: alps - cleanup alps_model_data Pali Rohár 2017-03-07 17:44 ` [PATCH v2 0/3] Input: alps - cleanup Dmitry Torokhov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160621112730.GU29844@pali \ --to=pali.rohar@gmail.com \ --cc=ben@smart-cactus.org \ --cc=dmitry.torokhov@gmail.com \ --cc=hdegoede@redhat.com \ --cc=linux-input@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.