All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 01/17] RTC: ds1307: Add DS1341 variant
@ 2016-06-21  7:20 ` Andrey Smirnov
  0 siblings, 0 replies; 6+ messages in thread
From: Andrey Smirnov @ 2016-06-21  7:20 UTC (permalink / raw)
  To: rtc-linux
  Cc: Andrey Smirnov, Alessandro Zummo, Alexandre Belloni,
	linux-kernel, cphealy

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
 drivers/rtc/rtc-ds1307.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c
index 821d9c0..7e65e2e 100644
--- a/drivers/rtc/rtc-ds1307.c
+++ b/drivers/rtc/rtc-ds1307.c
@@ -35,6 +35,7 @@ enum ds_type {
 	ds_1338,
 	ds_1339,
 	ds_1340,
+	ds_1341,
 	ds_1388,
 	ds_3231,
 	m41t00,
@@ -178,6 +179,7 @@ static const struct i2c_device_id ds1307_id[] = {
 	{ "ds1337", ds_1337 },
 	{ "ds1338", ds_1338 },
 	{ "ds1339", ds_1339 },
+	{ "ds1341", ds_1341 },
 	{ "ds1388", ds_1388 },
 	{ "ds1340", ds_1340 },
 	{ "ds3231", ds_3231 },
@@ -424,6 +426,7 @@ static int ds1307_set_time(struct device *dev, struct rtc_time *t)
 	case ds_1337:
 	case ds_1339:
 	case ds_3231:
+	case ds_1341:
 		buf[DS1307_REG_MONTH] |= DS1337_BIT_CENTURY;
 		break;
 	case ds_1340:
@@ -1242,6 +1245,7 @@ static int ds1307_probe(struct i2c_client *client,
 
 	static const int	bbsqi_bitpos[] = {
 		[ds_1337] = 0,
+		[ds_1341] = 0,
 		[ds_1339] = DS1339_BIT_BBSQI,
 		[ds_3231] = DS3231_BIT_BBSQW,
 	};
@@ -1301,6 +1305,7 @@ static int ds1307_probe(struct i2c_client *client,
 	case ds_1337:
 	case ds_1339:
 	case ds_3231:
+	case ds_1341:
 		/* get registers that the "rtc" read below won't read... */
 		tmp = ds1307->read_block_data(ds1307->client,
 				DS1337_REG_CONTROL, 2, buf);
-- 
2.5.5

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [rtc-linux] [PATCH v2 01/17] RTC: ds1307: Add DS1341 variant
@ 2016-06-21  7:20 ` Andrey Smirnov
  0 siblings, 0 replies; 6+ messages in thread
From: Andrey Smirnov @ 2016-06-21  7:20 UTC (permalink / raw)
  To: rtc-linux
  Cc: Andrey Smirnov, Alessandro Zummo, Alexandre Belloni,
	linux-kernel, cphealy

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
 drivers/rtc/rtc-ds1307.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c
index 821d9c0..7e65e2e 100644
--- a/drivers/rtc/rtc-ds1307.c
+++ b/drivers/rtc/rtc-ds1307.c
@@ -35,6 +35,7 @@ enum ds_type {
 	ds_1338,
 	ds_1339,
 	ds_1340,
+	ds_1341,
 	ds_1388,
 	ds_3231,
 	m41t00,
@@ -178,6 +179,7 @@ static const struct i2c_device_id ds1307_id[] = {
 	{ "ds1337", ds_1337 },
 	{ "ds1338", ds_1338 },
 	{ "ds1339", ds_1339 },
+	{ "ds1341", ds_1341 },
 	{ "ds1388", ds_1388 },
 	{ "ds1340", ds_1340 },
 	{ "ds3231", ds_3231 },
@@ -424,6 +426,7 @@ static int ds1307_set_time(struct device *dev, struct rtc_time *t)
 	case ds_1337:
 	case ds_1339:
 	case ds_3231:
+	case ds_1341:
 		buf[DS1307_REG_MONTH] |= DS1337_BIT_CENTURY;
 		break;
 	case ds_1340:
@@ -1242,6 +1245,7 @@ static int ds1307_probe(struct i2c_client *client,
 
 	static const int	bbsqi_bitpos[] = {
 		[ds_1337] = 0,
+		[ds_1341] = 0,
 		[ds_1339] = DS1339_BIT_BBSQI,
 		[ds_3231] = DS3231_BIT_BBSQW,
 	};
@@ -1301,6 +1305,7 @@ static int ds1307_probe(struct i2c_client *client,
 	case ds_1337:
 	case ds_1339:
 	case ds_3231:
+	case ds_1341:
 		/* get registers that the "rtc" read below won't read... */
 		tmp = ds1307->read_block_data(ds1307->client,
 				DS1337_REG_CONTROL, 2, buf);
-- 
2.5.5

-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH v2 01/17] RTC: ds1307: Add DS1341 variant
  2016-06-21  7:20 ` [rtc-linux] " Andrey Smirnov
@ 2016-06-21 21:26   ` Alexandre Belloni
  -1 siblings, 0 replies; 6+ messages in thread
From: Alexandre Belloni @ 2016-06-21 21:26 UTC (permalink / raw)
  To: Andrey Smirnov; +Cc: rtc-linux, Alessandro Zummo, linux-kernel, cphealy

Please always include a commit message.

On 21/06/2016 at 00:20:50 -0700, Andrey Smirnov wrote :
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
>  drivers/rtc/rtc-ds1307.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c
> index 821d9c0..7e65e2e 100644
> --- a/drivers/rtc/rtc-ds1307.c
> +++ b/drivers/rtc/rtc-ds1307.c
> @@ -35,6 +35,7 @@ enum ds_type {
>  	ds_1338,
>  	ds_1339,
>  	ds_1340,
> +	ds_1341,
>  	ds_1388,
>  	ds_3231,
>  	m41t00,
> @@ -178,6 +179,7 @@ static const struct i2c_device_id ds1307_id[] = {
>  	{ "ds1337", ds_1337 },
>  	{ "ds1338", ds_1338 },
>  	{ "ds1339", ds_1339 },
> +	{ "ds1341", ds_1341 },
>  	{ "ds1388", ds_1388 },
>  	{ "ds1340", ds_1340 },
>  	{ "ds3231", ds_3231 },
> @@ -424,6 +426,7 @@ static int ds1307_set_time(struct device *dev, struct rtc_time *t)
>  	case ds_1337:
>  	case ds_1339:
>  	case ds_3231:
> +	case ds_1341:
>  		buf[DS1307_REG_MONTH] |= DS1337_BIT_CENTURY;
>  		break;
>  	case ds_1340:
> @@ -1242,6 +1245,7 @@ static int ds1307_probe(struct i2c_client *client,
>  
>  	static const int	bbsqi_bitpos[] = {
>  		[ds_1337] = 0,
> +		[ds_1341] = 0,
>  		[ds_1339] = DS1339_BIT_BBSQI,
>  		[ds_3231] = DS3231_BIT_BBSQW,
>  	};
> @@ -1301,6 +1305,7 @@ static int ds1307_probe(struct i2c_client *client,
>  	case ds_1337:
>  	case ds_1339:
>  	case ds_3231:
> +	case ds_1341:
>  		/* get registers that the "rtc" read below won't read... */
>  		tmp = ds1307->read_block_data(ds1307->client,
>  				DS1337_REG_CONTROL, 2, buf);
> -- 
> 2.5.5
> 

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [rtc-linux] Re: [PATCH v2 01/17] RTC: ds1307: Add DS1341 variant
@ 2016-06-21 21:26   ` Alexandre Belloni
  0 siblings, 0 replies; 6+ messages in thread
From: Alexandre Belloni @ 2016-06-21 21:26 UTC (permalink / raw)
  To: Andrey Smirnov; +Cc: rtc-linux, Alessandro Zummo, linux-kernel, cphealy

Please always include a commit message.

On 21/06/2016 at 00:20:50 -0700, Andrey Smirnov wrote :
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
>  drivers/rtc/rtc-ds1307.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c
> index 821d9c0..7e65e2e 100644
> --- a/drivers/rtc/rtc-ds1307.c
> +++ b/drivers/rtc/rtc-ds1307.c
> @@ -35,6 +35,7 @@ enum ds_type {
>  	ds_1338,
>  	ds_1339,
>  	ds_1340,
> +	ds_1341,
>  	ds_1388,
>  	ds_3231,
>  	m41t00,
> @@ -178,6 +179,7 @@ static const struct i2c_device_id ds1307_id[] = {
>  	{ "ds1337", ds_1337 },
>  	{ "ds1338", ds_1338 },
>  	{ "ds1339", ds_1339 },
> +	{ "ds1341", ds_1341 },
>  	{ "ds1388", ds_1388 },
>  	{ "ds1340", ds_1340 },
>  	{ "ds3231", ds_3231 },
> @@ -424,6 +426,7 @@ static int ds1307_set_time(struct device *dev, struct rtc_time *t)
>  	case ds_1337:
>  	case ds_1339:
>  	case ds_3231:
> +	case ds_1341:
>  		buf[DS1307_REG_MONTH] |= DS1337_BIT_CENTURY;
>  		break;
>  	case ds_1340:
> @@ -1242,6 +1245,7 @@ static int ds1307_probe(struct i2c_client *client,
>  
>  	static const int	bbsqi_bitpos[] = {
>  		[ds_1337] = 0,
> +		[ds_1341] = 0,
>  		[ds_1339] = DS1339_BIT_BBSQI,
>  		[ds_3231] = DS3231_BIT_BBSQW,
>  	};
> @@ -1301,6 +1305,7 @@ static int ds1307_probe(struct i2c_client *client,
>  	case ds_1337:
>  	case ds_1339:
>  	case ds_3231:
> +	case ds_1341:
>  		/* get registers that the "rtc" read below won't read... */
>  		tmp = ds1307->read_block_data(ds1307->client,
>  				DS1337_REG_CONTROL, 2, buf);
> -- 
> 2.5.5
> 

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH v2 01/17] RTC: ds1307: Add DS1341 variant
  2016-06-21 21:26   ` [rtc-linux] " Alexandre Belloni
@ 2016-06-21 23:28     ` Andrey Smirnov
  -1 siblings, 0 replies; 6+ messages in thread
From: Andrey Smirnov @ 2016-06-21 23:28 UTC (permalink / raw)
  To: Alexandre Belloni; +Cc: rtc-linux, Alessandro Zummo, linux-kernel, Chris Healy

On Tue, Jun 21, 2016 at 2:26 PM, Alexandre Belloni
<alexandre.belloni@free-electrons.com> wrote:
> Please always include a commit message.

OK, will fix in v3

>
> On 21/06/2016 at 00:20:50 -0700, Andrey Smirnov wrote :
>> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
>> ---
>>  drivers/rtc/rtc-ds1307.c | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c
>> index 821d9c0..7e65e2e 100644
>> --- a/drivers/rtc/rtc-ds1307.c
>> +++ b/drivers/rtc/rtc-ds1307.c
>> @@ -35,6 +35,7 @@ enum ds_type {
>>       ds_1338,
>>       ds_1339,
>>       ds_1340,
>> +     ds_1341,
>>       ds_1388,
>>       ds_3231,
>>       m41t00,
>> @@ -178,6 +179,7 @@ static const struct i2c_device_id ds1307_id[] = {
>>       { "ds1337", ds_1337 },
>>       { "ds1338", ds_1338 },
>>       { "ds1339", ds_1339 },
>> +     { "ds1341", ds_1341 },
>>       { "ds1388", ds_1388 },
>>       { "ds1340", ds_1340 },
>>       { "ds3231", ds_3231 },
>> @@ -424,6 +426,7 @@ static int ds1307_set_time(struct device *dev, struct rtc_time *t)
>>       case ds_1337:
>>       case ds_1339:
>>       case ds_3231:
>> +     case ds_1341:
>>               buf[DS1307_REG_MONTH] |= DS1337_BIT_CENTURY;
>>               break;
>>       case ds_1340:
>> @@ -1242,6 +1245,7 @@ static int ds1307_probe(struct i2c_client *client,
>>
>>       static const int        bbsqi_bitpos[] = {
>>               [ds_1337] = 0,
>> +             [ds_1341] = 0,
>>               [ds_1339] = DS1339_BIT_BBSQI,
>>               [ds_3231] = DS3231_BIT_BBSQW,
>>       };
>> @@ -1301,6 +1305,7 @@ static int ds1307_probe(struct i2c_client *client,
>>       case ds_1337:
>>       case ds_1339:
>>       case ds_3231:
>> +     case ds_1341:
>>               /* get registers that the "rtc" read below won't read... */
>>               tmp = ds1307->read_block_data(ds1307->client,
>>                               DS1337_REG_CONTROL, 2, buf);
>> --
>> 2.5.5
>>
>
> --
> Alexandre Belloni, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [rtc-linux] Re: [PATCH v2 01/17] RTC: ds1307: Add DS1341 variant
@ 2016-06-21 23:28     ` Andrey Smirnov
  0 siblings, 0 replies; 6+ messages in thread
From: Andrey Smirnov @ 2016-06-21 23:28 UTC (permalink / raw)
  To: Alexandre Belloni; +Cc: rtc-linux, Alessandro Zummo, linux-kernel, Chris Healy

On Tue, Jun 21, 2016 at 2:26 PM, Alexandre Belloni
<alexandre.belloni@free-electrons.com> wrote:
> Please always include a commit message.

OK, will fix in v3

>
> On 21/06/2016 at 00:20:50 -0700, Andrey Smirnov wrote :
>> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
>> ---
>>  drivers/rtc/rtc-ds1307.c | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c
>> index 821d9c0..7e65e2e 100644
>> --- a/drivers/rtc/rtc-ds1307.c
>> +++ b/drivers/rtc/rtc-ds1307.c
>> @@ -35,6 +35,7 @@ enum ds_type {
>>       ds_1338,
>>       ds_1339,
>>       ds_1340,
>> +     ds_1341,
>>       ds_1388,
>>       ds_3231,
>>       m41t00,
>> @@ -178,6 +179,7 @@ static const struct i2c_device_id ds1307_id[] = {
>>       { "ds1337", ds_1337 },
>>       { "ds1338", ds_1338 },
>>       { "ds1339", ds_1339 },
>> +     { "ds1341", ds_1341 },
>>       { "ds1388", ds_1388 },
>>       { "ds1340", ds_1340 },
>>       { "ds3231", ds_3231 },
>> @@ -424,6 +426,7 @@ static int ds1307_set_time(struct device *dev, struct rtc_time *t)
>>       case ds_1337:
>>       case ds_1339:
>>       case ds_3231:
>> +     case ds_1341:
>>               buf[DS1307_REG_MONTH] |= DS1337_BIT_CENTURY;
>>               break;
>>       case ds_1340:
>> @@ -1242,6 +1245,7 @@ static int ds1307_probe(struct i2c_client *client,
>>
>>       static const int        bbsqi_bitpos[] = {
>>               [ds_1337] = 0,
>> +             [ds_1341] = 0,
>>               [ds_1339] = DS1339_BIT_BBSQI,
>>               [ds_3231] = DS3231_BIT_BBSQW,
>>       };
>> @@ -1301,6 +1305,7 @@ static int ds1307_probe(struct i2c_client *client,
>>       case ds_1337:
>>       case ds_1339:
>>       case ds_3231:
>> +     case ds_1341:
>>               /* get registers that the "rtc" read below won't read... */
>>               tmp = ds1307->read_block_data(ds1307->client,
>>                               DS1337_REG_CONTROL, 2, buf);
>> --
>> 2.5.5
>>
>
> --
> Alexandre Belloni, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com

-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-06-22  1:47 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-21  7:20 [PATCH v2 01/17] RTC: ds1307: Add DS1341 variant Andrey Smirnov
2016-06-21  7:20 ` [rtc-linux] " Andrey Smirnov
2016-06-21 21:26 ` Alexandre Belloni
2016-06-21 21:26   ` [rtc-linux] " Alexandre Belloni
2016-06-21 23:28   ` Andrey Smirnov
2016-06-21 23:28     ` [rtc-linux] " Andrey Smirnov

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.