* [Qemu-devel] [PATCH v2 1/1] mirror: fix trace_mirror_yield_in_flight usage in mirror_iteration()
@ 2016-06-21 14:09 Denis V. Lunev
2016-06-21 21:38 ` Eric Blake
2016-06-22 4:05 ` Jeff Cody
0 siblings, 2 replies; 3+ messages in thread
From: Denis V. Lunev @ 2016-06-21 14:09 UTC (permalink / raw)
To: qemu-block, qemu-devel; +Cc: den, Jeff Cody, Kevin Wolf, Max Reitz
trace_mirror_yield_in_flight accepts 2nd arguments in sectors while here
we pass chunks instead.
Signed-off-by: Denis V. Lunev <den@openvz.org>
CC: Jeff Cody <jcody@redhat.com>
CC: Kevin Wolf <kwolf@redhat.com>
CC: Max Reitz <mreitz@redhat.com>
---
Changes from v1:
- proper persons added to CC list
block/mirror.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/mirror.c b/block/mirror.c
index a04ed9c..930ac96 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -327,7 +327,7 @@ static uint64_t coroutine_fn mirror_iteration(MirrorBlockJob *s)
first_chunk = sector_num / sectors_per_chunk;
while (test_bit(first_chunk, s->in_flight_bitmap)) {
- trace_mirror_yield_in_flight(s, first_chunk, s->in_flight);
+ trace_mirror_yield_in_flight(s, sector_num, s->in_flight);
mirror_wait_for_io(s);
}
--
2.5.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH v2 1/1] mirror: fix trace_mirror_yield_in_flight usage in mirror_iteration()
2016-06-21 14:09 [Qemu-devel] [PATCH v2 1/1] mirror: fix trace_mirror_yield_in_flight usage in mirror_iteration() Denis V. Lunev
@ 2016-06-21 21:38 ` Eric Blake
2016-06-22 4:05 ` Jeff Cody
1 sibling, 0 replies; 3+ messages in thread
From: Eric Blake @ 2016-06-21 21:38 UTC (permalink / raw)
To: Denis V. Lunev, qemu-block, qemu-devel; +Cc: Kevin Wolf, Jeff Cody, Max Reitz
[-- Attachment #1: Type: text/plain, Size: 1232 bytes --]
On 06/21/2016 08:09 AM, Denis V. Lunev wrote:
> trace_mirror_yield_in_flight accepts 2nd arguments in sectors while here
> we pass chunks instead.
>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Jeff Cody <jcody@redhat.com>
> CC: Kevin Wolf <kwolf@redhat.com>
> CC: Max Reitz <mreitz@redhat.com>
> ---
> Changes from v1:
> - proper persons added to CC list
>
> block/mirror.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/mirror.c b/block/mirror.c
> index a04ed9c..930ac96 100644
> --- a/block/mirror.c
> +++ b/block/mirror.c
> @@ -327,7 +327,7 @@ static uint64_t coroutine_fn mirror_iteration(MirrorBlockJob *s)
>
> first_chunk = sector_num / sectors_per_chunk;
> while (test_bit(first_chunk, s->in_flight_bitmap)) {
> - trace_mirror_yield_in_flight(s, first_chunk, s->in_flight);
> + trace_mirror_yield_in_flight(s, sector_num, s->in_flight);
Ultimately, it would be nice to fix the trace to use bytes instead of
sectors. But as a stopgap, this is obviously correct, so:
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH v2 1/1] mirror: fix trace_mirror_yield_in_flight usage in mirror_iteration()
2016-06-21 14:09 [Qemu-devel] [PATCH v2 1/1] mirror: fix trace_mirror_yield_in_flight usage in mirror_iteration() Denis V. Lunev
2016-06-21 21:38 ` Eric Blake
@ 2016-06-22 4:05 ` Jeff Cody
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Cody @ 2016-06-22 4:05 UTC (permalink / raw)
To: Denis V. Lunev; +Cc: qemu-block, qemu-devel, Kevin Wolf, Max Reitz
On Tue, Jun 21, 2016 at 05:09:17PM +0300, Denis V. Lunev wrote:
> trace_mirror_yield_in_flight accepts 2nd arguments in sectors while here
> we pass chunks instead.
>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Jeff Cody <jcody@redhat.com>
> CC: Kevin Wolf <kwolf@redhat.com>
> CC: Max Reitz <mreitz@redhat.com>
> ---
> Changes from v1:
> - proper persons added to CC list
>
> block/mirror.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/mirror.c b/block/mirror.c
> index a04ed9c..930ac96 100644
> --- a/block/mirror.c
> +++ b/block/mirror.c
> @@ -327,7 +327,7 @@ static uint64_t coroutine_fn mirror_iteration(MirrorBlockJob *s)
>
> first_chunk = sector_num / sectors_per_chunk;
> while (test_bit(first_chunk, s->in_flight_bitmap)) {
> - trace_mirror_yield_in_flight(s, first_chunk, s->in_flight);
> + trace_mirror_yield_in_flight(s, sector_num, s->in_flight);
> mirror_wait_for_io(s);
> }
>
> --
> 2.5.0
>
Thanks,
Applied to my block branch:
git://github.com/codyprime/qemu-kvm-jtc.git block
-Jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-22 4:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-21 14:09 [Qemu-devel] [PATCH v2 1/1] mirror: fix trace_mirror_yield_in_flight usage in mirror_iteration() Denis V. Lunev
2016-06-21 21:38 ` Eric Blake
2016-06-22 4:05 ` Jeff Cody
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.