From: Bjorn Andersson <bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Neil Armstrong <narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
Cc: linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
andy.gross-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
david.brown-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org,
alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH 4/5] mfd: qcom-rpm: Add support for pm8018 RPM Regulator
Date: Tue, 21 Jun 2016 22:23:40 -0700 [thread overview]
Message-ID: <20160622052340.GI1256@tuxbot> (raw)
In-Reply-To: <1466158929-19524-5-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
On Fri 17 Jun 03:22 PDT 2016, Neil Armstrong wrote:
[..]
> diff --git a/drivers/mfd/qcom_rpm.c b/drivers/mfd/qcom_rpm.c
[..]
> +
> +static const struct qcom_rpm_data mdm9615_template = {
> + .version = 3,
> + .resource_table = mdm9615_rpm_resource_table,
> + .n_resources = ARRAY_SIZE(mdm9615_rpm_resource_table),
> +};
Please see:
https://patchwork.kernel.org/patch/9177159/
You should set the new .sel_size to 4 here, please either rebase ontop
of Linus patch or send an update after both are merged.
> +
> static const struct of_device_id qcom_rpm_of_match[] = {
> { .compatible = "qcom,rpm-apq8064", .data = &apq8064_template },
> { .compatible = "qcom,rpm-msm8660", .data = &msm8660_template },
> { .compatible = "qcom,rpm-msm8960", .data = &msm8960_template },
> { .compatible = "qcom,rpm-ipq8064", .data = &ipq806x_template },
> + { .compatible = "qcom,rpm-mdm9615", .data = &mdm9615_template },
> { }
> };
> MODULE_DEVICE_TABLE(of, qcom_rpm_of_match);
> diff --git a/include/dt-bindings/mfd/qcom-rpm.h b/include/dt-bindings/mfd/qcom-rpm.h
> index 13a9d4b..db85912 100644
> --- a/include/dt-bindings/mfd/qcom-rpm.h
> +++ b/include/dt-bindings/mfd/qcom-rpm.h
> @@ -148,6 +148,29 @@
> #define QCOM_RPM_SMB208_S2a 138
> #define QCOM_RPM_SMB208_S2b 139
>
> +#define QCOM_RPM_PM8018_SMPS1 200
These numbers are a logical identifier and as such you shouldn't skip
140-199.
> +#define QCOM_RPM_PM8018_SMPS2 201
> +#define QCOM_RPM_PM8018_SMPS3 202
> +#define QCOM_RPM_PM8018_SMPS4 203
> +#define QCOM_RPM_PM8018_SMPS5 204
> +#define QCOM_RPM_PM8018_LDO1 205
> +#define QCOM_RPM_PM8018_LDO2 206
> +#define QCOM_RPM_PM8018_LDO3 207
> +#define QCOM_RPM_PM8018_LDO4 208
> +#define QCOM_RPM_PM8018_LDO5 209
> +#define QCOM_RPM_PM8018_LDO6 210
> +#define QCOM_RPM_PM8018_LDO7 211
> +#define QCOM_RPM_PM8018_LDO8 212
> +#define QCOM_RPM_PM8018_LDO9 213
> +#define QCOM_RPM_PM8018_LDO10 214
> +#define QCOM_RPM_PM8018_LDO11 215
> +#define QCOM_RPM_PM8018_LDO12 216
> +#define QCOM_RPM_PM8018_LDO13 217
> +#define QCOM_RPM_PM8018_LDO14 218
> +#define QCOM_RPM_PM8018_LVS1 219
> +#define QCOM_RPM_NCP 220
We already have PM8921_NCP and PM8058_NCP, so better make this
QCOM_RPM_PM8018_NCP for consistency.
> +#define QCOM_RPM_VOLTAGE_CORNER 221
> +
Other then these details
Acked-by: Bjorn Andersson <bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Regards,
Bjorn
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: linus.walleij@linaro.org, dmitry.torokhov@gmail.com,
andy.gross@linaro.org, david.brown@linaro.org,
lee.jones@linaro.org, lgirdwood@gmail.com, broonie@kernel.org,
a.zummo@towertech.it, alexandre.belloni@free-electrons.com,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
rtc-linux@googlegroups.com
Subject: Re: [PATCH 4/5] mfd: qcom-rpm: Add support for pm8018 RPM Regulator
Date: Tue, 21 Jun 2016 22:23:40 -0700 [thread overview]
Message-ID: <20160622052340.GI1256@tuxbot> (raw)
In-Reply-To: <1466158929-19524-5-git-send-email-narmstrong@baylibre.com>
On Fri 17 Jun 03:22 PDT 2016, Neil Armstrong wrote:
[..]
> diff --git a/drivers/mfd/qcom_rpm.c b/drivers/mfd/qcom_rpm.c
[..]
> +
> +static const struct qcom_rpm_data mdm9615_template = {
> + .version = 3,
> + .resource_table = mdm9615_rpm_resource_table,
> + .n_resources = ARRAY_SIZE(mdm9615_rpm_resource_table),
> +};
Please see:
https://patchwork.kernel.org/patch/9177159/
You should set the new .sel_size to 4 here, please either rebase ontop
of Linus patch or send an update after both are merged.
> +
> static const struct of_device_id qcom_rpm_of_match[] = {
> { .compatible = "qcom,rpm-apq8064", .data = &apq8064_template },
> { .compatible = "qcom,rpm-msm8660", .data = &msm8660_template },
> { .compatible = "qcom,rpm-msm8960", .data = &msm8960_template },
> { .compatible = "qcom,rpm-ipq8064", .data = &ipq806x_template },
> + { .compatible = "qcom,rpm-mdm9615", .data = &mdm9615_template },
> { }
> };
> MODULE_DEVICE_TABLE(of, qcom_rpm_of_match);
> diff --git a/include/dt-bindings/mfd/qcom-rpm.h b/include/dt-bindings/mfd/qcom-rpm.h
> index 13a9d4b..db85912 100644
> --- a/include/dt-bindings/mfd/qcom-rpm.h
> +++ b/include/dt-bindings/mfd/qcom-rpm.h
> @@ -148,6 +148,29 @@
> #define QCOM_RPM_SMB208_S2a 138
> #define QCOM_RPM_SMB208_S2b 139
>
> +#define QCOM_RPM_PM8018_SMPS1 200
These numbers are a logical identifier and as such you shouldn't skip
140-199.
> +#define QCOM_RPM_PM8018_SMPS2 201
> +#define QCOM_RPM_PM8018_SMPS3 202
> +#define QCOM_RPM_PM8018_SMPS4 203
> +#define QCOM_RPM_PM8018_SMPS5 204
> +#define QCOM_RPM_PM8018_LDO1 205
> +#define QCOM_RPM_PM8018_LDO2 206
> +#define QCOM_RPM_PM8018_LDO3 207
> +#define QCOM_RPM_PM8018_LDO4 208
> +#define QCOM_RPM_PM8018_LDO5 209
> +#define QCOM_RPM_PM8018_LDO6 210
> +#define QCOM_RPM_PM8018_LDO7 211
> +#define QCOM_RPM_PM8018_LDO8 212
> +#define QCOM_RPM_PM8018_LDO9 213
> +#define QCOM_RPM_PM8018_LDO10 214
> +#define QCOM_RPM_PM8018_LDO11 215
> +#define QCOM_RPM_PM8018_LDO12 216
> +#define QCOM_RPM_PM8018_LDO13 217
> +#define QCOM_RPM_PM8018_LDO14 218
> +#define QCOM_RPM_PM8018_LVS1 219
> +#define QCOM_RPM_NCP 220
We already have PM8921_NCP and PM8058_NCP, so better make this
QCOM_RPM_PM8018_NCP for consistency.
> +#define QCOM_RPM_VOLTAGE_CORNER 221
> +
Other then these details
Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: linus.walleij@linaro.org, dmitry.torokhov@gmail.com,
andy.gross@linaro.org, david.brown@linaro.org,
lee.jones@linaro.org, lgirdwood@gmail.com, broonie@kernel.org,
a.zummo@towertech.it, alexandre.belloni@free-electrons.com,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
rtc-linux@googlegroups.com
Subject: [rtc-linux] Re: [PATCH 4/5] mfd: qcom-rpm: Add support for pm8018 RPM Regulator
Date: Tue, 21 Jun 2016 22:23:40 -0700 [thread overview]
Message-ID: <20160622052340.GI1256@tuxbot> (raw)
In-Reply-To: <1466158929-19524-5-git-send-email-narmstrong@baylibre.com>
On Fri 17 Jun 03:22 PDT 2016, Neil Armstrong wrote:
[..]
> diff --git a/drivers/mfd/qcom_rpm.c b/drivers/mfd/qcom_rpm.c
[..]
> +
> +static const struct qcom_rpm_data mdm9615_template = {
> + .version = 3,
> + .resource_table = mdm9615_rpm_resource_table,
> + .n_resources = ARRAY_SIZE(mdm9615_rpm_resource_table),
> +};
Please see:
https://patchwork.kernel.org/patch/9177159/
You should set the new .sel_size to 4 here, please either rebase ontop
of Linus patch or send an update after both are merged.
> +
> static const struct of_device_id qcom_rpm_of_match[] = {
> { .compatible = "qcom,rpm-apq8064", .data = &apq8064_template },
> { .compatible = "qcom,rpm-msm8660", .data = &msm8660_template },
> { .compatible = "qcom,rpm-msm8960", .data = &msm8960_template },
> { .compatible = "qcom,rpm-ipq8064", .data = &ipq806x_template },
> + { .compatible = "qcom,rpm-mdm9615", .data = &mdm9615_template },
> { }
> };
> MODULE_DEVICE_TABLE(of, qcom_rpm_of_match);
> diff --git a/include/dt-bindings/mfd/qcom-rpm.h b/include/dt-bindings/mfd/qcom-rpm.h
> index 13a9d4b..db85912 100644
> --- a/include/dt-bindings/mfd/qcom-rpm.h
> +++ b/include/dt-bindings/mfd/qcom-rpm.h
> @@ -148,6 +148,29 @@
> #define QCOM_RPM_SMB208_S2a 138
> #define QCOM_RPM_SMB208_S2b 139
>
> +#define QCOM_RPM_PM8018_SMPS1 200
These numbers are a logical identifier and as such you shouldn't skip
140-199.
> +#define QCOM_RPM_PM8018_SMPS2 201
> +#define QCOM_RPM_PM8018_SMPS3 202
> +#define QCOM_RPM_PM8018_SMPS4 203
> +#define QCOM_RPM_PM8018_SMPS5 204
> +#define QCOM_RPM_PM8018_LDO1 205
> +#define QCOM_RPM_PM8018_LDO2 206
> +#define QCOM_RPM_PM8018_LDO3 207
> +#define QCOM_RPM_PM8018_LDO4 208
> +#define QCOM_RPM_PM8018_LDO5 209
> +#define QCOM_RPM_PM8018_LDO6 210
> +#define QCOM_RPM_PM8018_LDO7 211
> +#define QCOM_RPM_PM8018_LDO8 212
> +#define QCOM_RPM_PM8018_LDO9 213
> +#define QCOM_RPM_PM8018_LDO10 214
> +#define QCOM_RPM_PM8018_LDO11 215
> +#define QCOM_RPM_PM8018_LDO12 216
> +#define QCOM_RPM_PM8018_LDO13 217
> +#define QCOM_RPM_PM8018_LDO14 218
> +#define QCOM_RPM_PM8018_LVS1 219
> +#define QCOM_RPM_NCP 220
We already have PM8921_NCP and PM8058_NCP, so better make this
QCOM_RPM_PM8018_NCP for consistency.
> +#define QCOM_RPM_VOLTAGE_CORNER 221
> +
Other then these details
Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2016-06-22 5:23 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 10:22 [PATCH 0/5] Add support for the Qualcomm PM8018 PMIC Neil Armstrong
2016-06-17 10:22 ` [rtc-linux] " Neil Armstrong
2016-06-17 10:22 ` Neil Armstrong
[not found] ` <1466158929-19524-1-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2016-06-17 10:22 ` [PATCH 1/5] mfd: pm8921: Add support for pm8018 Neil Armstrong
2016-06-17 10:22 ` [rtc-linux] " Neil Armstrong
2016-06-17 10:22 ` Neil Armstrong
[not found] ` <1466158929-19524-2-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2016-06-22 5:07 ` Bjorn Andersson
2016-06-22 5:07 ` [rtc-linux] " Bjorn Andersson
2016-06-22 5:07 ` Bjorn Andersson
2016-06-17 10:22 ` [PATCH 2/5] input: pmic8xxx-pwrkey: Add support for pm8018 pwrkey Neil Armstrong
2016-06-17 10:22 ` [rtc-linux] " Neil Armstrong
2016-06-17 10:22 ` Neil Armstrong
[not found] ` <1466158929-19524-3-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2016-06-18 16:21 ` Dmitry Torokhov
2016-06-18 16:21 ` [rtc-linux] " Dmitry Torokhov
2016-06-18 16:21 ` Dmitry Torokhov
2016-06-22 5:25 ` Bjorn Andersson
2016-06-22 5:25 ` [rtc-linux] " Bjorn Andersson
2016-06-22 5:25 ` Bjorn Andersson
2016-06-22 5:33 ` Dmitry Torokhov
2016-06-22 5:33 ` [rtc-linux] " Dmitry Torokhov
2016-06-22 5:33 ` Dmitry Torokhov
2016-06-17 10:22 ` [PATCH 3/5] rtc: rtc-pm8xxx: Add support for pm8018 rtc Neil Armstrong
2016-06-17 10:22 ` [rtc-linux] " Neil Armstrong
2016-06-17 10:22 ` Neil Armstrong
[not found] ` <1466158929-19524-4-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2016-06-21 16:24 ` Alexandre Belloni
2016-06-21 16:24 ` [rtc-linux] " Alexandre Belloni
2016-06-21 16:24 ` Alexandre Belloni
2016-06-22 5:06 ` Bjorn Andersson
2016-06-22 5:06 ` [rtc-linux] " Bjorn Andersson
2016-06-22 5:06 ` Bjorn Andersson
2016-06-17 10:22 ` [PATCH 4/5] mfd: qcom-rpm: Add support for pm8018 RPM Regulator Neil Armstrong
2016-06-17 10:22 ` [rtc-linux] " Neil Armstrong
2016-06-17 10:22 ` Neil Armstrong
[not found] ` <1466158929-19524-5-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2016-06-22 5:23 ` Bjorn Andersson [this message]
2016-06-22 5:23 ` [rtc-linux] " Bjorn Andersson
2016-06-22 5:23 ` Bjorn Andersson
2016-06-22 8:34 ` Neil Armstrong
2016-06-22 8:34 ` [rtc-linux] " Neil Armstrong
2016-06-22 8:34 ` Neil Armstrong
[not found] ` <576A4D95.3080804-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2016-06-22 15:52 ` Bjorn Andersson
2016-06-22 15:52 ` [rtc-linux] " Bjorn Andersson
2016-06-22 15:52 ` Bjorn Andersson
2016-06-17 10:22 ` [PATCH 5/5] regulator: qcom_rpm-regulator: Add support for pm8018 rpm regulator Neil Armstrong
2016-06-17 10:22 ` [rtc-linux] " Neil Armstrong
2016-06-17 10:22 ` Neil Armstrong
[not found] ` <1466158929-19524-6-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2016-06-17 12:24 ` Mark Brown
2016-06-17 12:24 ` [rtc-linux] " Mark Brown
2016-06-17 12:24 ` Mark Brown
2016-06-17 16:53 ` Bjorn Andersson
2016-06-17 16:53 ` [rtc-linux] " Bjorn Andersson
2016-06-17 16:53 ` Bjorn Andersson
2016-06-18 9:47 ` Mark Brown
2016-06-18 9:47 ` [rtc-linux] " Mark Brown
2016-06-20 9:03 ` Neil Armstrong
2016-06-20 9:03 ` [rtc-linux] " Neil Armstrong
2016-06-20 9:03 ` Neil Armstrong
2016-06-22 8:39 ` Neil Armstrong
2016-06-22 8:39 ` [rtc-linux] " Neil Armstrong
2016-06-22 8:39 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160622052340.GI1256@tuxbot \
--to=bjorn.andersson-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org \
--cc=alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=andy.gross-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=david.brown-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.