[mmotm:master 182/309] drivers/base/node.c:126:31: warning: passing argument 1 of 'node_page_state' makes pointer from integer without a cast

[mmotm:master 182/309] drivers/base/node.c:126:31: warning: passing argument 1 of 'node_page_state' makes pointer from integer without a cast

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 4012 bytes --]

tree:   git://git.cmpxchg.org/linux-mmotm.git master
head:   90fbe8d8441dfa4fc00ac1bc49bc695ec2659b8e
commit: 0a09d3e6693e01a37b8485f6acebf167103c1715 [182/309] mm, vmstat: add infrastructure for per-node vmstats
config: x86_64-allyesdebian (attached as .config)
compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
reproduce:
        git checkout 0a09d3e6693e01a37b8485f6acebf167103c1715
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   drivers/base/node.c: In function 'node_read_meminfo':
>> drivers/base/node.c:126:31: warning: passing argument 1 of 'node_page_state' makes pointer from integer without a cast [-Wint-conversion]
             nid, node_page_state(nid, NR_KERNEL_STACK) *
                                  ^~~
   In file included from include/linux/mm.h:991:0,
                    from drivers/base/node.c:7:
   include/linux/vmstat.h:184:22: note: expected 'struct pglist_data *' but argument is of type 'int'
    extern unsigned long node_page_state(struct pglist_data *pgdat,
                         ^~~~~~~~~~~~~~~

vim +/node_page_state +126 drivers/base/node.c

fc3ba692a Miklos Szeredi     2008-04-30  110  		       "Node %d WritebackTmp:   %8lu kB\n"
972d1a7b1 Christoph Lameter  2006-09-25  111  		       "Node %d Slab:           %8lu kB\n"
972d1a7b1 Christoph Lameter  2006-09-25  112  		       "Node %d SReclaimable:   %8lu kB\n"
05b258e99 David Rientjes     2011-01-13  113  		       "Node %d SUnreclaim:     %8lu kB\n"
05b258e99 David Rientjes     2011-01-13  114  #ifdef CONFIG_TRANSPARENT_HUGEPAGE
05b258e99 David Rientjes     2011-01-13  115  		       "Node %d AnonHugePages:  %8lu kB\n"
d1c474cd4 Kirill A. Shutemov 2016-06-23  116  		       "Node %d ShmemHugePages: %8lu kB\n"
d1c474cd4 Kirill A. Shutemov 2016-06-23  117  		       "Node %d ShmemPmdMapped: %8lu kB\n"
05b258e99 David Rientjes     2011-01-13  118  #endif
05b258e99 David Rientjes     2011-01-13  119  			,
0a09d3e66 Mel Gorman         2016-06-23  120  		       nid, K(sum_zone_node_page_state(nid, NR_FILE_DIRTY)),
0a09d3e66 Mel Gorman         2016-06-23  121  		       nid, K(sum_zone_node_page_state(nid, NR_WRITEBACK)),
0a09d3e66 Mel Gorman         2016-06-23  122  		       nid, K(sum_zone_node_page_state(nid, NR_FILE_PAGES)),
0a09d3e66 Mel Gorman         2016-06-23  123  		       nid, K(sum_zone_node_page_state(nid, NR_FILE_MAPPED)),
0a09d3e66 Mel Gorman         2016-06-23  124  		       nid, K(sum_zone_node_page_state(nid, NR_ANON_PAGES)),
cc7452b6d Rafael Aquini      2014-08-06  125  		       nid, K(i.sharedram),
c6a7f5728 KOSAKI Motohiro    2009-09-21 @126  		       nid, node_page_state(nid, NR_KERNEL_STACK) *
c6a7f5728 KOSAKI Motohiro    2009-09-21  127  				THREAD_SIZE / 1024,
0a09d3e66 Mel Gorman         2016-06-23  128  		       nid, K(sum_zone_node_page_state(nid, NR_PAGETABLE)),
0a09d3e66 Mel Gorman         2016-06-23  129  		       nid, K(sum_zone_node_page_state(nid, NR_UNSTABLE_NFS)),
0a09d3e66 Mel Gorman         2016-06-23  130  		       nid, K(sum_zone_node_page_state(nid, NR_BOUNCE)),
0a09d3e66 Mel Gorman         2016-06-23  131  		       nid, K(sum_zone_node_page_state(nid, NR_WRITEBACK_TEMP)),
0a09d3e66 Mel Gorman         2016-06-23  132  		       nid, K(sum_zone_node_page_state(nid, NR_SLAB_RECLAIMABLE) +
0a09d3e66 Mel Gorman         2016-06-23  133  				sum_zone_node_page_state(nid, NR_SLAB_UNRECLAIMABLE)),
0a09d3e66 Mel Gorman         2016-06-23  134  		       nid, K(sum_zone_node_page_state(nid, NR_SLAB_RECLAIMABLE)),

:::::: The code at line 126 was first introduced by commit
:::::: c6a7f5728a1db45d30df55a01adc130b4ab0327c mm: oom analysis: Show kernel stack usage in /proc/meminfo and OOM log output

:::::: TO: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
:::::: CC: Linus Torvalds <torvalds@linux-foundation.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 37208 bytes --]

[PATCH] mm, vmstat: add infrastructure for per-node vmstats -fix

[Mel Gorman]

The kbuild test robot reported the following

All warnings (new ones prefixed by >>):

   drivers/base/node.c: In function 'node_read_meminfo':
>> drivers/base/node.c:126:31: warning: passing argument 1 of 'node_page_state' makes pointer from integer without a cast [-Wint-conversion]
             nid, node_page_state(nid, NR_KERNEL_STACK) *
                                  ^~~
   In file included from include/linux/mm.h:991:0,
                    from drivers/base/node.c:7:
   include/linux/vmstat.h:184:22: note: expected 'struct pglist_data *' but argument is of type 'int'
    extern unsigned long node_page_state(struct pglist_data *pgdat,

This may be a problem due to a merge conflict. This is a fix for the mmotm
patch mm-vmstat-add-infrastructure-for-per-node-vmstats.patch

Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
---
 drivers/base/node.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/base/node.c b/drivers/base/node.c
index a3ae3ae34593..0a1b6433a76c 100644
--- a/drivers/base/node.c
+++ b/drivers/base/node.c
@@ -123,7 +123,7 @@ static ssize_t node_read_meminfo(struct device *dev,
 		       nid, K(sum_zone_node_page_state(nid, NR_FILE_MAPPED)),
 		       nid, K(sum_zone_node_page_state(nid, NR_ANON_PAGES)),
 		       nid, K(i.sharedram),
-		       nid, node_page_state(nid, NR_KERNEL_STACK) *
+		       nid, sum_zone_node_page_state(nid, NR_KERNEL_STACK) *
 				THREAD_SIZE / 1024,
 		       nid, K(sum_zone_node_page_state(nid, NR_PAGETABLE)),
 		       nid, K(sum_zone_node_page_state(nid, NR_UNSTABLE_NFS)),

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>