[PATCH] btrfs-progs: fi show: print error message if no valid Btrfs is specified

[PATCH] btrfs-progs: fi show: print error message if no valid Btrfs is specified

[Satoru Takeuchi]

* Before this patch

 ===============================
 # ./btrfs fi show foo      # "foo" doesn't mean any valid Btrfs
 #                          # no error message
 # echo $?
 1
 ===============================

* After this patch

 ===============================
 # ./btrfs fi show foo
 ERROR: foo is not a valid Btrfs
 #
 # echo $?
 1
 ===============================

Signed-off-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
---
 cmds-filesystem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/cmds-filesystem.c b/cmds-filesystem.c
index 88867a3..90f3c49 100644
--- a/cmds-filesystem.c
+++ b/cmds-filesystem.c
@@ -898,9 +898,10 @@ devs_only:
 	list_for_each_entry(fs_devices, &all_uuids, list)
 		print_one_uuid(fs_devices, unit_mode);

-	if (search && !found)
+	if (search && !found) {
+		error("%s is not a valid Btrfs", search);
 		ret = 1;
-
+	}
 	while (!list_empty(&all_uuids)) {
 		fs_devices = list_entry(all_uuids.next,
 					struct btrfs_fs_devices, list);
-- 
2.5.5

Re: [PATCH] btrfs-progs: fi show: print error message if no valid Btrfs is specified

[David Sterba]

On Fri, Jun 24, 2016 at 05:24:47PM +0900, Satoru Takeuchi wrote:
> * Before this patch
> 
>  ===============================
>  # ./btrfs fi show foo      # "foo" doesn't mean any valid Btrfs
>  #                          # no error message
>  # echo $?
>  1
>  ===============================
> 
> * After this patch
> 
>  ===============================
>  # ./btrfs fi show foo
>  ERROR: foo is not a valid Btrfs
>  #
>  # echo $?
>  1
>  ===============================
> 
> Signed-off-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>

Applied, thanks.