All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] pinctrl: Add missing of_node_put
@ 2016-06-24 13:06 ` Amitoj Kaur Chawla
  0 siblings, 0 replies; 5+ messages in thread
From: Amitoj Kaur Chawla @ 2016-06-24 13:06 UTC (permalink / raw)
  To: linus.walleij, baohua, linux-gpio, linux-arm-kernel, linux-kernel
  Cc: julia.lawall

of_find_node_by_name does an of_node_get on its return value, 
so an of_node_put is needed on this value before the corresponding 
variable goes out of scope.

The Coccinelle semantic patch used to make this change is as follows:
@@
struct device_node *n;
struct device_node *n1;
statement S;
identifier f;
expression E;
constant C;
@@

n = of_find_node_by_name(...)
...
if (!n) S
... when != of_node_put(n)
    when != n1 = f(n,...)
    when != E = n
    when any
    when strict
(
+ of_node_put(n);
  return -C;
|
  of_node_put(n);
|
  n1 = f(n,...)
|
  E = n
|
  return ...;
)

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
 drivers/pinctrl/sirf/pinctrl-atlas7.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/pinctrl/sirf/pinctrl-atlas7.c b/drivers/pinctrl/sirf/pinctrl-atlas7.c
index 3d233fc..7d9c1a3 100644
--- a/drivers/pinctrl/sirf/pinctrl-atlas7.c
+++ b/drivers/pinctrl/sirf/pinctrl-atlas7.c
@@ -5424,8 +5424,10 @@ static int atlas7_pinmux_probe(struct platform_device *pdev)
 	if (ret)
 		return ret;
 	pmx->sys2pci_base = devm_ioremap_resource(&pdev->dev, &res);
-	if (IS_ERR(pmx->sys2pci_base))
+	if (IS_ERR(pmx->sys2pci_base)) {
+		of_node_put(sys2pci_np);
 		return -ENOMEM;
+	}
 
 	pmx->dev = &pdev->dev;
 
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH] pinctrl: Add missing of_node_put
@ 2016-06-24 13:06 ` Amitoj Kaur Chawla
  0 siblings, 0 replies; 5+ messages in thread
From: Amitoj Kaur Chawla @ 2016-06-24 13:06 UTC (permalink / raw)
  To: linux-arm-kernel

of_find_node_by_name does an of_node_get on its return value, 
so an of_node_put is needed on this value before the corresponding 
variable goes out of scope.

The Coccinelle semantic patch used to make this change is as follows:
@@
struct device_node *n;
struct device_node *n1;
statement S;
identifier f;
expression E;
constant C;
@@

n = of_find_node_by_name(...)
...
if (!n) S
... when != of_node_put(n)
    when != n1 = f(n,...)
    when != E = n
    when any
    when strict
(
+ of_node_put(n);
  return -C;
|
  of_node_put(n);
|
  n1 = f(n,...)
|
  E = n
|
  return ...;
)

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
 drivers/pinctrl/sirf/pinctrl-atlas7.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/pinctrl/sirf/pinctrl-atlas7.c b/drivers/pinctrl/sirf/pinctrl-atlas7.c
index 3d233fc..7d9c1a3 100644
--- a/drivers/pinctrl/sirf/pinctrl-atlas7.c
+++ b/drivers/pinctrl/sirf/pinctrl-atlas7.c
@@ -5424,8 +5424,10 @@ static int atlas7_pinmux_probe(struct platform_device *pdev)
 	if (ret)
 		return ret;
 	pmx->sys2pci_base = devm_ioremap_resource(&pdev->dev, &res);
-	if (IS_ERR(pmx->sys2pci_base))
+	if (IS_ERR(pmx->sys2pci_base)) {
+		of_node_put(sys2pci_np);
 		return -ENOMEM;
+	}
 
 	pmx->dev = &pdev->dev;
 
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] pinctrl: Add missing of_node_put
  2016-06-24 13:06 ` Amitoj Kaur Chawla
  (?)
@ 2016-06-29  8:08   ` Linus Walleij
  -1 siblings, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2016-06-29  8:08 UTC (permalink / raw)
  To: Amitoj Kaur Chawla
  Cc: Barry Song, linux-gpio, linux-arm-kernel, linux-kernel, Julia Lawall

On Fri, Jun 24, 2016 at 3:06 PM, Amitoj Kaur Chawla
<amitoj1606@gmail.com> wrote:

> of_find_node_by_name does an of_node_get on its return value,
> so an of_node_put is needed on this value before the corresponding
> variable goes out of scope.
>
> The Coccinelle semantic patch used to make this change is as follows:
> @@
> struct device_node *n;
> struct device_node *n1;
> statement S;
> identifier f;
> expression E;
> constant C;
> @@
>
> n = of_find_node_by_name(...)
> ...
> if (!n) S
> ... when != of_node_put(n)
>     when != n1 = f(n,...)
>     when != E = n
>     when any
>     when strict
> (
> + of_node_put(n);
>   return -C;
> |
>   of_node_put(n);
> |
>   n1 = f(n,...)
> |
>   E = n
> |
>   return ...;
> )
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>

Patch applied.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] pinctrl: Add missing of_node_put
@ 2016-06-29  8:08   ` Linus Walleij
  0 siblings, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2016-06-29  8:08 UTC (permalink / raw)
  To: Amitoj Kaur Chawla
  Cc: Barry Song, linux-gpio, linux-arm-kernel, linux-kernel, Julia Lawall

On Fri, Jun 24, 2016 at 3:06 PM, Amitoj Kaur Chawla
<amitoj1606@gmail.com> wrote:

> of_find_node_by_name does an of_node_get on its return value,
> so an of_node_put is needed on this value before the corresponding
> variable goes out of scope.
>
> The Coccinelle semantic patch used to make this change is as follows:
> @@
> struct device_node *n;
> struct device_node *n1;
> statement S;
> identifier f;
> expression E;
> constant C;
> @@
>
> n = of_find_node_by_name(...)
> ...
> if (!n) S
> ... when != of_node_put(n)
>     when != n1 = f(n,...)
>     when != E = n
>     when any
>     when strict
> (
> + of_node_put(n);
>   return -C;
> |
>   of_node_put(n);
> |
>   n1 = f(n,...)
> |
>   E = n
> |
>   return ...;
> )
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>

Patch applied.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH] pinctrl: Add missing of_node_put
@ 2016-06-29  8:08   ` Linus Walleij
  0 siblings, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2016-06-29  8:08 UTC (permalink / raw)
  To: linux-arm-kernel

On Fri, Jun 24, 2016 at 3:06 PM, Amitoj Kaur Chawla
<amitoj1606@gmail.com> wrote:

> of_find_node_by_name does an of_node_get on its return value,
> so an of_node_put is needed on this value before the corresponding
> variable goes out of scope.
>
> The Coccinelle semantic patch used to make this change is as follows:
> @@
> struct device_node *n;
> struct device_node *n1;
> statement S;
> identifier f;
> expression E;
> constant C;
> @@
>
> n = of_find_node_by_name(...)
> ...
> if (!n) S
> ... when != of_node_put(n)
>     when != n1 = f(n,...)
>     when != E = n
>     when any
>     when strict
> (
> + of_node_put(n);
>   return -C;
> |
>   of_node_put(n);
> |
>   n1 = f(n,...)
> |
>   E = n
> |
>   return ...;
> )
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>

Patch applied.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-06-29  8:08 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-24 13:06 [PATCH] pinctrl: Add missing of_node_put Amitoj Kaur Chawla
2016-06-24 13:06 ` Amitoj Kaur Chawla
2016-06-29  8:08 ` Linus Walleij
2016-06-29  8:08   ` Linus Walleij
2016-06-29  8:08   ` Linus Walleij

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.