From: Alexandre Belloni <alexandre.belloni@free-electrons.com> To: Raashid Muhammed <raashidmuhammed@zilogic.com> Cc: nicolas.ferre@atmel.com, plagnioj@jcrosoft.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] ARM: dts: at91: Modify information in LED nodes. Date: Fri, 24 Jun 2016 15:40:10 +0200 [thread overview] Message-ID: <20160624134010.GN5809@piout.net> (raw) In-Reply-To: <1466775069-606-2-git-send-email-raashidmuhammed@zilogic.com> Hi, On 24/06/2016 at 19:01:09 +0530, Raashid Muhammed wrote : > Add power led node and rename status led node. > Well, I'm ok with the change but this does more: > Signed-off-by: Raashid Muhammed <raashidmuhammed@zilogic.com> > Reviewed-by: Vijay Kumar B. <vijaykumar@bravegnu.org> > --- > arch/arm/boot/dts/at91-sam9_l9260.dts | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/at91-sam9_l9260.dts b/arch/arm/boot/dts/at91-sam9_l9260.dts > index be409f2..814753a 100644 > --- a/arch/arm/boot/dts/at91-sam9_l9260.dts > +++ b/arch/arm/boot/dts/at91-sam9_l9260.dts > @@ -106,11 +106,16 @@ > leds { > compatible = "gpio-leds"; > > - b0 { > - label = "b0"; > - gpios = <&pioA 6 GPIO_ACTIVE_HIGH>; > - linux,default-trigger = "heartbeat"; > + pwr_led { > + label = "sam9-l9260:yellow:pwr"; > + gpios = <&pioA 9 GPIO_ACTIVE_HIGH>; > + linux,default-trigger = "cpu0"; > }; > > + status_led { > + label = "sam9-l9260:green:status"; > + gpios = <&pioA 6 GPIO_ACTIVE_LOW>; > + linux,default-trigger = "timer"; This trigger is also switched from heartbeat to timer, is this intentional? -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: alexandre.belloni@free-electrons.com (Alexandre Belloni) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/2] ARM: dts: at91: Modify information in LED nodes. Date: Fri, 24 Jun 2016 15:40:10 +0200 [thread overview] Message-ID: <20160624134010.GN5809@piout.net> (raw) In-Reply-To: <1466775069-606-2-git-send-email-raashidmuhammed@zilogic.com> Hi, On 24/06/2016 at 19:01:09 +0530, Raashid Muhammed wrote : > Add power led node and rename status led node. > Well, I'm ok with the change but this does more: > Signed-off-by: Raashid Muhammed <raashidmuhammed@zilogic.com> > Reviewed-by: Vijay Kumar B. <vijaykumar@bravegnu.org> > --- > arch/arm/boot/dts/at91-sam9_l9260.dts | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/at91-sam9_l9260.dts b/arch/arm/boot/dts/at91-sam9_l9260.dts > index be409f2..814753a 100644 > --- a/arch/arm/boot/dts/at91-sam9_l9260.dts > +++ b/arch/arm/boot/dts/at91-sam9_l9260.dts > @@ -106,11 +106,16 @@ > leds { > compatible = "gpio-leds"; > > - b0 { > - label = "b0"; > - gpios = <&pioA 6 GPIO_ACTIVE_HIGH>; > - linux,default-trigger = "heartbeat"; > + pwr_led { > + label = "sam9-l9260:yellow:pwr"; > + gpios = <&pioA 9 GPIO_ACTIVE_HIGH>; > + linux,default-trigger = "cpu0"; > }; > > + status_led { > + label = "sam9-l9260:green:status"; > + gpios = <&pioA 6 GPIO_ACTIVE_LOW>; > + linux,default-trigger = "timer"; This trigger is also switched from heartbeat to timer, is this intentional? -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
next prev parent reply other threads:[~2016-06-24 13:40 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-06-24 13:31 [PATCH 1/2] ARM: dts: at91: Add pinctrl information to ethernet node Raashid Muhammed 2016-06-24 13:31 ` Raashid Muhammed 2016-06-24 13:31 ` Raashid Muhammed 2016-06-24 13:31 ` [PATCH 2/2] ARM: dts: at91: Modify information in LED nodes Raashid Muhammed 2016-06-24 13:31 ` Raashid Muhammed 2016-06-24 13:31 ` Raashid Muhammed 2016-06-24 13:40 ` Alexandre Belloni [this message] 2016-06-24 13:40 ` Alexandre Belloni 2016-06-24 13:56 ` raashidmuhammed 2016-06-24 13:56 ` raashidmuhammed 2016-06-24 13:56 ` raashidmuhammed 2016-06-24 14:04 ` Raashid Muhammed 2016-06-24 14:04 ` Raashid Muhammed 2016-06-24 14:04 ` Raashid Muhammed 2016-07-01 18:47 ` [PATCH 1/2] ARM: dts: at91: Add pinctrl information to ethernet node Alexandre Belloni 2016-07-01 18:47 ` Alexandre Belloni
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160624134010.GN5809@piout.net \ --to=alexandre.belloni@free-electrons.com \ --cc=devicetree@vger.kernel.org \ --cc=galak@codeaurora.org \ --cc=ijc+devicetree@hellion.org.uk \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=mark.rutland@arm.com \ --cc=nicolas.ferre@atmel.com \ --cc=pawel.moll@arm.com \ --cc=plagnioj@jcrosoft.com \ --cc=raashidmuhammed@zilogic.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.