* [PATCH] dm stripe: add DAX support
@ 2016-06-24 18:23 ` Toshi Kani
0 siblings, 0 replies; 26+ messages in thread
From: Toshi Kani @ 2016-06-24 18:23 UTC (permalink / raw)
To: snitzer
Cc: linux-nvdimm, dm-devel, linux-raid, linux-kernel, Toshi Kani,
Alasdair Kergon, Dan Williams, Ross Zwisler
Change dm-stripe to implement direct_access function,
stripe_direct_access(), which maps bdev and sector and
calls direct_access function of its physical target device.
Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
Cc: Alasdair Kergon <agk@redhat.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
---
drivers/md/dm-stripe.c | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/drivers/md/dm-stripe.c b/drivers/md/dm-stripe.c
index 48f1c01..8925f6a 100644
--- a/drivers/md/dm-stripe.c
+++ b/drivers/md/dm-stripe.c
@@ -308,6 +308,30 @@ static int stripe_map(struct dm_target *ti, struct bio *bio)
return DM_MAPIO_REMAPPED;
}
+static long stripe_direct_access(struct dm_target *ti, sector_t sector,
+ void __pmem **kaddr, pfn_t *pfn, long size)
+{
+ struct stripe_c *sc;
+ struct block_device *bdev;
+ uint32_t stripe;
+ struct blk_dax_ctl dax = {
+ .size = size,
+ };
+ long ret;
+
+ sc = ti->private;
+ stripe_map_sector(sc, sector, &stripe, &dax.sector);
+
+ dax.sector += sc->stripe[stripe].physical_start;
+ bdev = sc->stripe[stripe].dev->bdev;
+
+ ret = bdev_direct_access(bdev, &dax);
+ *kaddr = dax.addr;
+ *pfn = dax.pfn;
+
+ return ret;
+}
+
/*
* Stripe status:
*
@@ -425,6 +449,7 @@ static struct target_type stripe_target = {
.status = stripe_status,
.iterate_devices = stripe_iterate_devices,
.io_hints = stripe_io_hints,
+ .direct_access = stripe_direct_access,
};
int __init dm_stripe_init(void)
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH] dm stripe: add DAX support
@ 2016-06-24 18:23 ` Toshi Kani
0 siblings, 0 replies; 26+ messages in thread
From: Toshi Kani @ 2016-06-24 18:23 UTC (permalink / raw)
To: snitzer-H+wXaHxf7aLQT0dZR+AlfA
Cc: linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-raid-u79uwXL29TY76Z2rM5mHXA,
dm-devel-H+wXaHxf7aLQT0dZR+AlfA, Alasdair Kergon
Change dm-stripe to implement direct_access function,
stripe_direct_access(), which maps bdev and sector and
calls direct_access function of its physical target device.
Signed-off-by: Toshi Kani <toshi.kani-ZPxbGqLxI0U@public.gmane.org>
Cc: Alasdair Kergon <agk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Dan Williams <dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: Ross Zwisler <ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
---
drivers/md/dm-stripe.c | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/drivers/md/dm-stripe.c b/drivers/md/dm-stripe.c
index 48f1c01..8925f6a 100644
--- a/drivers/md/dm-stripe.c
+++ b/drivers/md/dm-stripe.c
@@ -308,6 +308,30 @@ static int stripe_map(struct dm_target *ti, struct bio *bio)
return DM_MAPIO_REMAPPED;
}
+static long stripe_direct_access(struct dm_target *ti, sector_t sector,
+ void __pmem **kaddr, pfn_t *pfn, long size)
+{
+ struct stripe_c *sc;
+ struct block_device *bdev;
+ uint32_t stripe;
+ struct blk_dax_ctl dax = {
+ .size = size,
+ };
+ long ret;
+
+ sc = ti->private;
+ stripe_map_sector(sc, sector, &stripe, &dax.sector);
+
+ dax.sector += sc->stripe[stripe].physical_start;
+ bdev = sc->stripe[stripe].dev->bdev;
+
+ ret = bdev_direct_access(bdev, &dax);
+ *kaddr = dax.addr;
+ *pfn = dax.pfn;
+
+ return ret;
+}
+
/*
* Stripe status:
*
@@ -425,6 +449,7 @@ static struct target_type stripe_target = {
.status = stripe_status,
.iterate_devices = stripe_iterate_devices,
.io_hints = stripe_io_hints,
+ .direct_access = stripe_direct_access,
};
int __init dm_stripe_init(void)
^ permalink raw reply related [flat|nested] 26+ messages in thread
* Re: dm stripe: add DAX support
2016-06-24 18:23 ` Toshi Kani
(?)
(?)
@ 2016-06-24 18:29 ` Mike Snitzer
[not found] ` <20160624182859.GD13898-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
-1 siblings, 1 reply; 26+ messages in thread
From: Mike Snitzer @ 2016-06-24 18:29 UTC (permalink / raw)
To: Toshi Kani
Cc: linux-nvdimm, linux-kernel, linux-raid, dm-devel, Dan Williams,
Ross Zwisler, Alasdair Kergon
On Fri, Jun 24 2016 at 2:23pm -0400,
Toshi Kani <toshi.kani@hpe.com> wrote:
> Change dm-stripe to implement direct_access function,
> stripe_direct_access(), which maps bdev and sector and
> calls direct_access function of its physical target device.
>
> Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
> Cc: Alasdair Kergon <agk@redhat.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
> ---
> drivers/md/dm-stripe.c | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/drivers/md/dm-stripe.c b/drivers/md/dm-stripe.c
> index 48f1c01..8925f6a 100644
> --- a/drivers/md/dm-stripe.c
> +++ b/drivers/md/dm-stripe.c
> @@ -308,6 +308,30 @@ static int stripe_map(struct dm_target *ti, struct bio *bio)
> return DM_MAPIO_REMAPPED;
> }
>
> +static long stripe_direct_access(struct dm_target *ti, sector_t sector,
> + void __pmem **kaddr, pfn_t *pfn, long size)
> +{
> + struct stripe_c *sc;
> + struct block_device *bdev;
> + uint32_t stripe;
> + struct blk_dax_ctl dax = {
> + .size = size,
> + };
> + long ret;
> +
> + sc = ti->private;
> + stripe_map_sector(sc, sector, &stripe, &dax.sector);
> +
> + dax.sector += sc->stripe[stripe].physical_start;
> + bdev = sc->stripe[stripe].dev->bdev;
> +
> + ret = bdev_direct_access(bdev, &dax);
> + *kaddr = dax.addr;
> + *pfn = dax.pfn;
> +
> + return ret;
> +}
> +
> /*
> * Stripe status:
> *
> @@ -425,6 +449,7 @@ static struct target_type stripe_target = {
> .status = stripe_status,
> .iterate_devices = stripe_iterate_devices,
> .io_hints = stripe_io_hints,
> + .direct_access = stripe_direct_access,
> };
>
> int __init dm_stripe_init(void)
Thanks, once jens queues the block changes I'll be able to pull this in
to linux-dm.git
BTW, if in your testing you could evaluate/quantify any extra overhead
from DM that'd be useful to share. It could be there are bottlenecks
that need to be fixed, etc.
Mike
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH] dm stripe: add DAX support
@ 2016-06-24 19:58 ` kbuild test robot
0 siblings, 0 replies; 26+ messages in thread
From: kbuild test robot @ 2016-06-24 19:58 UTC (permalink / raw)
To: Toshi Kani
Cc: snitzer, linux-nvdimm, linux-kernel, linux-raid, dm-devel,
kbuild-all, Alasdair Kergon
Hi,
[auto build test WARNING on dm/for-next]
[also build test WARNING on v4.7-rc4 next-20160624]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Toshi-Kani/dm-stripe-add-DAX-support/20160625-022600
base: https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git for-next
config: m68k-sun3_defconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 4.9.0
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=m68k
All warnings (new ones prefixed by >>):
drivers/md/dm-stripe.c:452:2: error: unknown field 'direct_access' specified in initializer
.direct_access = stripe_direct_access,
^
drivers/md/dm-stripe.c:452:2: warning: missing braces around initializer [-Wmissing-braces]
drivers/md/dm-stripe.c:452:2: warning: (near initialization for 'stripe_target.list') [-Wmissing-braces]
>> drivers/md/dm-stripe.c:452:2: warning: initialization from incompatible pointer type
drivers/md/dm-stripe.c:452:2: warning: (near initialization for 'stripe_target.list.next')
vim +452 drivers/md/dm-stripe.c
436
437 blk_limits_io_min(limits, chunk_size);
438 blk_limits_io_opt(limits, chunk_size * sc->stripes);
439 }
440
441 static struct target_type stripe_target = {
442 .name = "striped",
443 .version = {1, 5, 1},
444 .module = THIS_MODULE,
445 .ctr = stripe_ctr,
446 .dtr = stripe_dtr,
447 .map = stripe_map,
448 .end_io = stripe_end_io,
449 .status = stripe_status,
450 .iterate_devices = stripe_iterate_devices,
451 .io_hints = stripe_io_hints,
> 452 .direct_access = stripe_direct_access,
453 };
454
455 int __init dm_stripe_init(void)
456 {
457 int r;
458
459 r = dm_register_target(&stripe_target);
460 if (r < 0)
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH] dm stripe: add DAX support
@ 2016-06-24 19:58 ` kbuild test robot
0 siblings, 0 replies; 26+ messages in thread
From: kbuild test robot @ 2016-06-24 19:58 UTC (permalink / raw)
To: Toshi Kani
Cc: kbuild-all, snitzer, linux-nvdimm, dm-devel, linux-raid,
linux-kernel, Toshi Kani, Alasdair Kergon, Dan Williams,
Ross Zwisler
[-- Attachment #1: Type: text/plain, Size: 2217 bytes --]
Hi,
[auto build test WARNING on dm/for-next]
[also build test WARNING on v4.7-rc4 next-20160624]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Toshi-Kani/dm-stripe-add-DAX-support/20160625-022600
base: https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git for-next
config: m68k-sun3_defconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 4.9.0
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=m68k
All warnings (new ones prefixed by >>):
drivers/md/dm-stripe.c:452:2: error: unknown field 'direct_access' specified in initializer
.direct_access = stripe_direct_access,
^
drivers/md/dm-stripe.c:452:2: warning: missing braces around initializer [-Wmissing-braces]
drivers/md/dm-stripe.c:452:2: warning: (near initialization for 'stripe_target.list') [-Wmissing-braces]
>> drivers/md/dm-stripe.c:452:2: warning: initialization from incompatible pointer type
drivers/md/dm-stripe.c:452:2: warning: (near initialization for 'stripe_target.list.next')
vim +452 drivers/md/dm-stripe.c
436
437 blk_limits_io_min(limits, chunk_size);
438 blk_limits_io_opt(limits, chunk_size * sc->stripes);
439 }
440
441 static struct target_type stripe_target = {
442 .name = "striped",
443 .version = {1, 5, 1},
444 .module = THIS_MODULE,
445 .ctr = stripe_ctr,
446 .dtr = stripe_dtr,
447 .map = stripe_map,
448 .end_io = stripe_end_io,
449 .status = stripe_status,
450 .iterate_devices = stripe_iterate_devices,
451 .io_hints = stripe_io_hints,
> 452 .direct_access = stripe_direct_access,
453 };
454
455 int __init dm_stripe_init(void)
456 {
457 int r;
458
459 r = dm_register_target(&stripe_target);
460 if (r < 0)
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 11731 bytes --]
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH] dm stripe: add DAX support
@ 2016-06-24 19:58 ` kbuild test robot
0 siblings, 0 replies; 26+ messages in thread
From: kbuild test robot @ 2016-06-24 19:58 UTC (permalink / raw)
To: Toshi Kani
Cc: snitzer-H+wXaHxf7aLQT0dZR+AlfA,
linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-raid-u79uwXL29TY76Z2rM5mHXA,
dm-devel-H+wXaHxf7aLQT0dZR+AlfA, kbuild-all-JC7UmRfGjtg,
Alasdair Kergon
Hi,
[auto build test WARNING on dm/for-next]
[also build test WARNING on v4.7-rc4 next-20160624]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Toshi-Kani/dm-stripe-add-DAX-support/20160625-022600
base: https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git for-next
config: m68k-sun3_defconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 4.9.0
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=m68k
All warnings (new ones prefixed by >>):
drivers/md/dm-stripe.c:452:2: error: unknown field 'direct_access' specified in initializer
.direct_access = stripe_direct_access,
^
drivers/md/dm-stripe.c:452:2: warning: missing braces around initializer [-Wmissing-braces]
drivers/md/dm-stripe.c:452:2: warning: (near initialization for 'stripe_target.list') [-Wmissing-braces]
>> drivers/md/dm-stripe.c:452:2: warning: initialization from incompatible pointer type
drivers/md/dm-stripe.c:452:2: warning: (near initialization for 'stripe_target.list.next')
vim +452 drivers/md/dm-stripe.c
436
437 blk_limits_io_min(limits, chunk_size);
438 blk_limits_io_opt(limits, chunk_size * sc->stripes);
439 }
440
441 static struct target_type stripe_target = {
442 .name = "striped",
443 .version = {1, 5, 1},
444 .module = THIS_MODULE,
445 .ctr = stripe_ctr,
446 .dtr = stripe_dtr,
447 .map = stripe_map,
448 .end_io = stripe_end_io,
449 .status = stripe_status,
450 .iterate_devices = stripe_iterate_devices,
451 .io_hints = stripe_io_hints,
> 452 .direct_access = stripe_direct_access,
453 };
454
455 int __init dm_stripe_init(void)
456 {
457 int r;
458
459 r = dm_register_target(&stripe_target);
460 if (r < 0)
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
^ permalink raw reply [flat|nested] 26+ messages in thread
[parent not found: <201606250312.OzHHesq4%fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]
* Re: dm stripe: add DAX support
2016-06-24 19:58 ` kbuild test robot
@ 2016-06-24 20:02 ` Mike Snitzer
-1 siblings, 0 replies; 26+ messages in thread
From: Mike Snitzer @ 2016-06-24 20:02 UTC (permalink / raw)
To: kbuild test robot
Cc: linux-nvdimm-y27Ovi1pjclAfugRpC6u6w,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-raid-u79uwXL29TY76Z2rM5mHXA,
dm-devel-H+wXaHxf7aLQT0dZR+AlfA, kbuild-all-JC7UmRfGjtg,
Alasdair Kergon
On Fri, Jun 24 2016 at 3:58pm -0400,
kbuild test robot <lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:
> Hi,
>
> [auto build test WARNING on dm/for-next]
> [also build test WARNING on v4.7-rc4 next-20160624]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url: https://github.com/0day-ci/linux/commits/Toshi-Kani/dm-stripe-add-DAX-support/20160625-022600
> base: https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git for-next
> config: m68k-sun3_defconfig (attached as .config)
> compiler: m68k-linux-gcc (GCC) 4.9.0
> reproduce:
> wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # save the attached .config to linux build tree
> make.cross ARCH=m68k
>
> All warnings (new ones prefixed by >>):
>
> drivers/md/dm-stripe.c:452:2: error: unknown field 'direct_access' specified in initializer
> .direct_access = stripe_direct_access,
> ^
> drivers/md/dm-stripe.c:452:2: warning: missing braces around initializer [-Wmissing-braces]
> drivers/md/dm-stripe.c:452:2: warning: (near initialization for 'stripe_target.list') [-Wmissing-braces]
> >> drivers/md/dm-stripe.c:452:2: warning: initialization from incompatible pointer type
> drivers/md/dm-stripe.c:452:2: warning: (near initialization for 'stripe_target.list.next')
FYI, overzealous kbuild robot build failure here.. I haven't staged the
prereq DM core changes yet because I'm waiting for Jens to take the 2
block changes those depend on.
Mike
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: dm stripe: add DAX support
@ 2016-06-24 20:02 ` Mike Snitzer
0 siblings, 0 replies; 26+ messages in thread
From: Mike Snitzer @ 2016-06-24 20:02 UTC (permalink / raw)
To: kbuild test robot
Cc: Toshi Kani, kbuild-all, linux-nvdimm, dm-devel, linux-raid,
linux-kernel, Alasdair Kergon, Dan Williams, Ross Zwisler
On Fri, Jun 24 2016 at 3:58pm -0400,
kbuild test robot <lkp@intel.com> wrote:
> Hi,
>
> [auto build test WARNING on dm/for-next]
> [also build test WARNING on v4.7-rc4 next-20160624]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url: https://github.com/0day-ci/linux/commits/Toshi-Kani/dm-stripe-add-DAX-support/20160625-022600
> base: https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git for-next
> config: m68k-sun3_defconfig (attached as .config)
> compiler: m68k-linux-gcc (GCC) 4.9.0
> reproduce:
> wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # save the attached .config to linux build tree
> make.cross ARCH=m68k
>
> All warnings (new ones prefixed by >>):
>
> drivers/md/dm-stripe.c:452:2: error: unknown field 'direct_access' specified in initializer
> .direct_access = stripe_direct_access,
> ^
> drivers/md/dm-stripe.c:452:2: warning: missing braces around initializer [-Wmissing-braces]
> drivers/md/dm-stripe.c:452:2: warning: (near initialization for 'stripe_target.list') [-Wmissing-braces]
> >> drivers/md/dm-stripe.c:452:2: warning: initialization from incompatible pointer type
> drivers/md/dm-stripe.c:452:2: warning: (near initialization for 'stripe_target.list.next')
FYI, overzealous kbuild robot build failure here.. I haven't staged the
prereq DM core changes yet because I'm waiting for Jens to take the 2
block changes those depend on.
Mike
^ permalink raw reply [flat|nested] 26+ messages in thread
[parent not found: <20160624200239.GA15587-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]
* Re: dm stripe: add DAX support
2016-06-24 20:02 ` Mike Snitzer
@ 2016-06-24 20:46 ` Kani, Toshimitsu
-1 siblings, 0 replies; 26+ messages in thread
From: Kani, Toshimitsu @ 2016-06-24 20:46 UTC (permalink / raw)
To: lkp-ral2JQCrhuEAvxtiuMwx3w, snitzer-H+wXaHxf7aLQT0dZR+AlfA
Cc: linux-nvdimm-y27Ovi1pjclAfugRpC6u6w,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-raid-u79uwXL29TY76Z2rM5mHXA,
dm-devel-H+wXaHxf7aLQT0dZR+AlfA, kbuild-all-JC7UmRfGjtg,
agk-H+wXaHxf7aLQT0dZR+AlfA
On Fri, 2016-06-24 at 16:02 -0400, Mike Snitzer wrote:
> On Fri, Jun 24 2016 at 3:58pm -0400,
> kbuild test robot <lkp@intel.com> wrote:
>
> >
> > Hi,
> >
> > [auto build test WARNING on dm/for-next]
> > [also build test WARNING on v4.7-rc4 next-20160624]
> > [if your patch is applied to the wrong git tree, please drop us a note to
> > help improve the system]
> >
> > url: https://github.com/0day-ci/linux/commits/Toshi-Kani/dm-stripe-add-
> > DAX-support/20160625-022600
> > base: https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linu
> > x-dm.git for-next
> > config: m68k-sun3_defconfig (attached as .config)
> > compiler: m68k-linux-gcc (GCC) 4.9.0
> > reproduce:
> > wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.gi
> > t/plain/sbin/make.cross -O ~/bin/make.cross
> > chmod +x ~/bin/make.cross
> > # save the attached .config to linux build tree
> > make.cross ARCH=m68k
> >
> > All warnings (new ones prefixed by >>):
> >
> > drivers/md/dm-stripe.c:452:2: error: unknown field 'direct_access'
> > specified in initializer
> > .direct_access = stripe_direct_access,
> > ^
> > drivers/md/dm-stripe.c:452:2: warning: missing braces around
> > initializer [-Wmissing-braces]
> > drivers/md/dm-stripe.c:452:2: warning: (near initialization for
> > 'stripe_target.list') [-Wmissing-braces]
> > >
> > > >
> > > > drivers/md/dm-stripe.c:452:2: warning: initialization from
> > > > incompatible pointer type
> > drivers/md/dm-stripe.c:452:2: warning: (near initialization for
> > 'stripe_target.list.next')
>
> FYI, overzealous kbuild robot build failure here.. I haven't staged the
> prereq DM core changes yet because I'm waiting for Jens to take the 2
> block changes those depend on.
This patch applies on top of wip. Could this be because 'for-next' does not
have the previous dm/dm-linear series?
Thanks,
-Toshi
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: dm stripe: add DAX support
@ 2016-06-24 20:46 ` Kani, Toshimitsu
0 siblings, 0 replies; 26+ messages in thread
From: Kani, Toshimitsu @ 2016-06-24 20:46 UTC (permalink / raw)
To: lkp, snitzer
Cc: linux-kernel, linux-nvdimm, agk, linux-raid, dan.j.williams,
kbuild-all, ross.zwisler, dm-devel
On Fri, 2016-06-24 at 16:02 -0400, Mike Snitzer wrote:
> On Fri, Jun 24 2016 at 3:58pm -0400,
> kbuild test robot <lkp@intel.com> wrote:
>
> >
> > Hi,
> >
> > [auto build test WARNING on dm/for-next]
> > [also build test WARNING on v4.7-rc4 next-20160624]
> > [if your patch is applied to the wrong git tree, please drop us a note to
> > help improve the system]
> >
> > url: https://github.com/0day-ci/linux/commits/Toshi-Kani/dm-stripe-add-
> > DAX-support/20160625-022600
> > base: https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linu
> > x-dm.git for-next
> > config: m68k-sun3_defconfig (attached as .config)
> > compiler: m68k-linux-gcc (GCC) 4.9.0
> > reproduce:
> > wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.gi
> > t/plain/sbin/make.cross -O ~/bin/make.cross
> > chmod +x ~/bin/make.cross
> > # save the attached .config to linux build tree
> > make.cross ARCH=m68k
> >
> > All warnings (new ones prefixed by >>):
> >
> > drivers/md/dm-stripe.c:452:2: error: unknown field 'direct_access'
> > specified in initializer
> > .direct_access = stripe_direct_access,
> > ^
> > drivers/md/dm-stripe.c:452:2: warning: missing braces around
> > initializer [-Wmissing-braces]
> > drivers/md/dm-stripe.c:452:2: warning: (near initialization for
> > 'stripe_target.list') [-Wmissing-braces]
> > >
> > > >
> > > > drivers/md/dm-stripe.c:452:2: warning: initialization from
> > > > incompatible pointer type
> > drivers/md/dm-stripe.c:452:2: warning: (near initialization for
> > 'stripe_target.list.next')
>
> FYI, overzealous kbuild robot build failure here.. I haven't staged the
> prereq DM core changes yet because I'm waiting for Jens to take the 2
> block changes those depend on.
This patch applies on top of wip. Could this be because 'for-next' does not
have the previous dm/dm-linear series?
Thanks,
-Toshi
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH] dm stripe: add DAX support
@ 2016-06-24 19:59 ` kbuild test robot
0 siblings, 0 replies; 26+ messages in thread
From: kbuild test robot @ 2016-06-24 19:59 UTC (permalink / raw)
To: Toshi Kani
Cc: snitzer, linux-nvdimm, linux-kernel, linux-raid, dm-devel,
kbuild-all, Alasdair Kergon
Hi,
[auto build test ERROR on dm/for-next]
[also build test ERROR on v4.7-rc4 next-20160624]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Toshi-Kani/dm-stripe-add-DAX-support/20160625-022600
base: https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git for-next
config: x86_64-randconfig-s5-06250328 (attached as .config)
compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All error/warnings (new ones prefixed by >>):
>> drivers/md/dm-stripe.c:452:2: error: unknown field 'direct_access' specified in initializer
.direct_access = stripe_direct_access,
^
>> drivers/md/dm-stripe.c:452:19: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
.direct_access = stripe_direct_access,
^~~~~~~~~~~~~~~~~~~~
drivers/md/dm-stripe.c:452:19: note: (near initialization for 'stripe_target.list.next')
>> drivers/md/dm-stripe.c:441:43: warning: missing braces around initializer [-Wmissing-braces]
static struct target_type stripe_target = {
^
drivers/md/dm-stripe.c:441:43: note: (near initialization for 'stripe_target')
cc1: some warnings being treated as errors
vim +/direct_access +452 drivers/md/dm-stripe.c
435 unsigned chunk_size = sc->chunk_size << SECTOR_SHIFT;
436
437 blk_limits_io_min(limits, chunk_size);
438 blk_limits_io_opt(limits, chunk_size * sc->stripes);
439 }
440
> 441 static struct target_type stripe_target = {
442 .name = "striped",
443 .version = {1, 5, 1},
444 .module = THIS_MODULE,
445 .ctr = stripe_ctr,
446 .dtr = stripe_dtr,
447 .map = stripe_map,
448 .end_io = stripe_end_io,
449 .status = stripe_status,
450 .iterate_devices = stripe_iterate_devices,
451 .io_hints = stripe_io_hints,
> 452 .direct_access = stripe_direct_access,
453 };
454
455 int __init dm_stripe_init(void)
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH] dm stripe: add DAX support
@ 2016-06-24 19:59 ` kbuild test robot
0 siblings, 0 replies; 26+ messages in thread
From: kbuild test robot @ 2016-06-24 19:59 UTC (permalink / raw)
To: Toshi Kani
Cc: kbuild-all, snitzer, linux-nvdimm, dm-devel, linux-raid,
linux-kernel, Toshi Kani, Alasdair Kergon, Dan Williams,
Ross Zwisler
[-- Attachment #1: Type: text/plain, Size: 2301 bytes --]
Hi,
[auto build test ERROR on dm/for-next]
[also build test ERROR on v4.7-rc4 next-20160624]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Toshi-Kani/dm-stripe-add-DAX-support/20160625-022600
base: https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git for-next
config: x86_64-randconfig-s5-06250328 (attached as .config)
compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All error/warnings (new ones prefixed by >>):
>> drivers/md/dm-stripe.c:452:2: error: unknown field 'direct_access' specified in initializer
.direct_access = stripe_direct_access,
^
>> drivers/md/dm-stripe.c:452:19: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
.direct_access = stripe_direct_access,
^~~~~~~~~~~~~~~~~~~~
drivers/md/dm-stripe.c:452:19: note: (near initialization for 'stripe_target.list.next')
>> drivers/md/dm-stripe.c:441:43: warning: missing braces around initializer [-Wmissing-braces]
static struct target_type stripe_target = {
^
drivers/md/dm-stripe.c:441:43: note: (near initialization for 'stripe_target')
cc1: some warnings being treated as errors
vim +/direct_access +452 drivers/md/dm-stripe.c
435 unsigned chunk_size = sc->chunk_size << SECTOR_SHIFT;
436
437 blk_limits_io_min(limits, chunk_size);
438 blk_limits_io_opt(limits, chunk_size * sc->stripes);
439 }
440
> 441 static struct target_type stripe_target = {
442 .name = "striped",
443 .version = {1, 5, 1},
444 .module = THIS_MODULE,
445 .ctr = stripe_ctr,
446 .dtr = stripe_dtr,
447 .map = stripe_map,
448 .end_io = stripe_end_io,
449 .status = stripe_status,
450 .iterate_devices = stripe_iterate_devices,
451 .io_hints = stripe_io_hints,
> 452 .direct_access = stripe_direct_access,
453 };
454
455 int __init dm_stripe_init(void)
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 26116 bytes --]
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH] dm stripe: add DAX support
@ 2016-06-24 19:59 ` kbuild test robot
0 siblings, 0 replies; 26+ messages in thread
From: kbuild test robot @ 2016-06-24 19:59 UTC (permalink / raw)
To: Toshi Kani
Cc: snitzer-H+wXaHxf7aLQT0dZR+AlfA,
linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-raid-u79uwXL29TY76Z2rM5mHXA,
dm-devel-H+wXaHxf7aLQT0dZR+AlfA, kbuild-all-JC7UmRfGjtg,
Alasdair Kergon
Hi,
[auto build test ERROR on dm/for-next]
[also build test ERROR on v4.7-rc4 next-20160624]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Toshi-Kani/dm-stripe-add-DAX-support/20160625-022600
base: https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git for-next
config: x86_64-randconfig-s5-06250328 (attached as .config)
compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All error/warnings (new ones prefixed by >>):
>> drivers/md/dm-stripe.c:452:2: error: unknown field 'direct_access' specified in initializer
.direct_access = stripe_direct_access,
^
>> drivers/md/dm-stripe.c:452:19: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
.direct_access = stripe_direct_access,
^~~~~~~~~~~~~~~~~~~~
drivers/md/dm-stripe.c:452:19: note: (near initialization for 'stripe_target.list.next')
>> drivers/md/dm-stripe.c:441:43: warning: missing braces around initializer [-Wmissing-braces]
static struct target_type stripe_target = {
^
drivers/md/dm-stripe.c:441:43: note: (near initialization for 'stripe_target')
cc1: some warnings being treated as errors
vim +/direct_access +452 drivers/md/dm-stripe.c
435 unsigned chunk_size = sc->chunk_size << SECTOR_SHIFT;
436
437 blk_limits_io_min(limits, chunk_size);
438 blk_limits_io_opt(limits, chunk_size * sc->stripes);
439 }
440
> 441 static struct target_type stripe_target = {
442 .name = "striped",
443 .version = {1, 5, 1},
444 .module = THIS_MODULE,
445 .ctr = stripe_ctr,
446 .dtr = stripe_dtr,
447 .map = stripe_map,
448 .end_io = stripe_end_io,
449 .status = stripe_status,
450 .iterate_devices = stripe_iterate_devices,
451 .io_hints = stripe_io_hints,
> 452 .direct_access = stripe_direct_access,
453 };
454
455 int __init dm_stripe_init(void)
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
^ permalink raw reply [flat|nested] 26+ messages in thread