From: Mark Brown <broonie@kernel.org>
To: Michal Suchanek <hramrach@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
Thomas Gleixner <tglx@linutronix.de>,
Dan Williams <dan.j.williams@intel.com>,
Tejun Heo <tj@kernel.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
Dmitry Vyukov <dvyukov@google.com>,
Adrien Schildknecht <adrien+dev@schischi.me>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-spi <linux-spi@vger.kernel.org>
Subject: Re: [PATCH 1/3] spi: spidev: fix the check for spidev in dt
Date: Sun, 26 Jun 2016 12:05:14 +0100 [thread overview]
Message-ID: <20160626110514.GI28202@sirena.org.uk> (raw)
In-Reply-To: <CAOMqctR3MDijTSr0=7tiHK+exygrGLbLQQ=GF_KAH-Y2xvb1Nw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1178 bytes --]
On Sun, Jun 26, 2016 at 04:12:10AM +0200, Michal Suchanek wrote:
> On 26 June 2016 at 03:13, Mark Brown <broonie@kernel.org> wrote:
> > On Thu, Jun 23, 2016 at 05:41:19PM -0000, Michal Suchanek wrote:
> >> The check is supposed to warn about spidev specified directly in
> >> devicetree as compatible. This just does not work. I have a devicetree
> >> with no compatible whatsoever and hacked my kernel so I can manually
> >> bind spidev. This still triggers.
> > Well, a DT device won't instantiate without a compatible string...
> > could you please explain exactly what makes you say this won't work?
> That's because the whitelist concept for this check is completely broken.
> Without any patches whatsoever I should be able to specify m25p80
> binding in the DT, let the kernel create the device, unbind the
> driver, and bind spidev.
> Then I have the jedec,spi-nor compatible which is not on the whitelist.
So, none of that is in the changelog where it needs to be and it only
makes sense if we adopt the very specific solution you are proposing.
You need to describe this change properly and you need to put it at the
end of the patch series were it makes sense.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Michal Suchanek <hramrach-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
Ingo Molnar <mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Kees Cook <keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
Dan Williams
<dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Paul E. McKenney"
<paulmck-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>,
Davidlohr Bueso <dave-h16yJtLeMjHk1uMJSBkQmQ@public.gmane.org>,
Andrey Ryabinin
<aryabinin-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org>,
Nikolay Aleksandrov
<nikolay-qUQiAmfTcIp+XZJcv9eMoEEOCMrvLtNR@public.gmane.org>,
Dmitry Vyukov <dvyukov-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Adrien Schildknecht
<adrien+dev-Yk6CzqVXkG6lnMjI0IkVqw@public.gmane.org>,
Linux Kernel Mailing List
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-spi <linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 1/3] spi: spidev: fix the check for spidev in dt
Date: Sun, 26 Jun 2016 12:05:14 +0100 [thread overview]
Message-ID: <20160626110514.GI28202@sirena.org.uk> (raw)
In-Reply-To: <CAOMqctR3MDijTSr0=7tiHK+exygrGLbLQQ=GF_KAH-Y2xvb1Nw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1207 bytes --]
On Sun, Jun 26, 2016 at 04:12:10AM +0200, Michal Suchanek wrote:
> On 26 June 2016 at 03:13, Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> > On Thu, Jun 23, 2016 at 05:41:19PM -0000, Michal Suchanek wrote:
> >> The check is supposed to warn about spidev specified directly in
> >> devicetree as compatible. This just does not work. I have a devicetree
> >> with no compatible whatsoever and hacked my kernel so I can manually
> >> bind spidev. This still triggers.
> > Well, a DT device won't instantiate without a compatible string...
> > could you please explain exactly what makes you say this won't work?
> That's because the whitelist concept for this check is completely broken.
> Without any patches whatsoever I should be able to specify m25p80
> binding in the DT, let the kernel create the device, unbind the
> driver, and bind spidev.
> Then I have the jedec,spi-nor compatible which is not on the whitelist.
So, none of that is in the changelog where it needs to be and it only
makes sense if we adopt the very specific solution you are proposing.
You need to describe this change properly and you need to put it at the
end of the patch series were it makes sense.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-06-26 11:05 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-24 14:20 [PATCH 0/3] Another stab at making spidev usable with devicetree Michal Suchanek
2016-06-24 14:20 ` Michal Suchanek
2016-06-24 14:20 ` [PATCH 1/3] spi: spidev: fix the check for spidev in dt Michal Suchanek
2016-06-26 1:09 ` Mark Brown
2016-06-26 1:56 ` Michal Suchanek
2016-06-26 1:56 ` Michal Suchanek
2016-06-26 1:13 ` Mark Brown
2016-06-26 1:13 ` Mark Brown
2016-06-26 2:12 ` Michal Suchanek
2016-06-26 2:12 ` Michal Suchanek
2016-06-26 11:05 ` Mark Brown [this message]
2016-06-26 11:05 ` Mark Brown
2016-06-24 14:20 ` [PATCH 2/3] spi: of: allow instantiating slaves without a driver Michal Suchanek
2016-06-26 1:15 ` Mark Brown
2016-06-26 1:15 ` Mark Brown
2016-06-26 2:23 ` Michal Suchanek
2016-06-26 2:23 ` Michal Suchanek
2016-06-26 11:21 ` Mark Brown
2016-06-26 11:21 ` Mark Brown
2016-06-26 11:35 ` Michal Suchanek
2016-06-26 11:58 ` Mark Brown
2016-06-26 12:39 ` Michal Suchanek
2016-06-26 12:39 ` Michal Suchanek
2016-06-26 12:45 ` Mark Brown
2016-06-26 12:45 ` Mark Brown
2016-06-26 12:53 ` Michal Suchanek
2016-06-26 12:57 ` Mark Brown
2016-06-26 12:57 ` Mark Brown
2016-06-26 15:19 ` Michal Suchanek
2016-06-26 15:19 ` Michal Suchanek
2016-06-26 17:25 ` Mark Brown
2016-06-26 17:25 ` Mark Brown
2016-06-24 14:20 ` [PATCH 3/3] drivers core: allow id match override when manually binding driver Michal Suchanek
2016-06-26 1:17 ` Mark Brown
2016-06-26 1:17 ` Mark Brown
2016-06-26 4:14 ` Dan Williams
2016-06-26 6:44 ` Michal Suchanek
2016-06-26 6:44 ` Michal Suchanek
2016-06-26 9:26 ` Geert Uytterhoeven
2016-06-26 9:26 ` Geert Uytterhoeven
2016-06-26 18:28 ` Greg Kroah-Hartman
2016-06-26 18:28 ` Greg Kroah-Hartman
2016-06-26 19:07 ` Michal Suchanek
2016-06-26 19:07 ` Michal Suchanek
2016-06-27 19:09 ` Greg Kroah-Hartman
2016-06-27 19:09 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160626110514.GI28202@sirena.org.uk \
--to=broonie@kernel.org \
--cc=adrien+dev@schischi.me \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=dan.j.williams@intel.com \
--cc=dave@stgolabs.net \
--cc=dvyukov@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hramrach@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.