All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Keerthy <j-keerthy@ti.com>
Cc: dmitry.torokhov@gmail.com, linus.walleij@linaro.org,
	gnurou@gmail.com, broonie@kernel.org, tony@atomide.com,
	linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-input@vger.kernel.org, robh+dt@kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 03/10] input: tps65218-pwrbutton: Add platform_device_id table
Date: Tue, 28 Jun 2016 07:49:48 +0100	[thread overview]
Message-ID: <20160628064948.GB6720@dell> (raw)
In-Reply-To: <1467093980-11458-4-git-send-email-j-keerthy@ti.com>

On Tue, 28 Jun 2016, Keerthy wrote:

> platform_device_id table is needed for adding the tps65218-pwrbutton
> module to the mfd_cell array.
> 
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
>  drivers/input/misc/tps65218-pwrbutton.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/input/misc/tps65218-pwrbutton.c b/drivers/input/misc/tps65218-pwrbutton.c
> index 2bba8de..a0cb7d2 100644
> --- a/drivers/input/misc/tps65218-pwrbutton.c
> +++ b/drivers/input/misc/tps65218-pwrbutton.c
> @@ -113,12 +113,19 @@ static const struct of_device_id of_tps65218_pwr_match[] = {
>  };
>  MODULE_DEVICE_TABLE(of, of_tps65218_pwr_match);
>  
> +static const struct platform_device_id tps65218_pwrbtn_id_table[] = {
> +	{ "tps65218-pwrbutton", },
> +	{ /* sentinel */ }
> +}

Missing ';'.  Did you build test this?

> +MODULE_DEVICE_TABLE(platform, tps65218_pwrbtn_id_table);
> +
>  static struct platform_driver tps65218_pwron_driver = {
>  	.probe	= tps65218_pwron_probe,
>  	.driver	= {
>  		.name	= "tps65218_pwrbutton",
>  		.of_match_table = of_tps65218_pwr_match,
>  	},
> +	.id_table = tps65218_pwrbtn_id_table,
>  };
>  module_platform_driver(tps65218_pwron_driver);
>  

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Keerthy <j-keerthy@ti.com>
Cc: dmitry.torokhov@gmail.com, linus.walleij@linaro.org,
	gnurou@gmail.com, broonie@kernel.org, tony@atomide.com,
	linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-input@vger.kernel.org, robh+dt@kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 03/10] input: tps65218-pwrbutton: Add platform_device_id table
Date: Tue, 28 Jun 2016 07:49:48 +0100	[thread overview]
Message-ID: <20160628064948.GB6720@dell> (raw)
In-Reply-To: <1467093980-11458-4-git-send-email-j-keerthy@ti.com>

On Tue, 28 Jun 2016, Keerthy wrote:

> platform_device_id table is needed for adding the tps65218-pwrbutton
> module to the mfd_cell array.
> 
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
>  drivers/input/misc/tps65218-pwrbutton.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/input/misc/tps65218-pwrbutton.c b/drivers/input/misc/tps65218-pwrbutton.c
> index 2bba8de..a0cb7d2 100644
> --- a/drivers/input/misc/tps65218-pwrbutton.c
> +++ b/drivers/input/misc/tps65218-pwrbutton.c
> @@ -113,12 +113,19 @@ static const struct of_device_id of_tps65218_pwr_match[] = {
>  };
>  MODULE_DEVICE_TABLE(of, of_tps65218_pwr_match);
>  
> +static const struct platform_device_id tps65218_pwrbtn_id_table[] = {
> +	{ "tps65218-pwrbutton", },
> +	{ /* sentinel */ }
> +}

Missing ';'.  Did you build test this?

> +MODULE_DEVICE_TABLE(platform, tps65218_pwrbtn_id_table);
> +
>  static struct platform_driver tps65218_pwron_driver = {
>  	.probe	= tps65218_pwron_probe,
>  	.driver	= {
>  		.name	= "tps65218_pwrbutton",
>  		.of_match_table = of_tps65218_pwr_match,
>  	},
> +	.id_table = tps65218_pwrbtn_id_table,
>  };
>  module_platform_driver(tps65218_pwron_driver);
>  

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 03/10] input: tps65218-pwrbutton: Add platform_device_id table
Date: Tue, 28 Jun 2016 07:49:48 +0100	[thread overview]
Message-ID: <20160628064948.GB6720@dell> (raw)
In-Reply-To: <1467093980-11458-4-git-send-email-j-keerthy@ti.com>

On Tue, 28 Jun 2016, Keerthy wrote:

> platform_device_id table is needed for adding the tps65218-pwrbutton
> module to the mfd_cell array.
> 
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
>  drivers/input/misc/tps65218-pwrbutton.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/input/misc/tps65218-pwrbutton.c b/drivers/input/misc/tps65218-pwrbutton.c
> index 2bba8de..a0cb7d2 100644
> --- a/drivers/input/misc/tps65218-pwrbutton.c
> +++ b/drivers/input/misc/tps65218-pwrbutton.c
> @@ -113,12 +113,19 @@ static const struct of_device_id of_tps65218_pwr_match[] = {
>  };
>  MODULE_DEVICE_TABLE(of, of_tps65218_pwr_match);
>  
> +static const struct platform_device_id tps65218_pwrbtn_id_table[] = {
> +	{ "tps65218-pwrbutton", },
> +	{ /* sentinel */ }
> +}

Missing ';'.  Did you build test this?

> +MODULE_DEVICE_TABLE(platform, tps65218_pwrbtn_id_table);
> +
>  static struct platform_driver tps65218_pwron_driver = {
>  	.probe	= tps65218_pwron_probe,
>  	.driver	= {
>  		.name	= "tps65218_pwrbutton",
>  		.of_match_table = of_tps65218_pwr_match,
>  	},
> +	.id_table = tps65218_pwrbtn_id_table,
>  };
>  module_platform_driver(tps65218_pwron_driver);
>  

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  parent reply	other threads:[~2016-06-28  6:49 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-28  6:06 [PATCH v3 00/10] mfd: tps65218: Clean ups Keerthy
2016-06-28  6:06 ` Keerthy
2016-06-28  6:06 ` Keerthy
2016-06-28  6:06 ` [PATCH v3 01/10] mfd: tps65218: Remove redundant read wrapper Keerthy
2016-06-28  6:06   ` Keerthy
2016-06-28  6:06   ` Keerthy
2016-06-28  7:00   ` Lee Jones
2016-06-28  7:00     ` Lee Jones
2016-06-28  7:00     ` Lee Jones
2016-06-28  7:01     ` Keerthy
2016-06-28  7:01       ` Keerthy
2016-06-28  7:01       ` Keerthy
2016-06-28  6:06 ` [PATCH v3 02/10] Documentation: regulator: tps65218: Update examples Keerthy
2016-06-28  6:06   ` Keerthy
2016-06-28  6:06   ` Keerthy
2016-06-28  6:59   ` Lee Jones
2016-06-28  6:59     ` Lee Jones
2016-06-28  6:59     ` Lee Jones
2016-06-28  7:45     ` Keerthy
2016-06-28  7:45       ` Keerthy
2016-06-28  7:45       ` Keerthy
2016-06-28  6:06 ` [PATCH v3 03/10] input: tps65218-pwrbutton: Add platform_device_id table Keerthy
2016-06-28  6:06   ` Keerthy
2016-06-28  6:06   ` Keerthy
     [not found]   ` <1467093980-11458-4-git-send-email-j-keerthy-l0cyMroinI0@public.gmane.org>
2016-06-28  6:25     ` kbuild test robot
2016-06-28  6:25       ` kbuild test robot
2016-06-28  6:25       ` kbuild test robot
2016-06-28  6:33   ` kbuild test robot
2016-06-28  6:33     ` kbuild test robot
2016-06-28  6:33     ` kbuild test robot
2016-06-28  6:49   ` Lee Jones [this message]
2016-06-28  6:49     ` Lee Jones
2016-06-28  6:49     ` Lee Jones
2016-06-28  6:55     ` Keerthy
2016-06-28  6:55       ` Keerthy
2016-06-28  6:55       ` Keerthy
2016-06-28  7:41       ` Lee Jones
2016-06-28  7:41         ` Lee Jones
2016-06-28  7:43         ` Keerthy
2016-06-28  7:43           ` Keerthy
2016-06-28  7:43           ` Keerthy
2016-06-28  6:06 ` [PATCH v3 04/10] mfd: tps65218: Use mfd_add_devices instead of of_platform_populate Keerthy
2016-06-28  6:06   ` Keerthy
2016-06-28  6:06   ` Keerthy
2016-06-28  6:54   ` Lee Jones
2016-06-28  6:54     ` Lee Jones
2016-06-28  6:54     ` Lee Jones
2016-06-28  6:06 ` [PATCH v3 05/10] regulator: tps65218: Remove all the compatibles Keerthy
2016-06-28  6:06   ` Keerthy
2016-06-28  6:06   ` Keerthy
2016-06-28  6:06 ` [PATCH v3 06/10] gpio: tps65218: Remove the compatible Keerthy
2016-06-28  6:06   ` Keerthy
2016-06-28  6:06   ` Keerthy
2016-06-28  6:52   ` Lee Jones
2016-06-28  6:52     ` Lee Jones
2016-06-28  6:52     ` Lee Jones
2016-06-28  6:59     ` Keerthy
2016-06-28  6:59       ` Keerthy
2016-06-28  6:59       ` Keerthy
2016-06-28  6:06 ` [PATCH v3 07/10] ARM: dts: AM437X-GP-EVM: Remove redundant regulator compatibles Keerthy
2016-06-28  6:06   ` Keerthy
2016-06-28  6:06   ` Keerthy
2016-06-28  6:06 ` [PATCH v3 08/10] ARM: dts: AM437X-SK-EVM: " Keerthy
2016-06-28  6:06   ` Keerthy
2016-06-28  6:06   ` Keerthy
2016-06-28  6:06 ` [PATCH v3 09/10] ARM: dts: AM437X-CM-T43: " Keerthy
2016-06-28  6:06   ` Keerthy
2016-06-28  6:06   ` Keerthy
2016-06-28  6:06 ` [PATCH v3 10/10] ARM: dts: AM43X-EPOS-EVM: " Keerthy
2016-06-28  6:06   ` Keerthy
2016-06-28  6:06   ` Keerthy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160628064948.GB6720@dell \
    --to=lee.jones@linaro.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=gnurou@gmail.com \
    --cc=j-keerthy@ti.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.