All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] efivar: force shared libgcc for Nios II
@ 2016-06-28 11:18 Erico Nunes
  2016-06-28 15:31 ` Thomas Petazzoni
  0 siblings, 1 reply; 4+ messages in thread
From: Erico Nunes @ 2016-06-28 11:18 UTC (permalink / raw)
  To: buildroot

efivar for Nios II also has to be linked with shared libgcc to avoid an
error due to FDE encoding in static libgcc when linking libefiboot.so.

Fixes:
http://autobuild.buildroot.net/results/0c9/0c90e3e7ad41d21dd832f6f266af35fc19185170/

Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
---
 package/efivar/efivar.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/efivar/efivar.mk b/package/efivar/efivar.mk
index de48bc9..ac51097 100644
--- a/package/efivar/efivar.mk
+++ b/package/efivar/efivar.mk
@@ -21,9 +21,9 @@ EFIVAR_MAKE_OPTS = \
 	BINTARGETS=efivar \
 	LDFLAGS="$(TARGET_LDFLAGS) -fPIC"
 
-# Explicitly linking with shared libgcc is required on MicroBlaze,
+# Explicitly linking with shared libgcc is required on MicroBlaze and Nios II,
 # otherwise it fails due to FDE encoding in static libgcc.
-ifeq ($(BR2_microblaze),y)
+ifeq ($(filter y,$(BR2_microblaze) $(BR2_nios2)),y)
 EFIVAR_MAKE_OPTS += SOFLAGS="-shared -shared-libgcc"
 endif
 
-- 
2.9.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 1/1] efivar: force shared libgcc for Nios II
  2016-06-28 11:18 [Buildroot] [PATCH 1/1] efivar: force shared libgcc for Nios II Erico Nunes
@ 2016-06-28 15:31 ` Thomas Petazzoni
  2016-06-30 11:09   ` Erico Nunes
  0 siblings, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2016-06-28 15:31 UTC (permalink / raw)
  To: buildroot

Hello,

On Tue, 28 Jun 2016 13:18:17 +0200, Erico Nunes wrote:

> -# Explicitly linking with shared libgcc is required on MicroBlaze,
> +# Explicitly linking with shared libgcc is required on MicroBlaze and Nios II,
>  # otherwise it fails due to FDE encoding in static libgcc.
> -ifeq ($(BR2_microblaze),y)
> +ifeq ($(filter y,$(BR2_microblaze) $(BR2_nios2)),y)

ifeq ($(BR2_microblaze)$(BR2_nios2),y)

is enough.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 1/1] efivar: force shared libgcc for Nios II
  2016-06-28 15:31 ` Thomas Petazzoni
@ 2016-06-30 11:09   ` Erico Nunes
  2016-06-30 11:59     ` Thomas Petazzoni
  0 siblings, 1 reply; 4+ messages in thread
From: Erico Nunes @ 2016-06-30 11:09 UTC (permalink / raw)
  To: buildroot

Hi Thomas.

On Tue, Jun 28, 2016 at 5:31 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> ifeq ($(BR2_microblaze)$(BR2_nios2),y)

I have submitted a v2 and marked this one as superseded.

Thank you for the review.

?rico

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 1/1] efivar: force shared libgcc for Nios II
  2016-06-30 11:09   ` Erico Nunes
@ 2016-06-30 11:59     ` Thomas Petazzoni
  0 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2016-06-30 11:59 UTC (permalink / raw)
  To: buildroot

Hello,

On Thu, 30 Jun 2016 13:09:17 +0200, Erico Nunes wrote:

> I have submitted a v2 and marked this one as superseded.

Thanks, I've seen the v2, looks good!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-06-30 11:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-28 11:18 [Buildroot] [PATCH 1/1] efivar: force shared libgcc for Nios II Erico Nunes
2016-06-28 15:31 ` Thomas Petazzoni
2016-06-30 11:09   ` Erico Nunes
2016-06-30 11:59     ` Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.