All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
	Ohad Ben-Cohen <ohad@wizery.com>,
	devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>,
	John Stultz <john.stultz@linaro.org>,
	Bjorn Andersson <bjorn.andersson@sonymobile.com>
Subject: Re: [PATCH v3 2/2] remoteproc: qcom: Introduce WCNSS peripheral image loader
Date: Tue, 28 Jun 2016 14:22:19 -0700	[thread overview]
Message-ID: <20160628212219.GG1190@tuxbot> (raw)
In-Reply-To: <115043528.GxNIb9dTCg@wuerfel>

On Tue 28 Jun 14:05 PDT 2016, Arnd Bergmann wrote:

> On Tuesday, June 28, 2016 1:58:26 PM CEST Bjorn Andersson wrote:
> > 
> > +config QCOM_WCNSS_PIL
> > +       tristate "Qualcomm WCNSS Peripheral Image Loader"
> > +       depends on OF && ARCH_QCOM
> > +       select QCOM_MDT_LOADER
> > +       select QCOM_SCM
> > +       select REMOTEPROC
> > +       help
> > +         Say y here to support the Peripherial Image Loader for the Qualcomm
> > +         Wireless Connectivity Subsystem.
> > +
> > 
> 
> 	"depends on QCOM_SMEM"
> 
> This showed up in Linux-next today and caused a build error:
> 
> drivers/remoteproc/built-in.o: In function `q6v5_fatal_interrupt':
> qcom_q6v5_pil.c:(.text+0x2428): undefined reference to `qcom_smem_get'
> drivers/remoteproc/built-in.o: In function `q6v5_wdog_interrupt':
> qcom_q6v5_pil.c:(.text+0x2498): undefined reference to `qcom_smem_get'
> 

I was convinced I had stubs for those, sorry for not making sure. I
amended rproc-next with this.

Thanks,
Bjorn

WARNING: multiple messages have this Message-ID (diff)
From: bjorn.andersson@linaro.org (Bjorn Andersson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/2] remoteproc: qcom: Introduce WCNSS peripheral image loader
Date: Tue, 28 Jun 2016 14:22:19 -0700	[thread overview]
Message-ID: <20160628212219.GG1190@tuxbot> (raw)
In-Reply-To: <115043528.GxNIb9dTCg@wuerfel>

On Tue 28 Jun 14:05 PDT 2016, Arnd Bergmann wrote:

> On Tuesday, June 28, 2016 1:58:26 PM CEST Bjorn Andersson wrote:
> > 
> > +config QCOM_WCNSS_PIL
> > +       tristate "Qualcomm WCNSS Peripheral Image Loader"
> > +       depends on OF && ARCH_QCOM
> > +       select QCOM_MDT_LOADER
> > +       select QCOM_SCM
> > +       select REMOTEPROC
> > +       help
> > +         Say y here to support the Peripherial Image Loader for the Qualcomm
> > +         Wireless Connectivity Subsystem.
> > +
> > 
> 
> 	"depends on QCOM_SMEM"
> 
> This showed up in Linux-next today and caused a build error:
> 
> drivers/remoteproc/built-in.o: In function `q6v5_fatal_interrupt':
> qcom_q6v5_pil.c:(.text+0x2428): undefined reference to `qcom_smem_get'
> drivers/remoteproc/built-in.o: In function `q6v5_wdog_interrupt':
> qcom_q6v5_pil.c:(.text+0x2498): undefined reference to `qcom_smem_get'
> 

I was convinced I had stubs for those, sorry for not making sure. I
amended rproc-next with this.

Thanks,
Bjorn

  reply	other threads:[~2016-06-28 21:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-28 20:58 [PATCH v3 1/2] dt-binding: remoteproc: Introduce Qualcomm WCNSS loader binding Bjorn Andersson
2016-06-28 20:58 ` Bjorn Andersson
2016-06-28 20:58 ` Bjorn Andersson
2016-06-28 20:58 ` [PATCH v3 2/2] remoteproc: qcom: Introduce WCNSS peripheral image loader Bjorn Andersson
2016-06-28 20:58   ` Bjorn Andersson
2016-06-28 20:58   ` Bjorn Andersson
2016-06-28 21:05   ` Arnd Bergmann
2016-06-28 21:05     ` Arnd Bergmann
2016-06-28 21:05     ` Arnd Bergmann
2016-06-28 21:22     ` Bjorn Andersson [this message]
2016-06-28 21:22       ` Bjorn Andersson
2016-06-29 16:26   ` Srinivas Kandagatla
2016-06-29 16:26     ` Srinivas Kandagatla
2016-06-30  5:57     ` Bjorn Andersson
2016-06-30  5:57       ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160628212219.GG1190@tuxbot \
    --to=bjorn.andersson@linaro.org \
    --cc=arnd@arndb.de \
    --cc=bjorn.andersson@sonymobile.com \
    --cc=devicetree@vger.kernel.org \
    --cc=john.stultz@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=ohad@wizery.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.