From: David Miller <davem@davemloft.net>
To: Yisen.Zhuang@huawei.com
Cc: salil.mehta@huawei.com, yankejian@huawei.com,
liguozhu@huawei.com, huangdaode@hisilicon.com, arnd@arndb.de,
andriy.shevchenko@linux.intel.com, andrew@lunn.ch,
geliangtang@163.com, ivecera@redhat.com, fengguang.wu@intel.com,
charles.chenxin@huawei.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linuxarm@huawei.com
Subject: Re: [PATCH net-next 9/9] net: hns: get reset registers from DT
Date: Wed, 29 Jun 2016 05:11:42 -0400 (EDT) [thread overview]
Message-ID: <20160629.051142.259737654994822294.davem@davemloft.net> (raw)
In-Reply-To: <1467021255-95900-10-git-send-email-Yisen.Zhuang@huawei.com>
From: Yisen Zhuang <Yisen.Zhuang@huawei.com>
Date: Mon, 27 Jun 2016 17:54:15 +0800
> @@ -361,9 +371,10 @@ static int hns_mdio_reset(struct mii_bus *bus)
> return -ENODEV;
> }
>
> + sc_reg = &mdio_dev->sc_reg;
> /* 1. reset req, and read reset st check */
> - ret = mdio_sc_cfg_reg_write(mdio_dev, MDIO_SC_RESET_REQ, 0x1,
> - MDIO_SC_RESET_ST, 0x1,
> + ret = mdio_sc_cfg_reg_write(mdio_dev, sc_reg->mdio_reset_req, 0x1,
> + sc_reg->mdio_reset_st, 0x1,
> MDIO_CHECK_SET_ST);
> if (ret) {
> dev_err(&bus->dev, "MDIO reset fail\n");
What in the world are you doing to the indentation here?
Please read your patches before actually sending them, such things
will be quite obvious by simple visual inspection.
WARNING: multiple messages have this Message-ID (diff)
From: davem@davemloft.net (David Miller)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH net-next 9/9] net: hns: get reset registers from DT
Date: Wed, 29 Jun 2016 05:11:42 -0400 (EDT) [thread overview]
Message-ID: <20160629.051142.259737654994822294.davem@davemloft.net> (raw)
In-Reply-To: <1467021255-95900-10-git-send-email-Yisen.Zhuang@huawei.com>
From: Yisen Zhuang <Yisen.Zhuang@huawei.com>
Date: Mon, 27 Jun 2016 17:54:15 +0800
> @@ -361,9 +371,10 @@ static int hns_mdio_reset(struct mii_bus *bus)
> return -ENODEV;
> }
>
> + sc_reg = &mdio_dev->sc_reg;
> /* 1. reset req, and read reset st check */
> - ret = mdio_sc_cfg_reg_write(mdio_dev, MDIO_SC_RESET_REQ, 0x1,
> - MDIO_SC_RESET_ST, 0x1,
> + ret = mdio_sc_cfg_reg_write(mdio_dev, sc_reg->mdio_reset_req, 0x1,
> + sc_reg->mdio_reset_st, 0x1,
> MDIO_CHECK_SET_ST);
> if (ret) {
> dev_err(&bus->dev, "MDIO reset fail\n");
What in the world are you doing to the indentation here?
Please read your patches before actually sending them, such things
will be quite obvious by simple visual inspection.
next prev parent reply other threads:[~2016-06-29 9:12 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 9:54 [PATCH net-next 0/9] net: hns: fix the typo of hns Yisen Zhuang
2016-06-27 9:54 ` Yisen Zhuang
2016-06-27 9:54 ` Yisen Zhuang
2016-06-27 9:54 ` [PATCH net-next 1/9] MAINTAINERS: add maintainers for hns driver Yisen Zhuang
2016-06-27 9:54 ` Yisen Zhuang
2016-06-27 9:54 ` Yisen Zhuang
2016-06-27 9:54 ` [PATCH net-next 2/9] net: hns: fix code style about " Yisen Zhuang
2016-06-27 9:54 ` Yisen Zhuang
2016-06-27 9:54 ` [PATCH net-next 3/9] net: hns: change code style from a = a + x to a += x Yisen Zhuang
2016-06-27 9:54 ` Yisen Zhuang
2016-06-27 9:54 ` [PATCH net-next 4/9] net: hns: delete redundant parens Yisen Zhuang
2016-06-27 9:54 ` Yisen Zhuang
2016-06-27 9:54 ` Yisen Zhuang
2016-06-27 9:54 ` [PATCH net-next 5/9] net: hns: add a space before "*/" Yisen Zhuang
2016-06-27 9:54 ` Yisen Zhuang
2016-06-27 9:54 ` [PATCH net-next 6/9] net: hns: normalize two different loop Yisen Zhuang
2016-06-27 9:54 ` Yisen Zhuang
2016-06-27 11:49 ` Joe Perches
2016-06-27 11:49 ` Joe Perches
2016-06-27 12:00 ` Andy Shevchenko
2016-06-27 12:00 ` Andy Shevchenko
2016-06-27 12:08 ` Joe Perches
2016-06-27 12:08 ` Joe Perches
2016-06-27 12:13 ` Andy Shevchenko
2016-06-27 12:13 ` Andy Shevchenko
2016-06-28 5:41 ` Daode Huang
2016-06-28 5:41 ` Daode Huang
2016-06-27 9:54 ` [PATCH net-next 7/9] net: hns: remove redundant hns_mac_dev_to_enet_if() Yisen Zhuang
2016-06-27 9:54 ` Yisen Zhuang
2016-06-27 9:54 ` [PATCH net-next 8/9] net: hns: add media-type property for hns Yisen Zhuang
2016-06-27 9:54 ` Yisen Zhuang
2016-06-27 9:54 ` [PATCH net-next 9/9] net: hns: get reset registers from DT Yisen Zhuang
2016-06-27 9:54 ` Yisen Zhuang
2016-06-29 9:11 ` David Miller [this message]
2016-06-29 9:11 ` David Miller
2016-06-30 1:10 ` Yankejian (Hackim Yim)
2016-06-30 1:10 ` Yankejian (Hackim Yim)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160629.051142.259737654994822294.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Yisen.Zhuang@huawei.com \
--cc=andrew@lunn.ch \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=charles.chenxin@huawei.com \
--cc=fengguang.wu@intel.com \
--cc=geliangtang@163.com \
--cc=huangdaode@hisilicon.com \
--cc=ivecera@redhat.com \
--cc=liguozhu@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=yankejian@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.