All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linux-nvme@lists.infradead.org,
	virtualization@lists.linux-foundation.org,
	Keith Busch <keith.busch@intel.com>,
	Paul Mackerras <paulus@samba.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Shaohua Li <shli@kernel.org>, Nitin Gupta <ngupta@vflare.org>,
	Jiri Kosina <jikos@kernel.org>,
	linux-block@vger.kernel.org, dan.j.williams@intel.com,
	"Ed L. Cashin" <ed.cashin@acm.org>, Jens Axboe <axboe@kernel.dk>,
	linux-raid@vger.kernel.org, David Woodhouse <dwmw2@infradead.org>,
	linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Minchan Kim <minchan@kernel.org>,
	linux-mtd@lists.infradead.org,
	Brian Norris <computersforpeace@gmail.com>,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 00/12] gendisk: Generate uevent after attribute available
Date: Thu, 30 Jun 2016 14:35:54 +0800	[thread overview]
Message-ID: <20160630063554.GE23296@ad.usersys.redhat.com> (raw)
In-Reply-To: <20160630062442.GA19761@infradead.org>

On Wed, 06/29 23:24, Christoph Hellwig wrote:
> On Thu, Jun 30, 2016 at 09:59:41AM +0800, Fam Zheng wrote:
> > Documentation/kobject.txt:
> > > Use the KOBJ_ADD action for when the kobject is first added to the kernel.
> > > This should be done only after any attributes or children of the kobject
> > > have been initialized properly, as userspace will instantly start to look
> > > for them when this call happens.
> > 
> > Unfortunately it seems impossible to fix this generally without touching the
> > offending callers.  The approach I'm proposing here is adding a flag to
> > suppress uevent in add_disk(), which is patch 1, then in later patches, convert
> > any caller to only trigger the uevent when attributes are added.
> 
> We (or rather Dan) is touching most add_disk callers anyway for the
> driverfs_dev removal.  Let's just pass the array of attributes to
> a disk_add variant and solve the issue for real.

I thought about that. Its usage is more compact compared to this series, but is
also more code and less flexible IMO.  For example, we need at least two
variants, for attribute_group and device_attribute separately, right?

Fam

WARNING: multiple messages have this Message-ID (diff)
From: Fam Zheng <famz@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Jens Axboe <axboe@kernel.dk>, "Ed L. Cashin" <ed.cashin@acm.org>,
	Jiri Kosina <jikos@kernel.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Minchan Kim <minchan@kernel.org>, Nitin Gupta <ngupta@vflare.org>,
	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
	Shaohua Li <shli@kernel.org>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Brian Norris <computersforpeace@gmail.com>,
	Keith Busch <keith.busch@intel.com>,
	linuxppc-dev@lists.ozlabs.org, linux-block@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org,
	dan.j.williams@intel.com
Subject: Re: [PATCH v2 00/12] gendisk: Generate uevent after attribute available
Date: Thu, 30 Jun 2016 14:35:54 +0800	[thread overview]
Message-ID: <20160630063554.GE23296@ad.usersys.redhat.com> (raw)
In-Reply-To: <20160630062442.GA19761@infradead.org>

On Wed, 06/29 23:24, Christoph Hellwig wrote:
> On Thu, Jun 30, 2016 at 09:59:41AM +0800, Fam Zheng wrote:
> > Documentation/kobject.txt:
> > > Use the KOBJ_ADD action for when the kobject is first added to the kernel.
> > > This should be done only after any attributes or children of the kobject
> > > have been initialized properly, as userspace will instantly start to look
> > > for them when this call happens.
> > 
> > Unfortunately it seems impossible to fix this generally without touching the
> > offending callers.  The approach I'm proposing here is adding a flag to
> > suppress uevent in add_disk(), which is patch 1, then in later patches, convert
> > any caller to only trigger the uevent when attributes are added.
> 
> We (or rather Dan) is touching most add_disk callers anyway for the
> driverfs_dev removal.  Let's just pass the array of attributes to
> a disk_add variant and solve the issue for real.

I thought about that. Its usage is more compact compared to this series, but is
also more code and less flexible IMO.  For example, we need at least two
variants, for attribute_group and device_attribute separately, right?

Fam

WARNING: multiple messages have this Message-ID (diff)
From: famz@redhat.com (Fam Zheng)
Subject: [PATCH v2 00/12] gendisk: Generate uevent after attribute available
Date: Thu, 30 Jun 2016 14:35:54 +0800	[thread overview]
Message-ID: <20160630063554.GE23296@ad.usersys.redhat.com> (raw)
In-Reply-To: <20160630062442.GA19761@infradead.org>

On Wed, 06/29 23:24, Christoph Hellwig wrote:
> On Thu, Jun 30, 2016@09:59:41AM +0800, Fam Zheng wrote:
> > Documentation/kobject.txt:
> > > Use the KOBJ_ADD action for when the kobject is first added to the kernel.
> > > This should be done only after any attributes or children of the kobject
> > > have been initialized properly, as userspace will instantly start to look
> > > for them when this call happens.
> > 
> > Unfortunately it seems impossible to fix this generally without touching the
> > offending callers.  The approach I'm proposing here is adding a flag to
> > suppress uevent in add_disk(), which is patch 1, then in later patches, convert
> > any caller to only trigger the uevent when attributes are added.
> 
> We (or rather Dan) is touching most add_disk callers anyway for the
> driverfs_dev removal.  Let's just pass the array of attributes to
> a disk_add variant and solve the issue for real.

I thought about that. Its usage is more compact compared to this series, but is
also more code and less flexible IMO.  For example, we need at least two
variants, for attribute_group and device_attribute separately, right?

Fam

  reply	other threads:[~2016-06-30  6:35 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-30  1:59 [PATCH v2 00/12] gendisk: Generate uevent after attribute available Fam Zheng
2016-06-30  1:59 ` Fam Zheng
2016-06-30  1:59 ` Fam Zheng
2016-06-30  1:59 ` [PATCH v2 01/12] genhd: Add "gen_uevent" parameter to add_disk Fam Zheng
2016-06-30  1:59   ` Fam Zheng
2016-06-30  1:59   ` Fam Zheng
2016-06-30  1:59 ` [PATCH v2 02/12] genhd: Honor gen_uevent and add disk_gen_uevents Fam Zheng
2016-06-30  1:59   ` Fam Zheng
2016-06-30  1:59   ` Fam Zheng
2016-06-30  3:26   ` kbuild test robot
2016-06-30  3:26     ` kbuild test robot
2016-06-30  3:26     ` kbuild test robot
2016-06-30  1:59 ` [PATCH v2 03/12] virtio-blk: Generate uevent after attribute available Fam Zheng
2016-06-30  1:59   ` Fam Zheng
2016-06-30  1:59   ` Fam Zheng
2016-06-30  1:59 ` [PATCH v2 04/12] axonrom: " Fam Zheng
2016-06-30  1:59   ` Fam Zheng
2016-06-30  1:59   ` Fam Zheng
2016-06-30 22:10   ` Dan Williams
2016-06-30 22:10     ` Dan Williams
2016-06-30 22:10     ` Dan Williams
2016-07-01  1:03     ` Fam Zheng
2016-07-01  1:03       ` Fam Zheng
2016-07-01  1:03       ` Fam Zheng
2016-06-30 22:10   ` Dan Williams
2016-06-30  1:59 ` [PATCH v2 05/12] aoeblk: " Fam Zheng
2016-06-30  1:59   ` Fam Zheng
2016-06-30  1:59   ` Fam Zheng
2016-07-01  0:57   ` Ed Cashin
2016-07-01  0:57     ` Ed Cashin
2016-07-01  0:57     ` Ed Cashin
2016-07-01  0:57   ` Ed Cashin
2016-06-30  1:59 ` [PATCH v2 06/12] mtip32xx: " Fam Zheng
2016-06-30  1:59   ` Fam Zheng
2016-06-30  1:59   ` Fam Zheng
2016-06-30  1:59 ` [PATCH v2 07/12] pktcdvd: " Fam Zheng
2016-06-30  1:59   ` Fam Zheng
2016-06-30  1:59   ` Fam Zheng
2016-06-30  1:59 ` [PATCH v2 08/12] zram: " Fam Zheng
2016-06-30  1:59   ` Fam Zheng
2016-06-30  1:59   ` Fam Zheng
2016-06-30  1:59 ` [PATCH v2 09/12] md: " Fam Zheng
2016-06-30  1:59 ` Fam Zheng
2016-06-30  1:59   ` Fam Zheng
2016-06-30  1:59 ` [PATCH v2 10/12] mmc: " Fam Zheng
2016-06-30  1:59 ` Fam Zheng
2016-06-30  1:59   ` Fam Zheng
2016-06-30  1:59 ` [PATCH v2 11/12] mtd: " Fam Zheng
2016-06-30  1:59 ` Fam Zheng
2016-06-30  1:59   ` Fam Zheng
2016-06-30  1:59 ` [PATCH v2 12/12] nvme: " Fam Zheng
2016-06-30  1:59 ` Fam Zheng
2016-06-30  1:59   ` Fam Zheng
2016-06-30  6:24 ` [PATCH v2 00/12] gendisk: " Christoph Hellwig
2016-06-30  6:24   ` Christoph Hellwig
2016-06-30  6:24   ` Christoph Hellwig
2016-06-30  6:24   ` Christoph Hellwig
2016-06-30  6:35   ` Fam Zheng [this message]
2016-06-30  6:35     ` Fam Zheng
2016-06-30  6:35     ` Fam Zheng
2016-06-30  6:38     ` Christoph Hellwig
2016-06-30  6:38       ` Christoph Hellwig
2016-06-30  6:38       ` Christoph Hellwig
2016-07-01  1:01       ` Fam Zheng
2016-07-01  1:01         ` Fam Zheng
2016-07-01  1:01         ` Fam Zheng
2016-07-01  1:29         ` Dan Williams
2016-07-01  1:29         ` Dan Williams
2016-07-01  1:29           ` Dan Williams
2016-07-01  1:29           ` Dan Williams
2016-07-01  1:29           ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160630063554.GE23296@ad.usersys.redhat.com \
    --to=famz@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=benh@kernel.crashing.org \
    --cc=computersforpeace@gmail.com \
    --cc=dan.j.williams@intel.com \
    --cc=dwmw2@infradead.org \
    --cc=ed.cashin@acm.org \
    --cc=hch@infradead.org \
    --cc=jikos@kernel.org \
    --cc=keith.busch@intel.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=minchan@kernel.org \
    --cc=mpe@ellerman.id.au \
    --cc=mst@redhat.com \
    --cc=ngupta@vflare.org \
    --cc=paulus@samba.org \
    --cc=sergey.senozhatsky.work@gmail.com \
    --cc=shli@kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.