drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c:1812: possible pointless variable ?

drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c:1812: possible pointless variable ?

[David Binderman]

Hello there,

linux-4.7-rc5/drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c:1812]:
(style) Variable 'stretch_amount2' is assigned a value that is never
used.

Source code is

    else if (stretch_amount == 3 || stretch_amount == 4)
        stretch_amount2 = 1;

Suggest either use the variable in some way, or delete it.

Regards

David Binderman

[PATCH] Remove unused variable

[Matthias Beyer]

Hi,

after reading your email, I created this patch.

**Please note all**: I'm getting into kernel dev right now (again), so I don't
even know how to test-compile this patch, let alone testing it.

You're more than welcome to teach me things.

Matthias Beyer (1):
  drivers: gpu: drm: amd: powerplay: hwmgr: Remove unused variable

 drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

-- 
2.9.0

[PATCH] drivers: gpu: drm: amd: powerplay: hwmgr: Remove unused variable

[Matthias Beyer]

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
---
 drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c
index 64ee78f..1dcd52d 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c
@@ -1761,7 +1761,7 @@ static int polaris10_populate_clock_stretcher_data_table(struct pp_hwmgr *hwmgr)
 {
 	uint32_t ro, efuse, volt_without_cks, volt_with_cks, value, max, min;
 	struct polaris10_hwmgr *data = (struct polaris10_hwmgr *)(hwmgr->backend);
-	uint8_t i, stretch_amount, stretch_amount2, volt_offset = 0;
+	uint8_t i, stretch_amount, volt_offset = 0;
 	struct phm_ppt_v1_information *table_info =
 			(struct phm_ppt_v1_information *)(hwmgr->pptable);
 	struct phm_ppt_v1_clock_voltage_dependency_table *sclk_table =
@@ -1806,11 +1806,8 @@ static int polaris10_populate_clock_stretcher_data_table(struct pp_hwmgr *hwmgr)
 	}
 
 	/* Populate CKS Lookup Table */
-	if (stretch_amount == 1 || stretch_amount == 2 || stretch_amount == 5)
-		stretch_amount2 = 0;
-	else if (stretch_amount == 3 || stretch_amount == 4)
-		stretch_amount2 = 1;
-	else {
+	if (stretch_amount != 1 && stretch_amount != 2 && stretch_amount != 3 &&
+			stretch_amount != 4 && stretch_amount != 5) {
 		phm_cap_unset(hwmgr->platform_descriptor.platformCaps,
 				PHM_PlatformCaps_ClockStretcher);
 		PP_ASSERT_WITH_CODE(false,
-- 
2.9.0

Re: [PATCH] drivers: gpu: drm: amd: powerplay: hwmgr: Remove unused variable

[Zhu, Rex]

[-- Attachment #1.1: Type: text/plain, Size: 2403 bytes --]


Yes, stretch_amount2 was not used on Polaris.


Patch was Reviewed-by: Rex Zhu <Rex.Zhu@amd.com>


Thanks.


Best Regards

Rex

________________________________
From: Matthias Beyer <mail@beyermatthias.de>
Sent: Friday, July 1, 2016 12:38:49 AM
To: linuxdev.baldrick@gmail.com
Cc: Deucher, Alexander; Koenig, Christian; airlied@linux.ie; dri-devel@lists.freedesktop.org; dcb314@hotmail.com; linux-kernel@vger.kernel.org; Zhu, Rex; Huang, JinHuiEric; nils.wallmenius@gmail.com; Matthias Beyer
Subject: [PATCH] drivers: gpu: drm: amd: powerplay: hwmgr: Remove unused variable

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
---
 drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c
index 64ee78f..1dcd52d 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c
@@ -1761,7 +1761,7 @@ static int polaris10_populate_clock_stretcher_data_table(struct pp_hwmgr *hwmgr)
 {
         uint32_t ro, efuse, volt_without_cks, volt_with_cks, value, max, min;
         struct polaris10_hwmgr *data = (struct polaris10_hwmgr *)(hwmgr->backend);
-       uint8_t i, stretch_amount, stretch_amount2, volt_offset = 0;
+       uint8_t i, stretch_amount, volt_offset = 0;
         struct phm_ppt_v1_information *table_info =
                         (struct phm_ppt_v1_information *)(hwmgr->pptable);
         struct phm_ppt_v1_clock_voltage_dependency_table *sclk_table =
@@ -1806,11 +1806,8 @@ static int polaris10_populate_clock_stretcher_data_table(struct pp_hwmgr *hwmgr)
         }

         /* Populate CKS Lookup Table */
-       if (stretch_amount == 1 || stretch_amount == 2 || stretch_amount == 5)
-               stretch_amount2 = 0;
-       else if (stretch_amount == 3 || stretch_amount == 4)
-               stretch_amount2 = 1;
-       else {
+       if (stretch_amount != 1 && stretch_amount != 2 && stretch_amount != 3 &&
+                       stretch_amount != 4 && stretch_amount != 5) {
                 phm_cap_unset(hwmgr->platform_descriptor.platformCaps,
                                 PHM_PlatformCaps_ClockStretcher);
                 PP_ASSERT_WITH_CODE(false,
--
2.9.0


[-- Attachment #1.2: Type: text/html, Size: 5817 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drivers: gpu: drm: amd: powerplay: hwmgr: Remove unused variable

[Matthias Beyer]

[-- Attachment #1: Type: text/plain, Size: 2931 bytes --]

Hi list,

I just wondered: I send the patch >14 days ago, 9 days ago it was 
reviewed by Rex Zhu. As far as I know, it isn't applied by now. At 
least I did not get a mail indicating that it was applied.

Are there issues with the patch I missed?

On 05-07-2016 15:06:59, Zhu, Rex wrote:
> 
> Yes, stretch_amount2 was not used on Polaris.
> 
> 
> Patch was Reviewed-by: Rex Zhu <Rex.Zhu@amd.com>
> 
> 
> Thanks.
> 
> 
> Best Regards
> 
> Rex
> 
> ________________________________
> From: Matthias Beyer <mail@beyermatthias.de>
> Sent: Friday, July 1, 2016 12:38:49 AM
> To: linuxdev.baldrick@gmail.com
> Cc: Deucher, Alexander; Koenig, Christian; airlied@linux.ie; dri-devel@lists.freedesktop.org; dcb314@hotmail.com; linux-kernel@vger.kernel.org; Zhu, Rex; Huang, JinHuiEric; nils.wallmenius@gmail.com; Matthias Beyer
> Subject: [PATCH] drivers: gpu: drm: amd: powerplay: hwmgr: Remove unused variable
> 
> Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
> ---
>  drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c
> index 64ee78f..1dcd52d 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c
> @@ -1761,7 +1761,7 @@ static int polaris10_populate_clock_stretcher_data_table(struct pp_hwmgr *hwmgr)
>  {
>          uint32_t ro, efuse, volt_without_cks, volt_with_cks, value, max, min;
>          struct polaris10_hwmgr *data = (struct polaris10_hwmgr *)(hwmgr->backend);
> -       uint8_t i, stretch_amount, stretch_amount2, volt_offset = 0;
> +       uint8_t i, stretch_amount, volt_offset = 0;
>          struct phm_ppt_v1_information *table_info =
>                          (struct phm_ppt_v1_information *)(hwmgr->pptable);
>          struct phm_ppt_v1_clock_voltage_dependency_table *sclk_table =
> @@ -1806,11 +1806,8 @@ static int polaris10_populate_clock_stretcher_data_table(struct pp_hwmgr *hwmgr)
>          }
> 
>          /* Populate CKS Lookup Table */
> -       if (stretch_amount == 1 || stretch_amount == 2 || stretch_amount == 5)
> -               stretch_amount2 = 0;
> -       else if (stretch_amount == 3 || stretch_amount == 4)
> -               stretch_amount2 = 1;
> -       else {
> +       if (stretch_amount != 1 && stretch_amount != 2 && stretch_amount != 3 &&
> +                       stretch_amount != 4 && stretch_amount != 5) {
>                  phm_cap_unset(hwmgr->platform_descriptor.platformCaps,
>                                  PHM_PlatformCaps_ClockStretcher);
>                  PP_ASSERT_WITH_CODE(false,
> --
> 2.9.0
> 

-- 
Mit freundlichen Grüßen,
Kind regards,
Matthias Beyer

Proudly sent with mutt.
Happily signed with gnupg.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] drivers: gpu: drm: amd: powerplay: hwmgr: Remove unused variable

[Alex Deucher]

On Thu, Jul 14, 2016 at 1:22 PM, Matthias Beyer <mail@beyermatthias.de> wrote:
> Hi list,
>
> I just wondered: I send the patch >14 days ago, 9 days ago it was
> reviewed by Rex Zhu. As far as I know, it isn't applied by now. At
> least I did not get a mail indicating that it was applied.
>
> Are there issues with the patch I missed?

Applied.  Sorry for the delay.

Alex

>
> On 05-07-2016 15:06:59, Zhu, Rex wrote:
>>
>> Yes, stretch_amount2 was not used on Polaris.
>>
>>
>> Patch was Reviewed-by: Rex Zhu <Rex.Zhu@amd.com>
>>
>>
>> Thanks.
>>
>>
>> Best Regards
>>
>> Rex
>>
>> ________________________________
>> From: Matthias Beyer <mail@beyermatthias.de>
>> Sent: Friday, July 1, 2016 12:38:49 AM
>> To: linuxdev.baldrick@gmail.com
>> Cc: Deucher, Alexander; Koenig, Christian; airlied@linux.ie; dri-devel@lists.freedesktop.org; dcb314@hotmail.com; linux-kernel@vger.kernel.org; Zhu, Rex; Huang, JinHuiEric; nils.wallmenius@gmail.com; Matthias Beyer
>> Subject: [PATCH] drivers: gpu: drm: amd: powerplay: hwmgr: Remove unused variable
>>
>> Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
>> ---
>>  drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c | 9 +++------
>>  1 file changed, 3 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c
>> index 64ee78f..1dcd52d 100644
>> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c
>> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c
>> @@ -1761,7 +1761,7 @@ static int polaris10_populate_clock_stretcher_data_table(struct pp_hwmgr *hwmgr)
>>  {
>>          uint32_t ro, efuse, volt_without_cks, volt_with_cks, value, max, min;
>>          struct polaris10_hwmgr *data = (struct polaris10_hwmgr *)(hwmgr->backend);
>> -       uint8_t i, stretch_amount, stretch_amount2, volt_offset = 0;
>> +       uint8_t i, stretch_amount, volt_offset = 0;
>>          struct phm_ppt_v1_information *table_info =
>>                          (struct phm_ppt_v1_information *)(hwmgr->pptable);
>>          struct phm_ppt_v1_clock_voltage_dependency_table *sclk_table =
>> @@ -1806,11 +1806,8 @@ static int polaris10_populate_clock_stretcher_data_table(struct pp_hwmgr *hwmgr)
>>          }
>>
>>          /* Populate CKS Lookup Table */
>> -       if (stretch_amount == 1 || stretch_amount == 2 || stretch_amount == 5)
>> -               stretch_amount2 = 0;
>> -       else if (stretch_amount == 3 || stretch_amount == 4)
>> -               stretch_amount2 = 1;
>> -       else {
>> +       if (stretch_amount != 1 && stretch_amount != 2 && stretch_amount != 3 &&
>> +                       stretch_amount != 4 && stretch_amount != 5) {
>>                  phm_cap_unset(hwmgr->platform_descriptor.platformCaps,
>>                                  PHM_PlatformCaps_ClockStretcher);
>>                  PP_ASSERT_WITH_CODE(false,
>> --
>> 2.9.0
>>
>
> --
> Mit freundlichen Grüßen,
> Kind regards,
> Matthias Beyer
>
> Proudly sent with mutt.
> Happily signed with gnupg.
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>

Re: [PATCH] drivers: gpu: drm: amd: powerplay: hwmgr: Remove unused variable

[Alex Deucher]

On Thu, Jul 14, 2016 at 1:22 PM, Matthias Beyer <mail@beyermatthias.de> wrote:
> Hi list,
>
> I just wondered: I send the patch >14 days ago, 9 days ago it was
> reviewed by Rex Zhu. As far as I know, it isn't applied by now. At
> least I did not get a mail indicating that it was applied.
>
> Are there issues with the patch I missed?

Applied.  Sorry for the delay.

Alex

>
> On 05-07-2016 15:06:59, Zhu, Rex wrote:
>>
>> Yes, stretch_amount2 was not used on Polaris.
>>
>>
>> Patch was Reviewed-by: Rex Zhu <Rex.Zhu@amd.com>
>>
>>
>> Thanks.
>>
>>
>> Best Regards
>>
>> Rex
>>
>> ________________________________
>> From: Matthias Beyer <mail@beyermatthias.de>
>> Sent: Friday, July 1, 2016 12:38:49 AM
>> To: linuxdev.baldrick@gmail.com
>> Cc: Deucher, Alexander; Koenig, Christian; airlied@linux.ie; dri-devel@lists.freedesktop.org; dcb314@hotmail.com; linux-kernel@vger.kernel.org; Zhu, Rex; Huang, JinHuiEric; nils.wallmenius@gmail.com; Matthias Beyer
>> Subject: [PATCH] drivers: gpu: drm: amd: powerplay: hwmgr: Remove unused variable
>>
>> Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
>> ---
>>  drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c | 9 +++------
>>  1 file changed, 3 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c
>> index 64ee78f..1dcd52d 100644
>> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c
>> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c
>> @@ -1761,7 +1761,7 @@ static int polaris10_populate_clock_stretcher_data_table(struct pp_hwmgr *hwmgr)
>>  {
>>          uint32_t ro, efuse, volt_without_cks, volt_with_cks, value, max, min;
>>          struct polaris10_hwmgr *data = (struct polaris10_hwmgr *)(hwmgr->backend);
>> -       uint8_t i, stretch_amount, stretch_amount2, volt_offset = 0;
>> +       uint8_t i, stretch_amount, volt_offset = 0;
>>          struct phm_ppt_v1_information *table_info =
>>                          (struct phm_ppt_v1_information *)(hwmgr->pptable);
>>          struct phm_ppt_v1_clock_voltage_dependency_table *sclk_table =
>> @@ -1806,11 +1806,8 @@ static int polaris10_populate_clock_stretcher_data_table(struct pp_hwmgr *hwmgr)
>>          }
>>
>>          /* Populate CKS Lookup Table */
>> -       if (stretch_amount == 1 || stretch_amount == 2 || stretch_amount == 5)
>> -               stretch_amount2 = 0;
>> -       else if (stretch_amount == 3 || stretch_amount == 4)
>> -               stretch_amount2 = 1;
>> -       else {
>> +       if (stretch_amount != 1 && stretch_amount != 2 && stretch_amount != 3 &&
>> +                       stretch_amount != 4 && stretch_amount != 5) {
>>                  phm_cap_unset(hwmgr->platform_descriptor.platformCaps,
>>                                  PHM_PlatformCaps_ClockStretcher);
>>                  PP_ASSERT_WITH_CODE(false,
>> --
>> 2.9.0
>>
>
> --
> Mit freundlichen Grüßen,
> Kind regards,
> Matthias Beyer
>
> Proudly sent with mutt.
> Happily signed with gnupg.
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] remove unused variable

[Czarnowska, Anna]

From ccbe8fd4b762d88184c0fea61abb966cf8c99cc9 Mon Sep 17 00:00:00 2001
From: Anna Czarnowska <anna.czarnowska@intel.com>
Date: Mon, 26 Sep 2011 11:54:04 +0200
Subject: [PATCH] remove unused variable

reservation is calculated below in imsm_min_reserved_sectors()
so this variable is not needed

Signed-off-by: Anna Czarnowska <anna.czarnowska@intel.com>
---
 super-intel.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/super-intel.c b/super-intel.c
index 07d47b5..75b432d 100644
--- a/super-intel.c
+++ b/super-intel.c
@@ -988,9 +988,8 @@ static unsigned long long min_acceptable_spare_size_imsm(struct supertype *st)
 	struct dl *dl;
 	struct extent *e;
 	int i;
 	unsigned long long rv = 0;
-	__u32 reservation;
 
 	if (!super)
 		return rv;
 	/* find first active disk in array */
@@ -1006,9 +1005,8 @@ static unsigned long long min_acceptable_spare_size_imsm(struct supertype *st)
 	for (i = 0; e[i].size; i++)
 		continue;
 	if (i > 0)
 		rv = e[i-1].start + e[i-1].size;
-	reservation = __le32_to_cpu(dl->disk.total_blocks) - e[i].start;
 	free(e);
 
 	/* add the amount of space needed for metadata */
 	rv = rv + imsm_min_reserved_sectors(super);
-- 
1.7.4

Re: [PATCH] Remove unused variable

[Johan Hedberg]

Hi Claudio,

On Wed, May 04, 2011, Claudio Takahasi wrote:
> ---
>  src/adapter.c |    5 -----
>  1 files changed, 0 insertions(+), 5 deletions(-)

Pushed upstream. Thanks.

Johan

[PATCH] Remove unused variable

[Claudio Takahasi]

---
 src/adapter.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/src/adapter.c b/src/adapter.c
index 8dbd62c..426df15 100644
--- a/src/adapter.c
+++ b/src/adapter.c
@@ -3255,8 +3255,6 @@ void adapter_add_connection(struct btd_adapter *adapter,
 void adapter_remove_connection(struct btd_adapter *adapter,
 						struct btd_device *device)
 {
-	bdaddr_t bdaddr;
-
 	DBG("");
 
 	if (!g_slist_find(adapter->connections, device)) {
@@ -3268,9 +3266,6 @@ void adapter_remove_connection(struct btd_adapter *adapter,
 
 	adapter->connections = g_slist_remove(adapter->connections, device);
 
-	/* clean pending HCI cmds */
-	device_get_address(device, &bdaddr);
-
 	if (device_is_authenticating(device))
 		device_cancel_authentication(device, TRUE);
 
-- 
1.7.5.rc3

Re: [PATCH] Remove unused variable.

[Ingo Molnar]

* Bernhard Walle <bwalle@suse.de> wrote:

> This patch just fixes the compiler warning:
> 
>   drivers/pci/quirks.c: In function ‘quirk_reroute_to_boot_interrupts_intel’:
>   drivers/pci/quirks.c:1375: warning: unused variable ‘i’

applied to tip/x86/pci-ioapic-boot-irq-quirks, thanks Bernhard.

	Ingo

[PATCH] Remove unused variable.

[Bernhard Walle]

This patch just fixes the compiler warning:

  drivers/pci/quirks.c: In function ‘quirk_reroute_to_boot_interrupts_intel’:
  drivers/pci/quirks.c:1375: warning: unused variable ‘i’


Signed-off-by: Bernhard Walle <bwalle@suse.de>
---
 drivers/pci/quirks.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 4b5b49e..292cf26 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -1372,8 +1372,6 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL,	0x260b, quirk_intel_pcie_pm);
  */
 static void quirk_reroute_to_boot_interrupts_intel(struct pci_dev *dev)
 {
-	int i;
-
 	if (noioapicquirk)
 		return;
 
-- 
1.5.4.5

Re: [PATCH] remove unused variable

[Avi Kivity]

Laurent Vivier wrote:
> Remove unused variable introduced by commit 5ed6627ee96f0a6802d99e71879d98610ba17e01
> (I missed it, sorry)
>
>   


Applied, thanks.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

[PATCH] remove unused variable

[Laurent Vivier]

Remove unused variable introduced by commit 5ed6627ee96f0a6802d99e71879d98610ba17e01
(I missed it, sorry)

Signed-off-by: Laurent Vivier <Laurent.Vivier-6ktuUTfB/bM@public.gmane.org>
---
 drivers/kvm/x86_emulate.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/kvm/x86_emulate.c b/drivers/kvm/x86_emulate.c
index 585cccf..ccdd76f 100644
--- a/drivers/kvm/x86_emulate.c
+++ b/drivers/kvm/x86_emulate.c
@@ -522,7 +522,6 @@ x86_decode_insn(struct x86_emulate_ctxt *ctxt, struct x86_emulate_ops *ops)
 {
 	struct decode_cache *c = &ctxt->decode;
 	u8 sib, rex_prefix = 0;
-	unsigned int i;
 	int rc = 0;
 	int mode = ctxt->mode;
 	int index_reg = 0, base_reg = 0, scale, rip_relative = 0;
-- 
1.5.2.4


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

[PATCH] remove unused variable

[Alex Riesen]

[-- Attachment #1: Type: text/plain, Size: 36 bytes --]

It is just assigned, nothing more.

[-- Attachment #2: 0002-remove-unused-variable.txt --]
[-- Type: text/plain, Size: 672 bytes --]

Subject: [PATCH] remove unused variable

Signed-off-by: Alex Riesen <ariesen@harmanbecker.com>


---

 pack-redundant.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

applies-to: da2488b3948b36edb6f468ad16e247d500679f01
0aeca0da8c4184a8ace0f70ff611527c7f2df75a
diff --git a/pack-redundant.c b/pack-redundant.c
index 3681170..8b37da9 100644
--- a/pack-redundant.c
+++ b/pack-redundant.c
@@ -493,12 +493,10 @@ static void load_all_objects(void)
 {
 	struct pack_list *pl = local_packs;
 	struct llist_item *hint, *l;
-	int i;
 
 	llist_init(&all_objects);
 
 	while (pl) {
-		i = 0;
 		hint = NULL;
 		l = pl->all_objects->front;
 		while (l) {
---
0.99.9.GIT