* [PATCH v2 1/2] drm/fsl-dcu: update the panel dt binding document
@ 2016-06-29 8:17 Meng Yi
[not found] ` <1467188278-10978-1-git-send-email-meng.yi-3arQi8VN3Tc@public.gmane.org>
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Meng Yi @ 2016-06-29 8:17 UTC (permalink / raw)
To: robh+dt-DgEjT+Ai2ygdnm+yROfE0A, shawnguo-DgEjT+Ai2ygdnm+yROfE0A
Cc: stefan-XLVq0VzYD2Y, airlied-cv59FeDIM0c,
emil.l.velikov-Re5JQEeQqe8AvxtiuMwx3w,
jianwei.wang.chn-Re5JQEeQqe8AvxtiuMwx3w,
alexander.stein-93q1YBGzJSMe9JSWTWOYM3xStJ4P+DSV,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
devicetree-u79uwXL29TY76Z2rM5mHXA, Meng Yi
dropped the old "fsl,panel" property, using the of_graph dt
binding syntax
Signed-off-by: Meng Yi <meng.yi-3arQi8VN3Tc@public.gmane.org>
---
Changes in V2:
-drop the unit address of port
---
Documentation/devicetree/bindings/display/fsl,dcu.txt | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/fsl,dcu.txt b/Documentation/devicetree/bindings/display/fsl,dcu.txt
index ae55cde..c96ec1f 100644
--- a/Documentation/devicetree/bindings/display/fsl,dcu.txt
+++ b/Documentation/devicetree/bindings/display/fsl,dcu.txt
@@ -12,7 +12,7 @@ Required properties:
- clock-names: Should be "dcu" and "pix"
See ../clocks/clock-bindings.txt for details.
- big-endian Boolean property, LS1021A DCU registers are big-endian.
-- fsl,panel: The phandle to panel node.
+- port Video port for the panel output
Optional properties:
- fsl,tcon: The phandle to the timing controller node.
@@ -24,6 +24,11 @@ dcu: dcu@2ce0000 {
clocks = <&platform_clk 0>, <&platform_clk 0>;
clock-names = "dcu", "pix";
big-endian;
- fsl,panel = <&panel>;
fsl,tcon = <&tcon>;
+
+ port: port {
+ dcu_out: endpoint {
+ remote-endpoint = <&panel_out>;
+ };
+ };
};
--
2.1.0.27.g96db324
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2 2/2] drm/fsl-dcu: update panel syntax to of_graph dt binding
[not found] ` <1467188278-10978-1-git-send-email-meng.yi-3arQi8VN3Tc@public.gmane.org>
@ 2016-06-29 8:17 ` Meng Yi
2016-07-14 6:36 ` Stefan Agner
0 siblings, 1 reply; 5+ messages in thread
From: Meng Yi @ 2016-06-29 8:17 UTC (permalink / raw)
To: robh+dt-DgEjT+Ai2ygdnm+yROfE0A, shawnguo-DgEjT+Ai2ygdnm+yROfE0A
Cc: stefan-XLVq0VzYD2Y, airlied-cv59FeDIM0c,
emil.l.velikov-Re5JQEeQqe8AvxtiuMwx3w,
jianwei.wang.chn-Re5JQEeQqe8AvxtiuMwx3w,
alexander.stein-93q1YBGzJSMe9JSWTWOYM3xStJ4P+DSV,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
devicetree-u79uwXL29TY76Z2rM5mHXA, Meng Yi
add of_graph dt binding for panel, and "fsl,panel" property
is deprecated
Signed-off-by: Meng Yi <meng.yi-3arQi8VN3Tc@public.gmane.org>
---
Changes in V2:
-dropp the unit address of port
---
arch/arm/boot/dts/ls1021a-twr.dts | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/ls1021a-twr.dts b/arch/arm/boot/dts/ls1021a-twr.dts
index 75ecaed..cbd92c8 100644
--- a/arch/arm/boot/dts/ls1021a-twr.dts
+++ b/arch/arm/boot/dts/ls1021a-twr.dts
@@ -108,12 +108,22 @@
panel: panel {
compatible = "nec,nl4827hc19-05b";
+ port {
+ panel_out: endpoint {
+ remote-endpoint = <&dcu_out>;
+ };
+ };
};
};
&dcu {
- fsl,panel = <&panel>;
status = "okay";
+
+ port: port {
+ dcu_out: endpoint {
+ remote-endpoint = <&panel_out>;
+ };
+ };
};
&dspi1 {
--
2.1.0.27.g96db324
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/2] drm/fsl-dcu: update the panel dt binding document
2016-06-29 8:17 [PATCH v2 1/2] drm/fsl-dcu: update the panel dt binding document Meng Yi
[not found] ` <1467188278-10978-1-git-send-email-meng.yi-3arQi8VN3Tc@public.gmane.org>
@ 2016-07-01 1:37 ` Rob Herring
2016-07-14 6:30 ` Stefan Agner
2 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2016-07-01 1:37 UTC (permalink / raw)
To: Meng Yi
Cc: jianwei.wang.chn, devicetree, emil.l.velikov, dri-devel,
shawnguo, alexander.stein
On Wed, Jun 29, 2016 at 04:17:57PM +0800, Meng Yi wrote:
> dropped the old "fsl,panel" property, using the of_graph dt
> binding syntax
>
> Signed-off-by: Meng Yi <meng.yi@nxp.com>
> ---
> Changes in V2:
> -drop the unit address of port
> ---
> Documentation/devicetree/bindings/display/fsl,dcu.txt | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
Acked-by: Rob Herring <robh@kernel.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/2] drm/fsl-dcu: update the panel dt binding document
2016-06-29 8:17 [PATCH v2 1/2] drm/fsl-dcu: update the panel dt binding document Meng Yi
[not found] ` <1467188278-10978-1-git-send-email-meng.yi-3arQi8VN3Tc@public.gmane.org>
2016-07-01 1:37 ` [PATCH v2 1/2] drm/fsl-dcu: update the panel dt binding document Rob Herring
@ 2016-07-14 6:30 ` Stefan Agner
2 siblings, 0 replies; 5+ messages in thread
From: Stefan Agner @ 2016-07-14 6:30 UTC (permalink / raw)
To: Meng Yi
Cc: jianwei.wang.chn, devicetree, emil.l.velikov, dri-devel, robh+dt,
shawnguo, alexander.stein
On 2016-06-29 01:17, Meng Yi wrote:
> dropped the old "fsl,panel" property, using the of_graph dt
> binding syntax
>
> Signed-off-by: Meng Yi <meng.yi@nxp.com>
> ---
> Changes in V2:
> -drop the unit address of port
> ---
> Documentation/devicetree/bindings/display/fsl,dcu.txt | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/fsl,dcu.txt
> b/Documentation/devicetree/bindings/display/fsl,dcu.txt
> index ae55cde..c96ec1f 100644
> --- a/Documentation/devicetree/bindings/display/fsl,dcu.txt
> +++ b/Documentation/devicetree/bindings/display/fsl,dcu.txt
> @@ -12,7 +12,7 @@ Required properties:
> - clock-names: Should be "dcu" and "pix"
> See ../clocks/clock-bindings.txt for details.
> - big-endian Boolean property, LS1021A DCU registers are big-endian.
> -- fsl,panel: The phandle to panel node.
> +- port Video port for the panel output
>
> Optional properties:
> - fsl,tcon: The phandle to the timing controller node.
> @@ -24,6 +24,11 @@ dcu: dcu@2ce0000 {
> clocks = <&platform_clk 0>, <&platform_clk 0>;
> clock-names = "dcu", "pix";
> big-endian;
> - fsl,panel = <&panel>;
> fsl,tcon = <&tcon>;
> +
> + port: port {
Port does not need a label here.
> + dcu_out: endpoint {
> + remote-endpoint = <&panel_out>;
> + };
> + };
> };
Otherwise looks good. However, I would prefer to have this change as
part of the corresponding driver change. Can you squash that into the
"drm/fsl-dcu: rework codes to support of_graph dt binding for panel"
patch?
--
Stefan
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 2/2] drm/fsl-dcu: update panel syntax to of_graph dt binding
2016-06-29 8:17 ` [PATCH v2 2/2] drm/fsl-dcu: update panel syntax to of_graph dt binding Meng Yi
@ 2016-07-14 6:36 ` Stefan Agner
0 siblings, 0 replies; 5+ messages in thread
From: Stefan Agner @ 2016-07-14 6:36 UTC (permalink / raw)
To: Meng Yi
Cc: jianwei.wang.chn, devicetree, emil.l.velikov, dri-devel, robh+dt,
shawnguo, alexander.stein
On 2016-06-29 01:17, Meng Yi wrote:
> add of_graph dt binding for panel, and "fsl,panel" property
Nit: "binding" typically describes the requirement, the specification
and hence is under Documentation/devicetree/bindings/.
What you add here is the dt nodes according to the bindings...
Hence I would say something like
Add of_graph dt nodes to describe the panel and remove the "fsl,panel"
property.
> is deprecated
>
> Signed-off-by: Meng Yi <meng.yi@nxp.com>
> ---
> Changes in V2:
> -dropp the unit address of port
> ---
> arch/arm/boot/dts/ls1021a-twr.dts | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/ls1021a-twr.dts
> b/arch/arm/boot/dts/ls1021a-twr.dts
> index 75ecaed..cbd92c8 100644
> --- a/arch/arm/boot/dts/ls1021a-twr.dts
> +++ b/arch/arm/boot/dts/ls1021a-twr.dts
> @@ -108,12 +108,22 @@
>
> panel: panel {
> compatible = "nec,nl4827hc19-05b";
Nit: We typically add a new line before adding a subnode.
> + port {
> + panel_out: endpoint {
> + remote-endpoint = <&dcu_out>;
> + };
> + };
> };
> };
>
> &dcu {
> - fsl,panel = <&panel>;
> status = "okay";
> +
> + port: port {
Same as in bindings, port does not need a label too.
> + dcu_out: endpoint {
> + remote-endpoint = <&panel_out>;
> + };
> + };
> };
>
> &dspi1 {
There is still a patch for vf-colibri-eval-v3.dtsi missing which does
the same.
--
Stefan
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-07-14 6:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-29 8:17 [PATCH v2 1/2] drm/fsl-dcu: update the panel dt binding document Meng Yi
[not found] ` <1467188278-10978-1-git-send-email-meng.yi-3arQi8VN3Tc@public.gmane.org>
2016-06-29 8:17 ` [PATCH v2 2/2] drm/fsl-dcu: update panel syntax to of_graph dt binding Meng Yi
2016-07-14 6:36 ` Stefan Agner
2016-07-01 1:37 ` [PATCH v2 1/2] drm/fsl-dcu: update the panel dt binding document Rob Herring
2016-07-14 6:30 ` Stefan Agner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.