All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Jianfeng Tan <jianfeng.tan@intel.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com, huawei.xie@intel.com,
	thomas.monjalon@6wind.com
Subject: Re: [PATCH] net/virtio-user: fix missing default macro
Date: Fri, 1 Jul 2016 10:05:57 +0800	[thread overview]
Message-ID: <20160701020557.GN2831@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <1467170406-137615-1-git-send-email-jianfeng.tan@intel.com>

On Wed, Jun 29, 2016 at 03:20:06AM +0000, Jianfeng Tan wrote:
> With current config structure, all configuration parameters put into
> common_base with a default value, and overwritten in environment file
> if required, CONFIG_RTE_VIRTIO_USER is missing in common_base.
> 
> This fix is simple, by adding CONFIG_RTE_VIRTIO_USER=n as the default
> macro value.
> 
> Fixes: ce2eabdd43ec ("net/virtio-user: add virtual device")
> 
> Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
> ---
>  config/common_base | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/config/common_base b/config/common_base
> index 5d9daf5..0368d59 100644
> --- a/config/common_base
> +++ b/config/common_base
> @@ -269,6 +269,11 @@ CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_DRIVER=n
>  CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_DUMP=n
>  
>  #
> +# Compile software VIRTIO-USER PMD driver

I will not call it "PMD driver", instead, I'd say "virtio device
emulation inside virtio PMD".

Fixed and applied to dpdk-next-virtio.

	--yliu

> +#
> +CONFIG_RTE_VIRTIO_USER=n
> +
> +#
>  # Compile burst-oriented VMXNET3 PMD driver
>  #
>  CONFIG_RTE_LIBRTE_VMXNET3_PMD=y
> -- 
> 2.1.4

      reply	other threads:[~2016-07-01  2:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-29  3:20 [PATCH] net/virtio-user: fix missing default macro Jianfeng Tan
2016-07-01  2:05 ` Yuanhan Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160701020557.GN2831@yliu-dev.sh.intel.com \
    --to=yuanhan.liu@linux.intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=huawei.xie@intel.com \
    --cc=jianfeng.tan@intel.com \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.