* [PATCH] net/virtio-user: fix missing default macro
@ 2016-06-29 3:20 Jianfeng Tan
2016-07-01 2:05 ` Yuanhan Liu
0 siblings, 1 reply; 2+ messages in thread
From: Jianfeng Tan @ 2016-06-29 3:20 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, yuanhan.liu, huawei.xie, thomas.monjalon, Jianfeng Tan
With current config structure, all configuration parameters put into
common_base with a default value, and overwritten in environment file
if required, CONFIG_RTE_VIRTIO_USER is missing in common_base.
This fix is simple, by adding CONFIG_RTE_VIRTIO_USER=n as the default
macro value.
Fixes: ce2eabdd43ec ("net/virtio-user: add virtual device")
Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
---
config/common_base | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/config/common_base b/config/common_base
index 5d9daf5..0368d59 100644
--- a/config/common_base
+++ b/config/common_base
@@ -269,6 +269,11 @@ CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_DRIVER=n
CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_DUMP=n
#
+# Compile software VIRTIO-USER PMD driver
+#
+CONFIG_RTE_VIRTIO_USER=n
+
+#
# Compile burst-oriented VMXNET3 PMD driver
#
CONFIG_RTE_LIBRTE_VMXNET3_PMD=y
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net/virtio-user: fix missing default macro
2016-06-29 3:20 [PATCH] net/virtio-user: fix missing default macro Jianfeng Tan
@ 2016-07-01 2:05 ` Yuanhan Liu
0 siblings, 0 replies; 2+ messages in thread
From: Yuanhan Liu @ 2016-07-01 2:05 UTC (permalink / raw)
To: Jianfeng Tan; +Cc: dev, ferruh.yigit, huawei.xie, thomas.monjalon
On Wed, Jun 29, 2016 at 03:20:06AM +0000, Jianfeng Tan wrote:
> With current config structure, all configuration parameters put into
> common_base with a default value, and overwritten in environment file
> if required, CONFIG_RTE_VIRTIO_USER is missing in common_base.
>
> This fix is simple, by adding CONFIG_RTE_VIRTIO_USER=n as the default
> macro value.
>
> Fixes: ce2eabdd43ec ("net/virtio-user: add virtual device")
>
> Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
> ---
> config/common_base | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/config/common_base b/config/common_base
> index 5d9daf5..0368d59 100644
> --- a/config/common_base
> +++ b/config/common_base
> @@ -269,6 +269,11 @@ CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_DRIVER=n
> CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_DUMP=n
>
> #
> +# Compile software VIRTIO-USER PMD driver
I will not call it "PMD driver", instead, I'd say "virtio device
emulation inside virtio PMD".
Fixed and applied to dpdk-next-virtio.
--yliu
> +#
> +CONFIG_RTE_VIRTIO_USER=n
> +
> +#
> # Compile burst-oriented VMXNET3 PMD driver
> #
> CONFIG_RTE_LIBRTE_VMXNET3_PMD=y
> --
> 2.1.4
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-01 2:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-29 3:20 [PATCH] net/virtio-user: fix missing default macro Jianfeng Tan
2016-07-01 2:05 ` Yuanhan Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.